Uh oh!
There was an error while loading. Please reload this page.
Add a test for sync root outside of git root - #2202
Conversation
| @@ -0,0 +1,6 @@ | |||
| # This should error, we do not allow syncroot outside of git repo | |||
There was a problem hiding this comment.
Is there a reason why we won't allow it? I can imagine the case when users want to sync build artifacts which are not part of the git repo as well
There was a problem hiding this comment.
The idea here is that if people use git, they want reproducibility, so sources should be in git.
build artifacts can be placed inside git root and gitignored.
5f054cb to
f91be8aCompare| r.appendLiteral(old, new) | ||
| } | ||
| func trimQuotes(s string) string { |
There was a problem hiding this comment.
Why is this needed?
If we only care about quoting strings, you can look at fmt.Sprintf with %q.
There was a problem hiding this comment.
I care about strings inside JSON that might have been concatenated with others, e.g. xy becomes "XY" in json. Now I need to replace x -> X.
- Move acceptance/bundle/sync-paths-dotdot test to acceptance/bundle/syncroot/dotdot-notgit - Add new test acceptance/bundle/syncroot/dotdot-git Fix replacer to work with this test and on Windows: - Make PATH work on Windows by using EvalSymlinks. - Make concatenated path match within JSON but stripping quotes.
Fix replacer to work with this test and on Windows: