Uh oh!
There was an error while loading. Please reload this page.
Always print warnings and errors; clean up format - #2213
Merged
Conversation
denikforce-pushed
the
DECO-24321---ErrAlreadyPrinted
branch
from
January 23, 2025 11:00
0f46e56 to
efc48f1Comparedenikforce-pushed
the
DECO-24321---ErrAlreadyPrinted
branch
from
January 24, 2025 16:31
efc48f1 to
131b414Comparedenikforce-pushed
the
DECO-24321---ErrAlreadyPrinted
branch
from
January 24, 2025 17:40
35ef576 to
ff95005Comparedenikforce-pushed
the
DECO-24321---ErrAlreadyPrinted
branch
from
January 24, 2025 19:20
4406d92 to
7d12edeComparedenikforce-pushed
the
DECO-24321---ErrAlreadyPrinted
branch
from
January 27, 2025 08:33
7d12ede to
b57aaf3Comparedenikforce-pushed
the
DECO-24321---ErrAlreadyPrinted
branch
from
January 27, 2025 08:44
b57aaf3 to
cf5d64bComparedenikforce-pushed
the
DECO-24321---ErrAlreadyPrinted
branch
from
January 27, 2025 08:56
cf5d64b to
6e50210Comparedenik
marked this pull request as ready for review
January 27, 2025 09:01
denikforce-pushed
the
DECO-24321---ErrAlreadyPrinted
branch
from
January 31, 2025 21:42
5149c9a to
f7e95e3Comparedenik
commented
Feb 4, 2025
ContributorAuthor
I've silenced "unable to delete filer root" warning 547bd83 please take another look @pietern@andrewnester |
This seems redundant - nothing is lost.
- remove time - remove attrs unless level is debug - replace $DEV_VERSION - add acceptance test for --debug
Might be fixable with Locale setting (https://stackoverflow.com/a/39172728), but it's easier just not to depend on it.
…facts/.internal: unable to delete filer root to warning
The comment says it's intentional:
// We intentionally ignore the error because it is not critical to the deployment
err := client.Delete(ctx, ".", filer.DeleteRecursively)
if err != nil {
log.Errorf(ctx, "failed to delete %s: %v", uploadPath, err)pietern
reviewed
Feb 7, 2025
| }) | ||
| } | ||
Contributor
There was a problem hiding this comment.
When incorporating diagnostics, we can evaluate whether it makes sense to use a different handler instead of having the conditionals here. In default operation, we don't care about the additional attrs, nor time, nor source locations, etc, but with additional verbosity we do. It could be easier to swap out the handler instead.
| err := client.Delete(ctx, ".", filer.DeleteRecursively) | ||
| if err != nil { | ||
| log.Errorf(ctx, "failed to delete %s: %v", uploadPath, err) | ||
| log.Debugf(ctx, "failed to delete %s: %v", uploadPath, err) |
Contributor
There was a problem hiding this comment.
We should evaluate the error classes in this condition and ignore the predictable errors (ie. the path doesn't exist) and return an error on real errors (like below).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
--debugoutput.