Uh oh!
There was an error while loading. Please reload this page.
acc: Support custom replacements - #2231
Merged
Merged
Conversation
denik
requested review from
andrewnester, pietern and shreyas-goenka
as code ownersJanuary 27, 2025 08:40
pietern
approved these changes
Jan 27, 2025
| GOOS map[string]bool | ||
| // List of additional replacements to apply on this test. | ||
| // Old is a regexp, New is a replacement expression. |
Contributor
There was a problem hiding this comment.
These are applied last, right?
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Ability to extend a list of replacements via test.toml - Modify selftest to both demo this feature and to get rid of sed on Windows. ## Tests Acceptance tests. I'm also using it #2213 for things like pid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Acceptance tests. I'm also using it #2213 for things like pid.