Uh oh!
There was an error while loading. Please reload this page.
Fix for regression deploying resources with PyPi and Maven library types - #2341
Merged
Conversation
andrewnester
requested review from
denik, pietern and shreyas-goenka
as code ownersFebruary 12, 2025 16:07
andrewnestertemporarily deployed
to
test-trigger-is
February 12, 2025 16:07 — with 
GitHub Actions
Inactive
pietern
approved these changes
Feb 12, 2025
andrewnester added a commit
that referenced
this pull request
Feb 12, 2025
pietern added a commit
that referenced
this pull request
Feb 12, 2025
## Changes These changes break the use of non-local libraries (such as PyPI libraries). This reverts the set so we can cut a patch release and take a closer look later. Original PRs are #2297 and #2341. Issue reported in #2343. ## Tests Manually confirmed that a bundle with PyPI package in libraries now deploys fine.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Feb 27, 2025
…basename used (#2382) ## Changes It could happen that there are multiple artifacts defined in the bundle which build and therefore deploy wheel packages with the same name. This leads to conflict between these packages, they will overwrite each other and therefore they should have different names instead Fixes#1674 Previous attempt (#2297 + #2341) led to the breakage, this PR fixes both issues. ## Tests Added acceptance test
HariGS-DB pushed a commit
to HariGS-DB/cli
that referenced
this pull request
Feb 28, 2025
…basename used (databricks#2382) ## Changes It could happen that there are multiple artifacts defined in the bundle which build and therefore deploy wheel packages with the same name. This leads to conflict between these packages, they will overwrite each other and therefore they should have different names instead Fixesdatabricks#1674 Previous attempt (databricks#2297 + databricks#2341) led to the breakage, this PR fixes both issues. ## Tests Added acceptance test
denik pushed a commit
that referenced
this pull request
May 20, 2026
…pes (#2341) ## Changes The CheckForSameNameLibraries mutator incorrectly assumed all resource libraries define libraries as paths of the `string` type, but some libraries, such as PyPi and Maven, define them as objects. This PR addresses this issue. It was introduced in #2297. ## Tests Added regression test.
denik pushed a commit
that referenced
this pull request
May 20, 2026
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes These changes break the use of non-local libraries (such as PyPI libraries). This reverts the set so we can cut a patch release and take a closer look later. Original PRs are #2297 and #2341. Issue reported in #2343. ## Tests Manually confirmed that a bundle with PyPI package in libraries now deploys fine.
denik pushed a commit
that referenced
this pull request
May 20, 2026
…basename used (#2382) ## Changes It could happen that there are multiple artifacts defined in the bundle which build and therefore deploy wheel packages with the same name. This leads to conflict between these packages, they will overwrite each other and therefore they should have different names instead Fixes#1674 Previous attempt (#2297 + #2341) led to the breakage, this PR fixes both issues. ## Tests Added acceptance test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The CheckForSameNameLibraries mutator incorrectly assumed all resource libraries define libraries as paths of the
stringtype, but some libraries, such as PyPi and Maven, define them as objects.This PR addresses this issue. It was introduced in #2297.
Tests
Added regression test.