Skip to content

Raise an error when there are multiple local libraries with the same basename used - #2297

Merged
andrewnester merged 5 commits into
mainfrom
fix/same-name-wheels
Feb 7, 2025
Merged

Raise an error when there are multiple local libraries with the same basename used#2297
andrewnester merged 5 commits into
mainfrom
fix/same-name-wheels

Conversation

@andrewnester

@andrewnesterandrewnester commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

Changes

Raise an error when there are multiple local libraries with the same basename used

Fixes#1674

Tests

Added an unit test

denik
denik reviewed Feb 5, 2025
View reviewed changes
Comment threadbundle/libraries/same_name_libraries_test.go Outdated
denik
denik reviewed Feb 5, 2025
View reviewed changes
Comment threadbundle/phases/deploy.go
denik
denik approved these changes Feb 5, 2025
View reviewed changes
Comment threadbundle/libraries/same_name_libraries_test.go Outdated
pietern
pietern reviewed Feb 7, 2025
View reviewed changes
Comment threadbundle/libraries/same_name_libraries.go Outdated
Comment threadbundle/libraries/same_name_libraries.go Outdated
Comment threadbundle/libraries/same_name_libraries_test.go
@denik
denik self-requested a review February 7, 2025 16:44
@andrewnester
andrewnester added this pull request to the merge queueFeb 7, 2025
Merged via the queue into main with commit 2a97dcaFeb 7, 2025
@andrewnester
andrewnester deleted the fix/same-name-wheels branch February 7, 2025 18:03
andrewnester added a commit that referenced this pull request Feb 12, 2025
@andrewnester
[Release] Release v0.241.0
d5a6862
Bundles:
* Added support to generate Git based jobs ([#2304](#2304)).
* Added support for run_as in pipelines ([#2287](#2287)).
* Raise an error when there are multiple local libraries with the same basename used ([#2297](#2297)).
* Fix env variable for AzureCli local config ([#2248](#2248)).
* Accept JSON files in includes section ([#2265](#2265)).
* Always print warnings and errors; clean up format ([#2213](#2213))
API Changes:
* Added `databricks account budget-policy` command group.
* Added `databricks lakeview-embedded` command group.
* Added `databricks query-execution` command group.
* Changed `databricks serving-endpoints http-request` command to type `databricks serving-endpoints http-request` command.
* Added `databricks account enable-ip-access-lists` command group.
* Added `databricks redash-config` command group.
OpenAPI commit c72c58f97b950fcb924a90ef164bcb10cfcd5ece (2025-02-03)
Dependency updates:
* Upgrade to TF provider 1.65.1 ([#2328](#2328)).
* Bump golangci/golangci-lint-action from 6.1.1 to 6.2.0 ([#2273](#2273)).
* Bump astral-sh/ruff-action from 3.0.1 to 3.1.0 ([#2274](#2274)).
* Bump actions/stale from 9.0.0 to 9.1.0 ([#2275](#2275)).
* Bump actions/create-github-app-token from 1.11.1 to 1.11.2 ([#2276](#2276)).
* Bump github.com/hashicorp/terraform-exec from 0.21.0 to 0.22.0 ([#2237](#2237)).
* Bump github.com/spf13/pflag from 1.0.5 to 1.0.6 ([#2281](#2281)).
* Bump github.com/databricks/databricks-sdk-go from 0.56.1 to 0.57.0 ([#2321](#2321)).
* Bump golang.org/x/oauth2 from 0.25.0 to 0.26.0 ([#2322](#2322)).
* Bump golang.org/x/term from 0.28.0 to 0.29.0 ([#2325](#2325)).
* Bump golang.org/x/text from 0.21.0 to 0.22.0 ([#2323](#2323)).
* Bump golang.org/x/mod from 0.22.0 to 0.23.0 ([#2324](#2324)).
@andrewnesterandrewnester mentioned this pull request Feb 12, 2025
Merged
andrewnester added a commit that referenced this pull request Feb 12, 2025
@andrewnester
[Release] Release v0.241.0 (#2340)
1dadc79
Bundles:
* Added support to generate Git based jobs
([#2304](#2304)).
* Added support for run_as in pipelines
([#2287](#2287)).
* Raise an error when there are multiple local libraries with the same
basename used ([#2297](#2297)).
* Fix env variable for AzureCli local config
([#2248](#2248)).
* Accept JSON files in includes section
([#2265](#2265)).
* Always print warnings and errors; clean up format
([#2213](#2213))
API Changes:
* Added `databricks account budget-policy` command group.
* Added `databricks lakeview-embedded` command group.
* Added `databricks query-execution` command group.
* Added `databricks account enable-ip-access-lists` command group.
* Added `databricks redash-config` command group.
OpenAPI commit c72c58f97b950fcb924a90ef164bcb10cfcd5ece (2025-02-03)
Dependency updates:
* Upgrade to TF provider 1.65.1
([#2328](#2328)).
* Bump github.com/hashicorp/terraform-exec from 0.21.0 to 0.22.0
([#2237](#2237)).
* Bump github.com/spf13/pflag from 1.0.5 to 1.0.6
([#2281](#2281)).
* Bump github.com/databricks/databricks-sdk-go from 0.56.1 to 0.57.0
([#2321](#2321)).
* Bump golang.org/x/oauth2 from 0.25.0 to 0.26.0
([#2322](#2322)).
* Bump golang.org/x/term from 0.28.0 to 0.29.0
([#2325](#2325)).
* Bump golang.org/x/text from 0.21.0 to 0.22.0
([#2323](#2323)).
* Bump golang.org/x/mod from 0.22.0 to 0.23.0
([#2324](#2324)).
@pieternpietern mentioned this pull request Feb 12, 2025
Merged
andrewnester added a commit that referenced this pull request Feb 12, 2025
@andrewnester
Fix for regression deploying resources with PyPi and Maven library ty…
ac439f8
…pes (#2341)
## Changes
The CheckForSameNameLibraries mutator incorrectly assumed all resource
libraries define libraries as paths of the `string` type, but some
libraries, such as PyPi and Maven, define them as objects.
This PR addresses this issue. It was introduced in #2297.
## Tests
Added regression test.
pietern added a commit that referenced this pull request Feb 12, 2025
@pietern
Revert "Raise an error when there are multiple local libraries with t…
517faa7
…he same basename used (#2297)"
This reverts commit 2a97dca.
@pieternpietern mentioned this pull request Feb 12, 2025
Merged
pietern added a commit that referenced this pull request Feb 12, 2025
@pietern
Revert changes related to basename check for local libraries (#2345)
96302c7
## Changes
These changes break the use of non-local libraries (such as PyPI
libraries).
This reverts the set so we can cut a patch release and take a closer
look later.
Original PRs are #2297 and #2341.
Issue reported in #2343.
## Tests
Manually confirmed that a bundle with PyPI package in libraries now
deploys fine.
@andrewnesterandrewnester mentioned this pull request Feb 26, 2025
Merged
github-merge-queueBot pushed a commit that referenced this pull request Feb 27, 2025
@andrewnester
Raise an error when there are multiple local libraries with the same …
6a07e05
…basename used (#2382)
## Changes
It could happen that there are multiple artifacts defined in the bundle
which build and therefore deploy wheel packages with the same name. This
leads to conflict between these packages, they will overwrite each other
and therefore they should have different names instead
Fixes#1674
Previous attempt (#2297 +
#2341) led to the breakage, this
PR fixes both issues.
## Tests
Added acceptance test
HariGS-DB pushed a commit to HariGS-DB/cli that referenced this pull request Feb 28, 2025
@andrewnester@HariGS-DB
Raise an error when there are multiple local libraries with the same …
3218598
…basename used (databricks#2382)
## Changes
It could happen that there are multiple artifacts defined in the bundle
which build and therefore deploy wheel packages with the same name. This
leads to conflict between these packages, they will overwrite each other
and therefore they should have different names instead
Fixesdatabricks#1674
Previous attempt (databricks#2297 +
databricks#2341) led to the breakage, this
PR fixes both issues.
## Tests
Added acceptance test
denik pushed a commit that referenced this pull request May 20, 2026
@andrewnester
Raise an error when there are multiple local libraries with the same …
6d74577
…basename used (#2297)
## Changes
Raise an error when there are multiple local libraries with the same
basename used
Fixes#1674
## Tests
Added an unit test
denik pushed a commit that referenced this pull request May 20, 2026
@andrewnester
[Release] Release v0.241.0 (#2340)
46d4bf4
Bundles:
* Added support to generate Git based jobs
([#2304](#2304)).
* Added support for run_as in pipelines
([#2287](#2287)).
* Raise an error when there are multiple local libraries with the same
basename used ([#2297](#2297)).
* Fix env variable for AzureCli local config
([#2248](#2248)).
* Accept JSON files in includes section
([#2265](#2265)).
* Always print warnings and errors; clean up format
([#2213](#2213))
API Changes:
* Added `databricks account budget-policy` command group.
* Added `databricks lakeview-embedded` command group.
* Added `databricks query-execution` command group.
* Added `databricks account enable-ip-access-lists` command group.
* Added `databricks redash-config` command group.
OpenAPI commit c72c58f97b950fcb924a90ef164bcb10cfcd5ece (2025-02-03)
Dependency updates:
* Upgrade to TF provider 1.65.1
([#2328](#2328)).
* Bump github.com/hashicorp/terraform-exec from 0.21.0 to 0.22.0
([#2237](#2237)).
* Bump github.com/spf13/pflag from 1.0.5 to 1.0.6
([#2281](#2281)).
* Bump github.com/databricks/databricks-sdk-go from 0.56.1 to 0.57.0
([#2321](#2321)).
* Bump golang.org/x/oauth2 from 0.25.0 to 0.26.0
([#2322](#2322)).
* Bump golang.org/x/term from 0.28.0 to 0.29.0
([#2325](#2325)).
* Bump golang.org/x/text from 0.21.0 to 0.22.0
([#2323](#2323)).
* Bump golang.org/x/mod from 0.22.0 to 0.23.0
([#2324](#2324)).
denik pushed a commit that referenced this pull request May 20, 2026
@andrewnester
Fix for regression deploying resources with PyPi and Maven library ty…
09a64a9
…pes (#2341)
## Changes
The CheckForSameNameLibraries mutator incorrectly assumed all resource
libraries define libraries as paths of the `string` type, but some
libraries, such as PyPi and Maven, define them as objects.
This PR addresses this issue. It was introduced in #2297.
## Tests
Added regression test.
denik pushed a commit that referenced this pull request May 20, 2026
@pietern
Revert changes related to basename check for local libraries (#2345)
7454478
## Changes
These changes break the use of non-local libraries (such as PyPI
libraries).
This reverts the set so we can cut a patch release and take a closer
look later.
Original PRs are #2297 and #2341.
Issue reported in #2343.
## Tests
Manually confirmed that a bundle with PyPI package in libraries now
deploys fine.
denik pushed a commit that referenced this pull request May 20, 2026
@andrewnester
Raise an error when there are multiple local libraries with the same …
2085762
…basename used (#2382)
## Changes
It could happen that there are multiple artifacts defined in the bundle
which build and therefore deploy wheel packages with the same name. This
leads to conflict between these packages, they will overwrite each other
and therefore they should have different names instead
Fixes#1674
Previous attempt (#2297 +
#2341) led to the breakage, this
PR fixes both issues.
## Tests
Added acceptance test
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreyas-goenkashreyas-goenkaAwaiting requested review from shreyas-goenka
@denikdenikAwaiting requested review from denik
@pieternpieternAwaiting requested review from pietern

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Libraries with the same name but different path override each other

3 participants

@andrewnester@pietern@denik