Uh oh!
There was an error while loading. Please reload this page.
[Python] Add generated code for pipelines - #2639
Merged
Merged
Conversation
kanterov
marked this pull request as ready for review
April 8, 2025 14:12
kanterov
requested review from
andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersApril 8, 2025 14:12
kanterov
commented
Apr 8, 2025
CollaboratorAuthor
@pietern Good catch, the code implementing merging of JSON schema didn't work correctly after rebase. I've fixed it now All necessary changes are in https://github.com/databricks/cli/tree/codegen-all, but it needs to be split into multiple PRs. It would be great if we could merge the first PR with codegen first and iterate on top of it. |
pietern
commented
Apr 9, 2025
Contributor
Thanks for clarifying. The first codegen PR has some small comments that should be easy to address + merge. Are you saying the tree you link has a bunch of changes stacked on top of what's in #2507? |
pietern
approved these changes
Apr 9, 2025
kanterov
enabled auto-merge
April 9, 2025 09:10
CollaboratorAuthor
@pietern there are a few changes needed:
|
There are warnings because the same classes are included into jobs and pipeline packages. We will fix it when we change code generation to vendor compute package into each resource using it. The output for docs already looks correct
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Add generated code for pipelines support introduced in #2574
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add generated code for pipelines support introduced in #2574