Uh oh!
There was an error while loading. Please reload this page.
Mark deprecated pipeline fields - #2646
Merged
Merged
Conversation
kanterovforce-pushed
the
pipeline-deprecated
branch
from
April 3, 2025 14:23
16eaf6a to
75b7155Comparekanterov
marked this pull request as ready for review
April 3, 2025 18:29
kanterov
requested review from
andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersApril 3, 2025 18:29
denik
reviewed
Apr 4, 2025
Uh oh!
There was an error while loading. Please reload this page.
lennartkats-db
approved these changes
Apr 7, 2025
pietern
requested changes
Apr 7, 2025
Uh oh!
There was an error while loading. Please reload this page.
pietern
reviewed
Apr 8, 2025
Uh oh!
There was an error while loading. Please reload this page.
| "target": | ||
| # should not be marked as deprecated until its possible to switch | ||
| # existing pipelines to use 'schema' instead | ||
| "deprecated": false |
Contributor
There was a problem hiding this comment.
Is this set as deprecated in the annotations file already?
If not, absence of an entry means it won't be set.
CollaboratorAuthor
There was a problem hiding this comment.
It's primarily for the case when parent file gets deprecated annotation from OpenAPI spec
| Enum []any `json:"enum,omitempty"` | ||
| MarkdownExamples string `json:"markdown_examples,omitempty"` | ||
| DeprecationMessage string `json:"deprecation_message,omitempty"` | ||
| Deprecated bool `json:"deprecated,omitempty"` |
Contributor
There was a problem hiding this comment.
This is duplicated in #2652. What's the sequence of merging you're thinking of?
CollaboratorAuthor
There was a problem hiding this comment.
It doesn't matter much, because we can rebase one PR on another. This PR is more important, I feel it will take time to review all deprecations introduced in #2652
| } | ||
| if a.Deprecated { | ||
| s.Deprecated = true | ||
| } |
Contributor
There was a problem hiding this comment.
Please define what happens if Deprecated == false and DeprecationMessage != "".
This seems confusing. Alternatively, we can exclusively use the message field for this.
cc @ilyakuz-db
Uh oh!
There was an error while loading. Please reload this page.
ilyakuz-db
approved these changes
Apr 8, 2025
Uh oh!
There was an error while loading. Please reload this page.
kanterov
commented
Apr 8, 2025
CollaboratorAuthor
@pietern does it look good now? we need an approval for code owners |
kanterov added a commit
that referenced
this pull request
Apr 8, 2025
Update JSON schema for pipelines with deprecated fields. While fields have been deprecated for a long time, we have to use overrides until we propagate deprecated annotation from the OpenAPI spec. We need to manually set a deprecation message because the OpenAPI spec doesn't have such a field. A deprecation message is a part of the description that doesn't create an actionable tooltip. `target` is not marked as deprecated. While `schema` is preferred over `target`, currently, it isn't possible to update existing pipelines from using `target` to using `schema` without re-creating them. These fields should be avoided
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Apr 9, 2025
## Release v0.247.0 ### CLI * Added include/exclude flags support to sync command ([#2650](#2650)) ### Bundles * Added support for model serving endpoints in deployment bind/unbind commands ([#2634](#2634)) * Added include/exclude flags support to bundle sync command ([#2650](#2650)) * Added JSON schema for resource permissions ([#2674](#2674)) * Removed pipeline 'deployment' field from jsonschema ([#2653](#2653)) * Updated JSON schema for deprecated pipeline fields ([#2646](#2646)) * The --config-dir and --source-dir flags for "bundle generate app" are now relative to CWD, not bundle root ([#2683](#2683)) * Reverts [#2549](#2549) to resolve issues with Web Terminal host mismatch ([#2685](#2685))
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Update JSON schema for pipelines with deprecated fields. While fields have been deprecated for a long time, we have to use overrides until we propagate deprecated annotation from the OpenAPI spec. We need to manually set a deprecation message because the OpenAPI spec doesn't have such a field. A deprecation message is a part of the description that doesn't create an actionable tooltip. `target` is not marked as deprecated. While `schema` is preferred over `target`, currently, it isn't possible to update existing pipelines from using `target` to using `schema` without re-creating them. ## Why These fields should be avoided
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.247.0 ### CLI * Added include/exclude flags support to sync command ([#2650](#2650)) ### Bundles * Added support for model serving endpoints in deployment bind/unbind commands ([#2634](#2634)) * Added include/exclude flags support to bundle sync command ([#2650](#2650)) * Added JSON schema for resource permissions ([#2674](#2674)) * Removed pipeline 'deployment' field from jsonschema ([#2653](#2653)) * Updated JSON schema for deprecated pipeline fields ([#2646](#2646)) * The --config-dir and --source-dir flags for "bundle generate app" are now relative to CWD, not bundle root ([#2683](#2683)) * Reverts [#2549](#2549) to resolve issues with Web Terminal host mismatch ([#2685](#2685))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Update JSON schema for pipelines with deprecated fields.
While fields have been deprecated for a long time, we have to use overrides until we propagate deprecated annotation from the OpenAPI spec.
We need to manually set a deprecation message because the OpenAPI spec doesn't have such a field. A deprecation message is a part of the description that doesn't create an actionable tooltip.
targetis not marked as deprecated. Whileschemais preferred overtarget, currently, it isn't possible to update existing pipelines from usingtargetto usingschemawithout re-creating them.Why
These fields should be avoided