Uh oh!
There was an error while loading. Please reload this page.
Remove pipeline 'deployment' from jsonschema - #2653
Merged
Merged
Conversation
kanterov
marked this pull request as ready for review
April 4, 2025 11:53
kanterov
requested review from
andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersApril 4, 2025 11:53
shreyas-goenka
approved these changes
Apr 7, 2025
kanterov
enabled auto-merge
April 7, 2025 09:38
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Apr 9, 2025
## Release v0.247.0 ### CLI * Added include/exclude flags support to sync command ([#2650](#2650)) ### Bundles * Added support for model serving endpoints in deployment bind/unbind commands ([#2634](#2634)) * Added include/exclude flags support to bundle sync command ([#2650](#2650)) * Added JSON schema for resource permissions ([#2674](#2674)) * Removed pipeline 'deployment' field from jsonschema ([#2653](#2653)) * Updated JSON schema for deprecated pipeline fields ([#2646](#2646)) * The --config-dir and --source-dir flags for "bundle generate app" are now relative to CWD, not bundle root ([#2683](#2683)) * Reverts [#2549](#2549) to resolve issues with Web Terminal host mismatch ([#2685](#2685))
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Remove pipeline `deployment` field from jsonschema ## Why The `deployment` field is only meant to be set by DABs, and any user-specified value is overridden. It's used to annotate which pipelines are created by DABs. We have already removed `deployment` for jobs and it was left for pipelines by mistake. ## Tests Manually by inspecting jsonschema
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.247.0 ### CLI * Added include/exclude flags support to sync command ([#2650](#2650)) ### Bundles * Added support for model serving endpoints in deployment bind/unbind commands ([#2634](#2634)) * Added include/exclude flags support to bundle sync command ([#2650](#2650)) * Added JSON schema for resource permissions ([#2674](#2674)) * Removed pipeline 'deployment' field from jsonschema ([#2653](#2653)) * Updated JSON schema for deprecated pipeline fields ([#2646](#2646)) * The --config-dir and --source-dir flags for "bundle generate app" are now relative to CWD, not bundle root ([#2683](#2683)) * Reverts [#2549](#2549) to resolve issues with Web Terminal host mismatch ([#2685](#2685))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove pipeline
deploymentfield from jsonschemaWhy
The
deploymentfield is only meant to be set by DABs, and any user-specified value is overridden. It's used to annotate which pipelines are created by DABs. We have already removeddeploymentfor jobs and it was left for pipelines by mistake.Tests
Manually by inspecting jsonschema