Skip to content

Artifact: add omitempty on "patched" and "remote_path" - #2989

Merged
denik merged 1 commit into
mainfrom
denik/artifacts-annotations
Jun 5, 2025
Merged

Artifact: add omitempty on "patched" and "remote_path"#2989
denik merged 1 commit into
mainfrom
denik/artifacts-annotations

Conversation

@denik

@denikdenik commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Why

No need for those empty strings to show up in the output.

"source": "[TEST_TMP_DIR]/project_name_[UNIQUE_NAME]/dist/*.whl"
}
@@ -50,4 +52,5 @@
@@ -50,4 +50,5 @@

@denikdenikJun 5, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that out.validate.dev.json already did not include those patched and remote_path fields. Looking closer I see that "bundle summary" renders b.Config while "bundle validate" renders b.Config.Value.AsAny().

Fixed in #2990

@denik
denik enabled auto-merge June 5, 2025 07:33
@denik
denik disabled auto-merge June 5, 2025 07:36
@denik
denik enabled auto-merge June 5, 2025 07:38
@denik
denik added this pull request to the merge queueJun 5, 2025
Merged via the queue into main with commit 33786ecJun 5, 2025
@denik
denik deleted the denik/artifacts-annotations branch June 5, 2025 07:54
denik added a commit that referenced this pull request May 20, 2026
## Why
No need for those empty strings to show up in the output.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@denik@pietern