Uh oh!
There was an error while loading. Please reload this page.
Fix "bundle summary -o json" to render null values properly - #2990
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJune 5, 2025 07:42
This was referenced Jun 5, 2025
pietern
approved these changes
Jun 5, 2025
denikforce-pushed
the
denik/bundle-summary-json
branch
from
June 5, 2025 07:56
64c4596 to
72b80e6Comparedeco-sdk-taggingBot
added a commit
that referenced
this pull request
Jun 11, 2025
## Release v0.255.0 ### Notable Changes * Fix `databricks auth login` to tolerate URLs copied from the browser ([#3001](#3001)). ### CLI * Use OS aware runner instead of bash for run-local command ([#2996](#2996)) ### Bundles * Fix "bundle summary -o json" to render null values properly ([#2990](#2990)) * Fix dashboard generation for already imported dashboard ([#3016](#3016)) * Fixed null pointer de-reference if artifacts missing fields ([#3022](#3022)) * Update bundle templates to also include `resources/*/*.yml` ([#3024](#3024)) * Apply YAML formatter on default-python and dbt-sql templates ([#3026](#3026))
github-merge-queueBot
pushed a commit
that referenced
this pull request
Jun 26, 2025
## Changes - Merge rendering logic of "bundle validate" and "bundle summary" into one function. - Now "bundle summary" logs all warning diagnostics to stderr like "bundle validate" does. ## Why Not rendering warnings is a bug IMO. These are not just validation issues but could be real issues that are only related to summary and don't show up in "bundle validate". This is not the first time "bundle summary" differs from "bundle validate" (#2990) so in this PR I go beyond fixing and merge two code paths.
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes Render "bundle summary -o json" based on dynamic representation rather than static (same as "bundle validate -o json"). This was the behavior of summary command since it was added in https://github.com/databricks/cli/pull/1123/files#r2128154132 Found via this acceptance test that shows diff between validate and summary output: https://github.com/databricks/cli/pull/2989/files#r2128150583 ## Why Static representation is slightly broken because it does not set ForceSendFields properly and thus it cannot distinguish null vs zero values. ## Tests Existing tests.
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.255.0 ### Notable Changes * Fix `databricks auth login` to tolerate URLs copied from the browser ([#3001](#3001)). ### CLI * Use OS aware runner instead of bash for run-local command ([#2996](#2996)) ### Bundles * Fix "bundle summary -o json" to render null values properly ([#2990](#2990)) * Fix dashboard generation for already imported dashboard ([#3016](#3016)) * Fixed null pointer de-reference if artifacts missing fields ([#3022](#3022)) * Update bundle templates to also include `resources/*/*.yml` ([#3024](#3024)) * Apply YAML formatter on default-python and dbt-sql templates ([#3026](#3026))
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Merge rendering logic of "bundle validate" and "bundle summary" into one function. - Now "bundle summary" logs all warning diagnostics to stderr like "bundle validate" does. ## Why Not rendering warnings is a bug IMO. These are not just validation issues but could be real issues that are only related to summary and don't show up in "bundle validate". This is not the first time "bundle summary" differs from "bundle validate" (#2990) so in this PR I go beyond fixing and merge two code paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Render "bundle summary -o json" based on dynamic representation rather than static (same as "bundle validate -o json").
This was the behavior of summary command since it was added in https://github.com/databricks/cli/pull/1123/files#r2128154132
Found via this acceptance test that shows diff between validate and summary output: https://github.com/databricks/cli/pull/2989/files#r2128150583
Why
Static representation is slightly broken because it does not set ForceSendFields properly and thus it cannot distinguish null vs zero values.
Tests
Existing tests.