Skip to content

Adding new pipelines deploy command - #3107

Merged
andrewnester merged 25 commits into
mainfrom
pipelines-deploy
Jul 8, 2025
Merged

Adding new pipelines deploy command#3107
andrewnester merged 25 commits into
mainfrom
pipelines-deploy

Conversation

@alyssa-db

@alyssa-dbalyssa-db commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Changes

Adds pipelines deploy command with:

  • --auto-approve flag for non-interactive deployments
  • --force-lock flag to override deployment locks
  • --var flag for runtime variable substitution
  • --verbose flag for detailed output (VSCode integration)

Why

Enables direct pipeline deployment from CLI with safety controls and CI/CD support, eliminating need to switch tools for deployment workflows.

Tests

Added acceptance tests covering:

  • Auto-approve behavior for destructive operations
  • Force lock functionality and concurrent deployment handling
  • Variable substitution with special characters, unicode, and precedence rules
  • Error cases for undefined variables and invalid formats
  • Basic deployment and recreation scenarios

All tests run against Terraform backend with proper cleanup.

Comment threadacceptance/pipelines/install-pipelines-cli/output.txt Outdated
Comment threadcmd/pipelines/deploy.go Outdated

@kanterovkanterov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Andrew on not reusing the implementation as-is. I think as a principle we want to duplicate CLI commands, and customize which options they accept instead of reusing. We can extract sensible pieces of code to be shared, for example, mutator pipeline for deployment.

Comment threadcmd/bundle/deploy.go Outdated
Comment threadcmd/bundle/variables.go Outdated

@jefferycheng1jefferycheng1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadacceptance/pipelines/deploy/create-pipeline/script
@jefferycheng1

Copy link
Copy Markdown
Collaborator

@kanterov seems like alyssa resolved the comments, forgot to re-request, mind taking another look?

## Changes
Added acceptance test for rendering diagnostics warnings when unknown
properties are encountered during pipeline deployment.
## Why
Follow-up to [PR #3107](#3107) -
ensures the diagnostics system correctly identifies and reports unknown
properties in pipeline configurations, providing users with helpful
feedback about potential configuration issues.
## Tests
Added acceptance test case `render-diagnostics-warning` that verifies
warning messages are properly displayed for unknown bundle configuration
properties.
@andrewnester
andrewnester merged commit 4ce207e into mainJul 8, 2025
21 of 23 checks passed
@andrewnester
andrewnester deleted the pipelines-deploy branch July 8, 2025 09:13
denik pushed a commit that referenced this pull request May 20, 2026
## Changes
Adds `pipelines deploy` command with:
- `--auto-approve` flag for non-interactive deployments
- `--force-lock` flag to override deployment locks - `--var` flag for runtime variable substitution
- `--verbose` flag for detailed output (VSCode integration)
## Why
Enables direct pipeline deployment from CLI with safety controls and
CI/CD support, eliminating need to switch tools for deployment
workflows.
## Tests
Added acceptance tests covering:
- Auto-approve behavior for destructive operations
- Force lock functionality and concurrent deployment handling
- Variable substitution with special characters, unicode, and precedence
rules
- Error cases for undefined variables and invalid formats
- Basic deployment and recreation scenarios
All tests run against Terraform backend with proper cleanup.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@alyssa-db@eng-dev-ecosystem-bot@kanterov@jefferycheng1@andrewnester@lennartkats-db