Uh oh!
There was an error while loading. Please reload this page.
Adding new pipelines deploy command - #3107
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
kanterov
left a comment
There was a problem hiding this comment.
Agree with Andrew on not reusing the implementation as-is. I think as a principle we want to duplicate CLI commands, and customize which options they accept instead of reusing. We can extract sensible pieces of code to be shared, for example, mutator pipeline for deployment.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jefferycheng1
commented
Jul 4, 2025
@kanterov seems like alyssa resolved the comments, forgot to re-request, mind taking another look? |
## Changes Added acceptance test for rendering diagnostics warnings when unknown properties are encountered during pipeline deployment. ## Why Follow-up to [PR #3107](#3107) - ensures the diagnostics system correctly identifies and reports unknown properties in pipeline configurations, providing users with helpful feedback about potential configuration issues. ## Tests Added acceptance test case `render-diagnostics-warning` that verifies warning messages are properly displayed for unknown bundle configuration properties.
Uh oh!
There was an error while loading. Please reload this page.
## Changes Adds `pipelines deploy` command with: - `--auto-approve` flag for non-interactive deployments - `--force-lock` flag to override deployment locks - `--var` flag for runtime variable substitution - `--verbose` flag for detailed output (VSCode integration) ## Why Enables direct pipeline deployment from CLI with safety controls and CI/CD support, eliminating need to switch tools for deployment workflows. ## Tests Added acceptance tests covering: - Auto-approve behavior for destructive operations - Force lock functionality and concurrent deployment handling - Variable substitution with special characters, unicode, and precedence rules - Error cases for undefined variables and invalid formats - Basic deployment and recreation scenarios All tests run against Terraform backend with proper cleanup.
Changes
Adds
pipelines deploycommand with:--auto-approveflag for non-interactive deployments--force-lockflag to override deployment locks--varflag for runtime variable substitution--verboseflag for detailed output (VSCode integration)Why
Enables direct pipeline deployment from CLI with safety controls and CI/CD support, eliminating need to switch tools for deployment workflows.
Tests
Added acceptance tests covering:
All tests run against Terraform backend with proper cleanup.