Uh oh!
There was an error while loading. Please reload this page.
Add diagnostics warning test for pipelines deploy - #3179
Merged
Conversation
alyssa-db
requested review from
jefferycheng1, kanterov and lennartkats-db
as code ownersJuly 4, 2025 03:30
Collaborator
|
kanterov
approved these changes
Jul 4, 2025
kanterov
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, let's fix failing lint as well
jefferycheng1
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added acceptance test for rendering diagnostics warnings when unknown properties are encountered during pipeline deployment.
Why
Follow-up to PR #3107 - ensures the diagnostics system correctly identifies and reports unknown properties in pipeline configurations, providing users with helpful feedback about potential configuration issues.
Tests
Added acceptance test case
render-diagnostics-warningthat verifies warning messages are properly displayed for unknown bundle configuration properties.