Fix crash in "bundle summary" by denik · Pull Request #3141 · databricks/cli

denik · 2025-06-30T09:19:41Z

Changes

Fix crash in "bundle summary" when there was an error. Crash introduced in #3123 (not released yet).

Tests

New acceptance test added in #3138

eng-dev-ecosystem-bot · 2025-06-30T09:28:08Z

	Env	✅‌pass	❌‌FAIL	🙈‌skip
❌‌	aws linux	275	19	366
❌‌	aws windows	276	19	365
❌‌	aws-ucws linux	380	18	266
❌‌	aws-ucws windows	381	18	265
❌‌	azure linux	284	12	365
❌‌	azure windows	285	12	364
❌‌	azure-ucws linux	380	20	263
❌‌	azure-ucws windows	381	20	262
❌‌	gcp linux	244	55	363
❌‌	gcp windows	262	34	366

Test Name	aws linux	aws windows	aws-ucws linux	aws-ucws windows	azure linux	azure windows	azure-ucws linux	azure-ucws windows	gcp linux	gcp windows
TestAccept	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/dashboard/detect-change	❌‌FAIL	❌‌FAIL	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/dashboard/nested-folders	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/dashboard/simple	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/dashboard/simple_outside_bundle_root	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/dashboard/simple_syncroot	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/files/no-snapshot-sync	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/deploy/files/no-snapshot-sync/DATABRICKS_CLI_DEPLOYMENT=direct-exp	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/deploy/files/no-snapshot-sync/DATABRICKS_CLI_DEPLOYMENT=terraform	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/deploy/jobs/check-metadata	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/jobs/double-underscore-keys	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/jobs/fail-on-active-runs	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/jobs/fail-on-active-runs/DATABRICKS_CLI_DEPLOYMENT=direct-exp	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/jobs/fail-on-active-runs/DATABRICKS_CLI_DEPLOYMENT=terraform	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/mlops-stacks	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/pipeline/auto-approve	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deploy/secret-scope	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deployment/bind/cluster	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deployment/bind/dashboard	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deployment/bind/dashboard/recreation	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deployment/bind/experiment	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deployment/bind/job/job-abort-bind	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deployment/bind/job/job-spark-python-task	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/deployment/bind/model-serving-endpoint	✅‌pass	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/destroy/jobs-and-pipeline	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/resources/clusters/deploy/simple	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestAccept/bundle/resources/pipelines	❌‌FAIL	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/resources/pipelines/DATABRICKS_CLI_DEPLOYMENT=direct-exp	❌‌FAIL	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass
TestAccept/bundle/resources/pipelines/DATABRICKS_CLI_DEPLOYMENT=terraform	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/templates/default-python/combinations	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=no/P=no/S=no	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=no/P=no/S=yes	🙈‌skip	🙈‌skip	✅‌pass	✅‌pass	🙈‌skip	🙈‌skip	✅‌pass	✅‌pass	❌‌FAIL	🙈‌skip
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=no/P=yes/S=no	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=no/P=yes/S=yes	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	❌‌FAIL	🙈‌skip
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=yes/P=no/S=no	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=yes/P=no/S=yes	🙈‌skip	🙈‌skip	✅‌pass	✅‌pass	🙈‌skip	🙈‌skip	✅‌pass	✅‌pass	❌‌FAIL	🙈‌skip
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=yes/P=yes/S=no	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=yes/P=yes/S=yes	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=terraform/N=no/P=yes/S=no	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=terraform/N=no/P=yes/S=yes	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=terraform/N=yes/P=yes/S=no	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/templates/default-python/combinations/D=no/DATABRICKS_CLI_DEPLOYMENT=terraform/N=yes/P=yes/S=yes	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip
TestAccept/bundle/templates/default-python/combinations/D=yes/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=no/P=yes/S=no	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/templates/default-python/combinations/D=yes/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=no/P=yes/S=yes	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip
TestAccept/bundle/templates/default-python/combinations/D=yes/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=yes/P=yes/S=no	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/templates/default-python/combinations/D=yes/DATABRICKS_CLI_DEPLOYMENT=direct-exp/N=yes/P=yes/S=yes	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip
TestAccept/bundle/templates/default-python/combinations/D=yes/DATABRICKS_CLI_DEPLOYMENT=terraform/N=no/P=yes/S=no	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/templates/default-python/combinations/D=yes/DATABRICKS_CLI_DEPLOYMENT=terraform/N=no/P=yes/S=yes	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip
TestAccept/bundle/templates/default-python/combinations/D=yes/DATABRICKS_CLI_DEPLOYMENT=terraform/N=yes/P=yes/S=no	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL	❌‌FAIL
TestAccept/bundle/templates/default-python/combinations/D=yes/DATABRICKS_CLI_DEPLOYMENT=terraform/N=yes/P=yes/S=yes	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	🙈‌skip	🙈‌skip	❌‌FAIL	❌‌FAIL	❌‌FAIL	🙈‌skip
TestAccept/bundle/templates/default-python/integration_classic	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.10	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.11	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.12	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.13	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.9	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestFetchRepositoryInfoAPI_FromRepo	❌‌FAIL	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass
TestGenerateAndBind	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestGenerateFromExistingJobAndDeploy	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	❌‌FAIL
TestGenerateFromExistingPipelineAndDeploy	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestLock	✅‌pass	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass
TestReposCreateWithProvider	❌‌FAIL	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass
TestReposCreateWithoutProvider	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass
TestReposDeleteByPath	❌‌FAIL	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass
TestReposUpdate	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass
TestSparkJarTaskDeployAndRunOnWorkspace	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestSparkJarTaskDeployAndRunOnWorkspace/Databricks_Runtime_14.3_LTS	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestSparkJarTaskDeployAndRunOnWorkspace/Databricks_Runtime_15.4_LTS	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	❌‌FAIL	✅‌pass
TestSyncEnsureRemotePathIsUsableIfRepoExists	✅‌pass	❌‌FAIL	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass	✅‌pass

andrewnester · 2025-06-30T09:50:41Z

 )

 func renderJsonOutput(cmd *cobra.Command, b *bundle.Bundle) error {
+	if b == nil {


Why would it be nil in the first place? From what I thought it's only nil when error is return from bundle configure function, maybe we're missing handling the error somewhere?

I agree, this could be improved.
We have RenderDiagnostics() function which accepts bundle and diagnostics (and seems to handle b being nil, at least I see the checks there)
cli/bundle/render/render_text_output.go
Line 162 in abd441f
funcRenderDiagnostics(out io.Writer, b*bundle.Bundle, diags diag.Diagnostics, optsRenderOptions) error {
Probably the best time to refactor this is once we get rid of []Diagnostic and just log them as they come. Then this whole thing will become simpler.

## Changes Fix crash in "bundle summary" when there was an error. Crash introduced in #3123 (not released yet). ## Tests New acceptance test added in #3138

denik requested review from andrewnester, anton-107, pietern and shreyas-goenka as code owners June 30, 2025 09:19

denik temporarily deployed to test-trigger-is June 30, 2025 09:19 — with GitHub Actions Inactive

denik temporarily deployed to test-trigger-is June 30, 2025 09:34 — with GitHub Actions Inactive

andrewnester reviewed Jun 30, 2025
View reviewed changes

Base automatically changed from denik/summary_test_crash to mainJune 30, 2025 09:58

Fix crash in "bundle summary"
4811788

denik force-pushed the denik/fix-summary-crash branch from 677d93a to 4811788Compare June 30, 2025 10:01

denik temporarily deployed to test-trigger-is June 30, 2025 10:01 — with GitHub Actions Inactive

denik requested a review from andrewnester June 30, 2025 10:14

shreyas-goenka approved these changes Jun 30, 2025
View reviewed changes

denik merged commit 6d67410 into mainJun 30, 2025

denik deleted the denik/fix-summary-crash branch June 30, 2025 11:12

denik added a commit that referenced this pull request May 20, 2026
Fix crash in "bundle summary" (#3141)
8d1da9e
## Changes Fix crash in "bundle summary" when there was an error. Crash introduced in #3123 (not released yet). ## Tests New acceptance test added in #3138

Navigation Menu

Uh oh!

Fix crash in "bundle summary" - #3141

Fix crash in "bundle summary"#3141
denik merged 1 commit into
mainfrom
denik/fix-summary-crash

denik commented Jun 30, 2025•
edited
Loading

Uh oh!

eng-dev-ecosystem-bot commented Jun 30, 2025•
edited
Loading

Uh oh!

andrewnesterJun 30, 2025

Uh oh!

denikJun 30, 2025•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

denik commented Jun 30, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Tests

Uh oh!

eng-dev-ecosystem-bot commented Jun 30, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewnesterJun 30, 2025

Choose a reason for hiding this comment

Uh oh!

denikJun 30, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

denik commented Jun 30, 2025•
edited
Loading

eng-dev-ecosystem-bot commented Jun 30, 2025•
edited
Loading

denikJun 30, 2025•
edited
Loading