Skip to content

Fix crash in "bundle summary"#3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 1 commit into from
Jun 30, 2025
Merged

Fix crash in "bundle summary" #3141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions acceptance/bundle/summary/missing-libraries-file-path/output.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,21 +2,6 @@
=== Initial view of resources without id and modified_status=created
>>> [CLI] bundle summary -o json
Error: file intentionally-missing.py not found
Please report this issue to Databricks in the form of a GitHub issue at:
https://github.com/databricks/cli

Panic Payload: runtime error: invalid memory address or nil pointer dereference
goroutine 1 [running]:
runtime/debug.Stack()
github.com/databricks/cli/cmd/root.Execute.func1()
panic({HEX?, HEX?})
github.com/databricks/cli/cmd/bundle.renderJsonOutput(HEX, HEX?)
github.com/databricks/cli/cmd/bundle.renderBundle(HEX, HEX, {HEX, HEX, HEX}, HEX)
github.com/databricks/cli/cmd/bundle.newSummaryCommand.func1(HEX, {HEX?, HEX?, HEX?})
github.com/spf13/cobra.(*Command).execute(HEX, {HEX, HEX, HEX})
github.com/spf13/cobra.(*Command).ExecuteC(HEX)
github.com/spf13/cobra.(*Command).ExecuteContextC(...)
github.com/databricks/cli/cmd/root.Execute({HEX, HEX}, HEX)
main.main()

Exit code: 1
9 changes: 0 additions & 9 deletions acceptance/bundle/summary/missing-libraries-file-path/test.toml
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions cmd/bundle/validate.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,9 @@ import (
)

func renderJsonOutput(cmd *cobra.Command, b *bundle.Bundle) error {
if b == nil {

@andrewnesterandrewnesterJun 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it be nil in the first place? From what I thought it's only nil when error is return from bundle configure function, maybe we're missing handling the error somewhere?

@denikdenikJun 30, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this could be improved.

We have RenderDiagnostics() function which accepts bundle and diagnostics (and seems to handle b being nil, at least I see the checks there)

cli/bundle/render/render_text_output.go

Line 162 in abd441f

funcRenderDiagnostics(out io.Writer, b*bundle.Bundle, diags diag.Diagnostics, optsRenderOptions) error {

Probably the best time to refactor this is once we get rid of []Diagnostic and just log them as they come. Then this whole thing will become simpler.

return nil
}
buf, err := json.MarshalIndent(b.Config.Value().AsAny(), "", " ")
if err != nil {
return err
Expand Down