Uh oh!
There was an error while loading. Please reload this page.
Move terraform.Load() to statemgmt.Load() - #3161
Merged
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJuly 1, 2025 15:41
denikforce-pushed
the
denik/improve-terraform-load
branch
from
July 1, 2025 15:43
878520f to
fd3c594Comparedenikforce-pushed
the
denik/move-terraform-load
branch
from
July 1, 2025 15:44
68cd7d2 to
99d2e3fComparedenikforce-pushed
the
denik/move-terraform-load
branch
from
July 1, 2025 15:58
99d2e3f to
4eefba3CompareCollaborator
93 failing tests:
|
denikforce-pushed
the
denik/improve-terraform-load
branch
from
July 2, 2025 07:08
fd3c594 to
cbe7fc9Comparedenikforce-pushed
the
denik/move-terraform-load
branch
from
July 2, 2025 07:09
4eefba3 to
ba86b34Comparepietern
reviewed
Jul 2, 2025
| return "statemgmt.Load" | ||
| } | ||
| func (l *load) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics { |
Contributor
There was a problem hiding this comment.
This is still TF-specific. I expected the StateToBundle function to move here, but I still keep separate mutators for the different deployment modes. Doesn't that make more sense?
ContributorAuthor
There was a problem hiding this comment.
This PR is purely a move. The mutator will be refactored to handle both terraform and terranova case.
It's easier to have single mutator that handles both, less changes are needed in cmd/bundle/*.go
Contributor
There was a problem hiding this comment.
Do you still want to keep the different implementations in different packages?
ContributorAuthor
There was a problem hiding this comment.
The actual logic that converts tfstate or resources.json to neutral representation will leave in corresponding package. The mutator acts as aggregator, so it can take dependency on both terraform and terranova to call the right functions.
denikforce-pushed
the
denik/move-terraform-load
branch
from
July 2, 2025 09:24
ba86b34 to
f3183b4Comparedenikforce-pushed
the
denik/move-terraform-load
branch
from
July 2, 2025 09:26
f3183b4 to
0f4fae1Comparedenikforce-pushed
the
denik/move-terraform-load
branch
from
July 2, 2025 09:31
0f4fae1 to
75d651fComparedenikforce-pushed
the
denik/move-terraform-load
branch
from
July 2, 2025 11:00
75d651f to
a06ba9fComparePure move, no functional changes.
denikforce-pushed
the
denik/move-terraform-load
branch
from
July 2, 2025 11:34
a06ba9f to
97f28f0Comparepietern
approved these changes
Jul 3, 2025
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes Move terraform.Load to statemgmt.Load Move terraform.TerraformToBundle to statemgmt.StateToBundle. Move related unit tests. Pure move, no functional changes. Stacked on top of #3134 ## Why Preparation for making it work with direct deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Move terraform.Load to statemgmt.Load
Move terraform.TerraformToBundle to statemgmt.StateToBundle.
Move related unit tests.
Pure move, no functional changes.
Stacked on top of #3134
Why
Preparation for making it work with direct deployment.