Uh oh!
There was an error while loading. Please reload this page.
[direct] Implement bundle summary/run/open and resource deletion - #3162
Merged
Conversation
Collaborator
16 failing tests:
|
denikforce-pushed
the
denik/move-terraform-load
branch
6 times, most recently
from
July 2, 2025 11:34
a06ba9f to
97f28f0Comparedenik
marked this pull request as ready for review
July 2, 2025 14:10
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJuly 2, 2025 14:10
clean up
clean up updated
wip
break dependency of statemgmt on deploy/terraform
fixes
add state_export.go
update secret scopes test
move ResourceState to its own package
create resources.X if it does not exist
expand modified_status to test absence of resources: as well
create resources & resources.section if missing
restore empty resources{}
Move terraform.Load() to statemgmt.Load()
Pure move, no functional changes.
load state into bundle - run/basic passes
enable run/no-state
Enable integration_whl on direct-exp
WIPpietern
reviewed
Jul 3, 2025
| diags.AppendErrorf("internal error: cannot get config for group=%v name=%v", node.Group, node.Name) | ||
| return | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Why is this necessary now and not before? (useful to capture in a comment here as well)
I suspect it's because the state loader now populates configs (and IDs) regardless of presence in the config.
ContributorAuthor
There was a problem hiding this comment.
Deletes were not working before in all scenarios but we did not have enough tests enabled to catch that.
This part assumes that config is always present which is of course not the case when config was deleted:
config, ok := b.GetResourceConfig(node.Group, node.Name)
if !ok {
diags.AppendErrorf("internal error: cannot get config for %s", node)
| panic("direct deployment required") | ||
| } | ||
| err := b.OpenResourceDatabase(ctx) |
Uh oh!
There was an error while loading. Please reload this page.
pietern
approved these changes
Jul 3, 2025
| var config any | ||
| if node.ActionType == deployplan.ActionTypeDelete { | ||
| config = nil |
Contributor
There was a problem hiding this comment.
With config already beingnil (zero-initialized), a switch/case could improve readability here.
ContributorAuthor
There was a problem hiding this comment.
thanks, not sure about switch but cleaned up a bit 3460742
| return fmt.Errorf("Already read state %v, cannot open %v", db.Path, path) | ||
| } | ||
| db.Path = path |
Contributor
There was a problem hiding this comment.
Nit: to make this more robust, set path only after successfully reading and deserializing the state.
denik added a commit
that referenced
this pull request
Jul 7, 2025
It was enabled prematurely in #3162
denik added a commit
that referenced
this pull request
Jul 9, 2025
It requires "bundle summary" which we have since #3162
github-merge-queueBot
pushed a commit
that referenced
this pull request
Jul 9, 2025
It requires "bundle summary" which we have since #3162
denik added a commit
that referenced
this pull request
May 20, 2026
It was enabled prematurely in #3162
denik added a commit
that referenced
this pull request
May 20, 2026
It requires "bundle summary" which we have since #3162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Depends on
Tests
Enabled a bunch of tests & added more precise comments on remaining disabled.