Uh oh!
There was an error while loading. Please reload this page.
internal: structpath: accurate struct <-> string mapping - #3631
Closed
denik wants to merge 5 commits into
Closed
Conversation
Previously structpath could represent AnyKey and AnyIndex as struct but as string they were both represented as field[*]. On the other hand, there was no unambigous representation of x.*. This commit fixes struct mapping to match string representation 1-1 so that Parse(x.String()) == x.
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersSeptember 19, 2025 08:42
deniktemporarily deployed
to
test-trigger-is
September 19, 2025 08:42 — with 
GitHub Actions
Inactive
denik
marked this pull request as draft
September 19, 2025 08:50
Collaborator
|
deniktemporarily deployed
to
test-trigger-is
September 19, 2025 09:41 — with GitHub Actions
Inactive
denik
marked this pull request as ready for review
September 19, 2025 09:41
deniktemporarily deployed
to
test-trigger-is
September 19, 2025 09:46 — with GitHub Actions
Inactive
deniktemporarily deployed
to
test-trigger-is
September 19, 2025 10:02 — with GitHub Actions
Inactive
denik
marked this pull request as draft
September 22, 2025 11:41
denik
commented
Sep 22, 2025
ContributorAuthor
Looking into making ConvertPathNodeToDynPath unnecessary |
denik
commented
Sep 22, 2025
ContributorAuthor
Superseded by #3640 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Previously structpath could represent AnyKey and AnyIndex as struct but as string they were both represented as field[*].
On the other hand, there was no unambigous representation of x.*.
This commit fixes struct mapping to match string representation 1-1 so that Parse(x.String()) == x.
Tests
New unit tests.
Enabled testing reconstructed PathNode equality in structwalk tests.