Skip to content

internal: modify structaccess to accept PathNode instead of dyn.Path - #3633

Closed
denik wants to merge 3 commits into
denik/accurate-structpathfrom
denik/structaccess-structpath2
Closed

internal: modify structaccess to accept PathNode instead of dyn.Path#3633
denik wants to merge 3 commits into
denik/accurate-structpathfrom
denik/structaccess-structpath2

Conversation

@denik

@denikdenik commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Changes

  • Modify structaccess.Get/Validate to accept PathNode rather than dyn.Path. It is also flexible with regard to dot or bracket syntax, both are accepted, so "resources.jobs.foo" would still work even though jobs is a map.
  • Add PathNode methods: Len(), Prefix(N), SkipPrefix(N)

Depends on #3631

Why

Needed for serialized bundle plan. PathNode is going to come from the plan and then passed directly to structaccess.

Tests

Unit tests.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Sep 19, 2025

Copy link
Copy Markdown
Collaborator

Run: 17860808232

Env✅​pass🔄​flaky🙈​skip
✅​aws linux311528
✅​aws windows312527
✅​aws-ucws linux423426
✅​aws-ucws windows424425
✅​azure linux311527
✅​azure windows312526
🔄​azure-ucws linux4167425
🔄​azure-ucws windows4204424
✅​gcp linux310529
✅​gcp windows311528
8 failing tests:
Test Nameazure-ucws linuxazure-ucws windows
TestAccept/bundle/deploy/dashboard/detect-change🔄​flaky✅​pass
TestAccept/bundle/deploy/dashboard/generate_inplace🔄​flaky✅​pass
TestAccept/bundle/deploy/dashboard/nested-folders🔄​flaky✅​pass
TestAccept/bundle/deploy/dashboard/simple🔄​flaky✅​pass
TestAccept/bundle/deploy/dashboard/simple_outside_bundle_root🔄​flaky🔄​flaky
TestAccept/bundle/deploy/dashboard/simple_syncroot🔄​flaky🔄​flaky
TestAccept/bundle/deployment/bind/dashboard✅​pass🔄​flaky
TestDashboardAssumptions_WorkspaceImport🔄​flaky🔄​flaky

@denik
denik marked this pull request as draft September 22, 2025 11:42
@denik

Copy link
Copy Markdown
ContributorAuthor

Superseded by #3640

@denikdenik closed this Sep 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@denik@eng-dev-ecosystem-bot