Uh oh!
There was an error while loading. Please reload this page.
[Not for merging] Add a test for unmarshalling with incorrect type - #3645
Closed
denik wants to merge 1 commit into
Closed
[Not for merging] Add a test for unmarshalling with incorrect type#3645denik wants to merge 1 commit into
denik wants to merge 1 commit into
Conversation
deniktemporarily deployed
to
test-trigger-is
September 23, 2025 11:28 — with 
GitHub Actions
Inactive
Collaborator
11 failing tests:
|
pietern
reviewed
Sep 26, 2025
| func TestUnmarshalResourceJob(t *testing.T) { | ||
| x := resources.Job{} | ||
| err := json.Unmarshal([]byte(inputJob), &x) | ||
| require.NoError(t, err) |
Contributor
There was a problem hiding this comment.
Do you know if/where this error gets swallowed?
ContributorAuthor
There was a problem hiding this comment.
No, I did not debug this further than this.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Sep 26, 2025
…N roundtrip (#3646) ## Why For direct, we fetch configs as struct instances via GetResourceConfig, which is using json roundtrip between dyn value and struct. That, however, does not work well when there references in the config, see #3645 for details. This switches to converting dyn.Value with dyn/convert ToTyped function. The function was not used previously because it did not handle ForceSendFields correctly for embedded structs which caused JSON marshaller in Go SDK to return error. This was fixed in #3650 and #3649 ## Tests Existing tests.
Contributor
This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled. |
denik added a commit
that referenced
this pull request
May 20, 2026
…N roundtrip (#3646) ## Why For direct, we fetch configs as struct instances via GetResourceConfig, which is using json roundtrip between dyn value and struct. That, however, does not work well when there references in the config, see #3645 for details. This switches to converting dyn.Value with dyn/convert ToTyped function. The function was not used previously because it did not handle ForceSendFields correctly for embedded structs which caused JSON marshaller in Go SDK to return error. This was fixed in #3650 and #3649 ## Tests Existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that shows that JSON unmarshaller in Go SDK is unpredictable when field have unexpected types (e.g. string like "$resources.jobs.foo.id" instead of a number). This makes JSON round trip approach introduced in https://github.com/databricks/cli/pull/2926/files#diff-b7bffa44a68a4b43193ab3157de6ff3844353f7b4903663a7552d1294dda1526R307 unsuitable for what it is used.