Uh oh!
There was an error while loading. Please reload this page.
dyn: fix zero values conversion / IsZero() method - #3649
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersSeptember 23, 2025 18:52
deniktemporarily deployed
to
test-trigger-is
September 23, 2025 18:52 — with 
GitHub Actions
Inactive
denikforce-pushed
the
denik/dyn-is-zero
branch
from
September 23, 2025 18:55
670d874 to
ce0d185Comparedeniktemporarily deployed
to
test-trigger-is
September 23, 2025 18:55 — with GitHub Actions
Inactive
deniktemporarily deployed
to
test-trigger-is
September 23, 2025 19:03 — with GitHub Actions
Inactive
Collaborator
|
denikforce-pushed
the
denik/dyn-is-zero
branch
from
September 23, 2025 19:28
d3106e5 to
10d4dbbComparedeniktemporarily deployed
to
test-trigger-is
September 23, 2025 19:28 — with GitHub Actions
Inactive
denikforce-pushed
the
denik/structpath-flexible
branch
from
September 23, 2025 19:29
57285ac to
e627b0eComparedenikforce-pushed
the
denik/dyn-is-zero
branch
from
September 23, 2025 19:30
10d4dbb to
b54ae8eComparedeniktemporarily deployed
to
test-trigger-is
September 23, 2025 19:30 — with GitHub Actions
Inactive
deniktemporarily deployed
to
test-trigger-is
September 24, 2025 08:45 — with GitHub Actions
Inactive
deniktemporarily deployed
to
test-trigger-is
September 24, 2025 08:48 — with GitHub Actions
Inactive
pietern
approved these changes
Sep 24, 2025
andrewnester
approved these changes
Sep 24, 2025
denikforce-pushed
the
denik/dyn-is-zero
branch
from
September 24, 2025 09:36
4897b39 to
95c3fe1Comparedeniktemporarily deployed
to
test-trigger-is
September 24, 2025 09:37 — with GitHub Actions
Inactive
denik
enabled auto-merge
September 24, 2025 09:37
Uh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Sep 26, 2025
…N roundtrip (#3646) ## Why For direct, we fetch configs as struct instances via GetResourceConfig, which is using json roundtrip between dyn value and struct. That, however, does not work well when there references in the config, see #3645 for details. This switches to converting dyn.Value with dyn/convert ToTyped function. The function was not used previously because it did not handle ForceSendFields correctly for embedded structs which caused JSON marshaller in Go SDK to return error. This was fixed in #3650 and #3649 ## Tests Existing tests.
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Fix IsZero() method for types like int64. This fixes ToConvert for NumWorkers field in ClusterSpec. - Do not panic in dyn.V() if other int types are encountered. - If panic does happen, include type name. ## Why ToConvert() depends on it and is broken. This unblocks #3650#3646 ## Tests New unit tests.
denik added a commit
that referenced
this pull request
May 20, 2026
…N roundtrip (#3646) ## Why For direct, we fetch configs as struct instances via GetResourceConfig, which is using json roundtrip between dyn value and struct. That, however, does not work well when there references in the config, see #3645 for details. This switches to converting dyn.Value with dyn/convert ToTyped function. The function was not used previously because it did not handle ForceSendFields correctly for embedded structs which caused JSON marshaller in Go SDK to return error. This was fixed in #3650 and #3649 ## Tests Existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
ToConvert() depends on it and is broken. This unblocks #3650#3646
Tests
New unit tests.