Uh oh!
There was an error while loading. Please reload this page.
Add interactive warehouse picker for templates that make use of SQL warehouses - #4170
Merged
Conversation
- Add `SelectWarehouse` function with state-sorted picker (running first) - Add `GetDefaultWarehouse` function for determining default warehouse - Add `Format` field to JSON schema for custom input types - Use `format: "warehouse_path"` in default-sql and dbt-sql templates - Update apps-mcp to use shared `GetDefaultWarehouse` logic - Fix case-insensitive search in cmdio Select 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add filter support to SelectWarehouse (variadic warehouseFilter) - Show warehouse type (pro/classic/serverless) in gray lowercase - Make [DEFAULT] marker gray - Sort by state priority then alphabetically for default selection - Display list sorted by running state first, then alphabetically 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lennartkats-db
requested review from
andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersDecember 23, 2025 15:58
lennartkats-dbtemporarily deployed
to
test-trigger-is
December 23, 2025 15:58 — with 
GitHub Actions
Inactive
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lennartkats-dbtemporarily deployed
to
test-trigger-is
December 23, 2025 16:01 — with GitHub Actions
Inactive
| } | ||
| return cmdio.Select(ctx, names, "Choose SQL Warehouse") | ||
| } | ||
ContributorAuthor
There was a problem hiding this comment.
N.B., the logic for detecting warehouses is what we discussed with the DBSQL org and follows what's already in the apps-mcp experimental code.
1 task
Collaborator
Commit: 9e3669f
19 interesting tests: 18 KNOWN, 1 SKIP
Top 24 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Dec 29, 2025
Uh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Dec 31, 2025
## Summary Refactors apps-mcp warehouse selection to use the shared `cfgpickers.GetDefaultWarehouse` function from #4170. - [x] This is a PR stacked on top of the above PR; it needs to be changed to target `main` before merging --------- Co-authored-by: Claude <noreply@anthropic.com>
eng-dev-ecosystem-bot
commented
Dec 31, 2025
Collaborator
Commit: e0f32d7
31 interesting tests: 18 KNOWN, 6 FAIL, 6 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jan 8, 2026
## Release v0.282.0 ### Notable Changes * engine/direct: New plan format (v2) ([#4201](#4201)) ### CLI * Skip non-exportable objects (e.g., `MLFLOW_EXPERIMENT`) during `workspace export-dir` instead of failing ([#4101](#4101)) ### Bundles * Allow `domain_friendly_name` to be used in `name_prefix` in development mode ([#4173](#4173)) * Add missing schema grants privileges ([#4139](#4139)) * Add support for `bundle generate alert` command ([#4108](#4108)) * Add support for `.dbalert.json` files ([#3602](#3602)) * Pass `SYSTEM_TEAMFOUNDATIONCOLLECTIONURI` from env to the Terraform provider for Azure DevOps OIDC auth ([#4169](#4169)) * Add `ipykernel` to the `default` template to enable Databricks Connect notebooks in Cursor/VS Code ([#4164](#4164)) * Add interactive SQL warehouse picker to `default-sql` and `dbt-sql` bundle templates ([#4170](#4170)) * Add `name`, `target` and `mode` fields to the deployment metadata file ([#4180](#4180)) * engine/direct: Fix app deployment failure when app is in `DELETING` state ([#4176](#4176)) * engine/direct: Changes in config that match remote changes no longer trigger an update ([#4201](#4201))
2 tasks
pietern added a commit
that referenced
this pull request
May 4, 2026
…5168) ## Summary `SelectWarehouse` in `libs/databrickscfg/cfgpickers/warehouses.go` contains: ```go promptui.SearchPrompt = "Search: " ``` This assigns the package-level global to its own default. promptui declares it [here](https://github.com/manifoldco/promptui/blob/v0.9.0/select.go#L184) as `var SearchPrompt = "Search: "` — byte-identical to what we set. The line is the only write to `promptui.SearchPrompt` in the repo. It was introduced in #4170 alongside the template-init warehouse picker. The original warehouse picker (`AskForWarehouse`, added in #956) never had it, which suggests it's copy-paste residue rather than a deliberate override. ## Test plan - [x] `go build ./libs/databrickscfg/cfgpickers/` - [x] No behavior change expected — value matches promptui's default This pull request and its description were written by Isaac.
denik pushed a commit
that referenced
this pull request
May 20, 2026
…arehouses (#4170) ## Summary This adds an interactive warehouse picker + default warehouse support for templates that make use of a warehouse option: <img width="617" height="268" alt="image" src="https://github.com/user-attachments/assets/b82a955d-f10a-4e1d-be93-8d90069146e1" /> Note that this PR doesn't change the interface of existing templates: we keep using `http_path` as the property name for warehouses to maintain compatibility in the workspace and any client tools that depend on that name. The property just has a new `"format": "warehouse_path"` setting that describes the new behavior. ## Test plan - [x] Unit tests pass - [x] Acceptance tests updated and pass - [x] `make lint` and `make fmt` pass - [x] Manual testing of `databricks bundle init` with SQL templates
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Summary Refactors apps-mcp warehouse selection to use the shared `cfgpickers.GetDefaultWarehouse` function from #4170. - [x] This is a PR stacked on top of the above PR; it needs to be changed to target `main` before merging --------- Co-authored-by: Claude <noreply@anthropic.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.282.0 ### Notable Changes * engine/direct: New plan format (v2) ([#4201](#4201)) ### CLI * Skip non-exportable objects (e.g., `MLFLOW_EXPERIMENT`) during `workspace export-dir` instead of failing ([#4101](#4101)) ### Bundles * Allow `domain_friendly_name` to be used in `name_prefix` in development mode ([#4173](#4173)) * Add missing schema grants privileges ([#4139](#4139)) * Add support for `bundle generate alert` command ([#4108](#4108)) * Add support for `.dbalert.json` files ([#3602](#3602)) * Pass `SYSTEM_TEAMFOUNDATIONCOLLECTIONURI` from env to the Terraform provider for Azure DevOps OIDC auth ([#4169](#4169)) * Add `ipykernel` to the `default` template to enable Databricks Connect notebooks in Cursor/VS Code ([#4164](#4164)) * Add interactive SQL warehouse picker to `default-sql` and `dbt-sql` bundle templates ([#4170](#4170)) * Add `name`, `target` and `mode` fields to the deployment metadata file ([#4180](#4180)) * engine/direct: Fix app deployment failure when app is in `DELETING` state ([#4176](#4176)) * engine/direct: Changes in config that match remote changes no longer trigger an update ([#4201](#4201))
denik pushed a commit
that referenced
this pull request
May 20, 2026
…5168) ## Summary `SelectWarehouse` in `libs/databrickscfg/cfgpickers/warehouses.go` contains: ```go promptui.SearchPrompt = "Search: " ``` This assigns the package-level global to its own default. promptui declares it [here](https://github.com/manifoldco/promptui/blob/v0.9.0/select.go#L184) as `var SearchPrompt = "Search: "` — byte-identical to what we set. The line is the only write to `promptui.SearchPrompt` in the repo. It was introduced in #4170 alongside the template-init warehouse picker. The original warehouse picker (`AskForWarehouse`, added in #956) never had it, which suggests it's copy-paste residue rather than a deliberate override. ## Test plan - [x] `go build ./libs/databrickscfg/cfgpickers/` - [x] No behavior change expected — value matches promptui's default This pull request and its description were written by Isaac.
TanishqDatabricks pushed a commit
to TanishqDatabricks/cli
that referenced
this pull request
May 22, 2026
…atabricks#5168) ## Summary `SelectWarehouse` in `libs/databrickscfg/cfgpickers/warehouses.go` contains: ```go promptui.SearchPrompt = "Search: " ``` This assigns the package-level global to its own default. promptui declares it [here](https://github.com/manifoldco/promptui/blob/v0.9.0/select.go#L184) as `var SearchPrompt = "Search: "` — byte-identical to what we set. The line is the only write to `promptui.SearchPrompt` in the repo. It was introduced in databricks#4170 alongside the template-init warehouse picker. The original warehouse picker (`AskForWarehouse`, added in databricks#956) never had it, which suggests it's copy-paste residue rather than a deliberate override. ## Test plan - [x] `go build ./libs/databrickscfg/cfgpickers/` - [x] No behavior change expected — value matches promptui's default This pull request and its description were written by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds an interactive warehouse picker + default warehouse support for templates that make use of a warehouse option:
Note that this PR doesn't change the interface of existing templates: we keep using
http_pathas the property name for warehouses to maintain compatibility in the workspace and any client tools that depend on that name. The property just has a new"format": "warehouse_path"setting that describes the new behavior.Test plan
make lintandmake fmtpassdatabricks bundle initwith SQL templates