Uh oh!
There was an error while loading. Please reload this page.
Wait for app deletion in DoCreate instead of DoDelete - #4176
Merged
andrewnester merged 5 commits intoJan 2, 2026
Merged
Conversation
varundeepsaini
requested review from
andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersDecember 29, 2025 13:44
denik
requested changes
Dec 29, 2025
Uh oh!
There was an error while loading. Please reload this page.
denik
reviewed
Dec 29, 2025
Uh oh!
There was an error while loading. Please reload this page.
denik
reviewed
Dec 29, 2025
Uh oh!
There was an error while loading. Please reload this page.
varundeepsainiforce-pushed
the
fix-app-deletion-wait-in-create
branch
from
December 29, 2025 15:33
5ce6557 to
2459f80CompareCollaborator
Commit: 3c7d77a
21 interesting tests: 18 KNOWN, 2 flaky, 1 SKIP
Top 28 slowest tests (at least 2 minutes):
|
denik
reviewed
Dec 30, 2025
denik
left a comment
Contributor
There was a problem hiding this comment.
Thanks @varundeepsaini, looks good. Only have a comment about testing.
Could you also add NEXT_CHANGELOG entry?
| // TestAppDoCreate_FailsWhenAppExistsAndNotDeleting verifies that DoCreate returns | ||
| // a hard error when an app already exists but is NOT in DELETING state. | ||
| func TestAppDoCreate_FailsWhenAppExistsAndNotDeleting(t *testing.T) { |
Contributor
There was a problem hiding this comment.
The two tests above have special logic in the handler, so it makes sense to write them as unit tests. This test can be using standard handlers though, could you rewrite it as acceptance test?
first create app with the same name using databricks cli
$CLI apps create --json '{...}'
then do bundle deploy and observe the error:
musterr $CLI bundle deploy
ContributorAuthor
There was a problem hiding this comment.
The testserver used to overwrite when an app already exists, i modified it so it returns a 409
denik
approved these changes
Dec 30, 2025
denik
commented
Dec 30, 2025
Contributor
Thanks @varundeepsaini ! |
Contributor
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
eng-dev-ecosystem-bot
commented
Jan 2, 2026
Collaborator
Commit: 3c597d1
48 interesting tests: 26 FAIL, 18 KNOWN, 2 flaky, 1 SKIP, 1 MISS
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jan 8, 2026
## Release v0.282.0 ### Notable Changes * engine/direct: New plan format (v2) ([#4201](#4201)) ### CLI * Skip non-exportable objects (e.g., `MLFLOW_EXPERIMENT`) during `workspace export-dir` instead of failing ([#4101](#4101)) ### Bundles * Allow `domain_friendly_name` to be used in `name_prefix` in development mode ([#4173](#4173)) * Add missing schema grants privileges ([#4139](#4139)) * Add support for `bundle generate alert` command ([#4108](#4108)) * Add support for `.dbalert.json` files ([#3602](#3602)) * Pass `SYSTEM_TEAMFOUNDATIONCOLLECTIONURI` from env to the Terraform provider for Azure DevOps OIDC auth ([#4169](#4169)) * Add `ipykernel` to the `default` template to enable Databricks Connect notebooks in Cursor/VS Code ([#4164](#4164)) * Add interactive SQL warehouse picker to `default-sql` and `dbt-sql` bundle templates ([#4170](#4170)) * Add `name`, `target` and `mode` fields to the deployment metadata file ([#4180](#4180)) * engine/direct: Fix app deployment failure when app is in `DELETING` state ([#4176](#4176)) * engine/direct: Changes in config that match remote changes no longer trigger an update ([#4201](#4201))
denik added a commit
that referenced
this pull request
May 20, 2026
## Description Moves app deletion wait from `DoDelete` to `DoCreate`, and only retries when appropriate. ## Changes - On `RESOURCE_ALREADY_EXISTS` error, check app state via GET before retrying - Only retry if the app is in `DELETING` state or was just deleted (404) - Return hard error if app exists in any other state (e.g., `ACTIVE`) ## Why? - Handles apps deleted externally (manual deletion), not just via `bundle destroy` - Avoids unnecessary latency in destroy operations - Fixes the issue at the point of failure (create, not delete) - Prevents infinite retries when app exists and is not being deleted Follow up to #4102, addresses feedback from #4006. --------- Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.282.0 ### Notable Changes * engine/direct: New plan format (v2) ([#4201](#4201)) ### CLI * Skip non-exportable objects (e.g., `MLFLOW_EXPERIMENT`) during `workspace export-dir` instead of failing ([#4101](#4101)) ### Bundles * Allow `domain_friendly_name` to be used in `name_prefix` in development mode ([#4173](#4173)) * Add missing schema grants privileges ([#4139](#4139)) * Add support for `bundle generate alert` command ([#4108](#4108)) * Add support for `.dbalert.json` files ([#3602](#3602)) * Pass `SYSTEM_TEAMFOUNDATIONCOLLECTIONURI` from env to the Terraform provider for Azure DevOps OIDC auth ([#4169](#4169)) * Add `ipykernel` to the `default` template to enable Databricks Connect notebooks in Cursor/VS Code ([#4164](#4164)) * Add interactive SQL warehouse picker to `default-sql` and `dbt-sql` bundle templates ([#4170](#4170)) * Add `name`, `target` and `mode` fields to the deployment metadata file ([#4180](#4180)) * engine/direct: Fix app deployment failure when app is in `DELETING` state ([#4176](#4176)) * engine/direct: Changes in config that match remote changes no longer trigger an update ([#4201](#4201))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves app deletion wait from
DoDeletetoDoCreate, and only retries when appropriate.Changes
RESOURCE_ALREADY_EXISTSerror, check app state via GET before retryingDELETINGstate or was just deleted (404)ACTIVE)Why?
bundle destroyFollow up to #4102, addresses feedback from #4006.