Skip to content

Add profile on databricks auth login - #423

Merged
nfx merged 5 commits into
mainfrom
profiles-on-login
Jun 2, 2023
Merged

Add profile on databricks auth login#423
nfx merged 5 commits into
mainfrom
profiles-on-login

Conversation

@nfx

@nfxnfx commented Jun 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • added saving profile to ~/.databrickscfg whenever we do databricks auth login.
  • we either match profile by account id / canonical host or introduce the new one from deployment name.
  • fail on multiple profiles with matching accounts or workspace hosts.
  • overriding ~/.databrickscfg keeps the (valid) comments, but reformats the file.

Tests

  • make test
  • go run main.go auth login --account-id XXX --host https://accounts.cloud.databricks.com/
  • go run main.go auth token --account-id XXX --host https://accounts.cloud.databricks.com/
  • go run main.go auth login --host https://XXX.cloud.databricks.com/

@nfx
nfx requested a review from pieternJune 1, 2023 20:16
pietern
pietern reviewed Jun 2, 2023
View reviewed changes
Comment threadlibs/databrickscfg/loader.go Outdated
Comment threadlibs/databrickscfg/loader.go
Comment threadlibs/databrickscfg/ops.go Outdated
Comment threadlibs/databrickscfg/ops.go
Comment threadlibs/databrickscfg/ops.go Outdated
@nfx
nfxforce-pushed the profiles-on-login branch from 92e5e70 to 3aa39ebCompareJune 2, 2023 10:39
@nfx
nfx requested a review from pieternJune 2, 2023 10:42
@nfx
nfx marked this pull request as ready for review June 2, 2023 10:42
pietern
pietern reviewed Jun 2, 2023
View reviewed changes

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the Windows tests pass.

Comment threadlibs/databrickscfg/ops_test.go Outdated
Comment threadlibs/databrickscfg/ops.go Outdated
Comment threadlibs/auth/oauth.go
func (a *PersistentAuth) profileName() string {
// TODO: get profile name from interactive input
if a.AccountID != "" {
return fmt.Sprintf("ACCOUNT-%s", a.AccountID)

@pieternpieternJun 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all caps?

@nfxnfxJun 2, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

account profiles should get special treatment. i'll add ACCOUNT profile to denote the default account in the subsequent PRs

Comment threadlibs/databrickscfg/ops.go
Serge Smertin added 2 commits June 2, 2023 13:02
@nfx
nfx requested a review from pieternJune 2, 2023 11:32
@nfx
nfx merged commit a6c9533 into mainJun 2, 2023
@nfx
nfx deleted the profiles-on-login branch June 2, 2023 11:49
@pieternpietern mentioned this pull request Jun 12, 2023
Merged
pietern added a commit that referenced this pull request Jun 12, 2023
@pietern
Release v0.100.3 (#461)
35dd56c
## Changes
CLI:
* Add directory tracking to sync
([#425](#425)).
* Add fs cat command for dbfs files
([#430](#430)).
* Add fs ls command for dbfs
([#429](#429)).
* Add fs mkdirs command for dbfs
([#432](#432)).
* Add fs rm command for dbfs
([#433](#433)).
* Add installation instructions
([#458](#458)).
* Add new line to cmdio JSON rendering
([#443](#443)).
* Add profile on `databricks auth login`
([#423](#423)).
* Add readable console logger
([#370](#370)).
* Add workspace export-dir command
([#449](#449)).
* Added secrets input prompt for secrets put-secret command
([#413](#413)).
* Added spinner when loading command prompts
([#420](#420)).
* Better error message if can not load prompts
([#437](#437)).
* Changed service template to correctly handle required positional
arguments ([#405](#405)).
* Do not generate prompts for certain commands
([#438](#438)).
* Do not prompt for List methods
([#411](#411)).
* Do not use FgWhite and FgBlack for terminal output
([#435](#435)).
* Skip path translation of job task for jobs with a Git source
([#404](#404)).
* Tweak profile prompt
([#454](#454)).
* Update with the latest Go SDK
([#457](#457)).
* Use cmdio in version command for `--output` flag
([#419](#419)).
Bundles:
* Check for nil environment before accessing it
([#453](#453)).
Dependencies:
* Bump github.com/hashicorp/terraform-json from 0.16.0 to 0.17.0
([#459](#459)).
* Bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19
([#412](#412)).
Internal:
* Add Mkdir and ReadDir functions to filer.Filer interface
([#414](#414)).
* Add Stat function to filer.Filer interface
([#421](#421)).
* Add check for path is a directory in filer.ReadDir
([#426](#426)).
* Add fs.FS adapter for the filer interface
([#422](#422)).
* Add implementation of filer.Filer for local filesystem
([#460](#460)).
* Allow equivalence checking of filer errors to fs errors
([#416](#416)).
* Fix locker integration test
([#417](#417)).
* Implement DBFS filer
([#139](#139)).
* Include recursive deletion in filer interface
([#442](#442)).
* Make filer.Filer return fs.DirEntry from ReadDir
([#415](#415)).
* Speed up sync integration tests
([#428](#428)).
@pieternpietern mentioned this pull request Jun 15, 2023
Closed
denik pushed a commit that referenced this pull request May 20, 2026
@nfx
Add profile ondatabricks auth login(#423)
ab2d270
## Changes
- added saving profile to `~/.databrickscfg` whenever we do `databricks
auth login`.
- we either match profile by account id / canonical host or introduce
the new one from deployment name.
- fail on multiple profiles with matching accounts or workspace hosts.
- overriding `~/.databrickscfg` keeps the (valid) comments, but
reformats the file.
## Tests
<!-- How is this tested? -->
- `make test`
- `go run main.go auth login --account-id XXX --host
https://accounts.cloud.databricks.com/`
- `go run main.go auth token --account-id XXX --host
https://accounts.cloud.databricks.com/`
- `go run main.go auth login --host https://XXX.cloud.databricks.com/`
denik pushed a commit that referenced this pull request May 20, 2026
@pietern
Release v0.100.3 (#461)
ea132b0
## Changes
CLI:
* Add directory tracking to sync
([#425](#425)).
* Add fs cat command for dbfs files
([#430](#430)).
* Add fs ls command for dbfs
([#429](#429)).
* Add fs mkdirs command for dbfs
([#432](#432)).
* Add fs rm command for dbfs
([#433](#433)).
* Add installation instructions
([#458](#458)).
* Add new line to cmdio JSON rendering
([#443](#443)).
* Add profile on `databricks auth login`
([#423](#423)).
* Add readable console logger
([#370](#370)).
* Add workspace export-dir command
([#449](#449)).
* Added secrets input prompt for secrets put-secret command
([#413](#413)).
* Added spinner when loading command prompts
([#420](#420)).
* Better error message if can not load prompts
([#437](#437)).
* Changed service template to correctly handle required positional
arguments ([#405](#405)).
* Do not generate prompts for certain commands
([#438](#438)).
* Do not prompt for List methods
([#411](#411)).
* Do not use FgWhite and FgBlack for terminal output
([#435](#435)).
* Skip path translation of job task for jobs with a Git source
([#404](#404)).
* Tweak profile prompt
([#454](#454)).
* Update with the latest Go SDK
([#457](#457)).
* Use cmdio in version command for `--output` flag
([#419](#419)).
Bundles:
* Check for nil environment before accessing it
([#453](#453)).
Dependencies:
* Bump github.com/hashicorp/terraform-json from 0.16.0 to 0.17.0
([#459](#459)).
* Bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19
([#412](#412)).
Internal:
* Add Mkdir and ReadDir functions to filer.Filer interface
([#414](#414)).
* Add Stat function to filer.Filer interface
([#421](#421)).
* Add check for path is a directory in filer.ReadDir
([#426](#426)).
* Add fs.FS adapter for the filer interface
([#422](#422)).
* Add implementation of filer.Filer for local filesystem
([#460](#460)).
* Allow equivalence checking of filer errors to fs errors
([#416](#416)).
* Fix locker integration test
([#417](#417)).
* Implement DBFS filer
([#139](#139)).
* Include recursive deletion in filer interface
([#442](#442)).
* Make filer.Filer return fs.DirEntry from ReadDir
([#415](#415)).
* Speed up sync integration tests
([#428](#428)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieternpieternpietern approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nfx@pietern