Skip to content

Add fs cat command for dbfs files - #430

Merged
shreyas-goenka merged 26 commits into
mainfrom
fs-cat
Jun 5, 2023
Merged

Add fs cat command for dbfs files#430
shreyas-goenka merged 26 commits into
mainfrom
fs-cat

Conversation

@shreyas-goenka

@shreyas-goenkashreyas-goenka commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Changes

TSIA

Tests

Manually and integration tests

@shreyas-goenka
shreyas-goenka changed the base branch from main to fs-lsJune 5, 2023 00:16
@shreyas-goenka

shreyas-goenka commented Jun 5, 2023

Copy link
Copy Markdown
ContributorAuthor

follow up: #431

andrewnester
andrewnester approved these changes Jun 5, 2023
View reviewed changes
Comment threadcmd/fs/cat.go Outdated
pietern
pietern reviewed Jun 5, 2023
View reviewed changes
Comment threadcmd/fs/cat.go Outdated
Comment threadcmd/fs/cat.go Outdated
Comment threadcmd/fs/cat.go
Comment threadlibs/filer/filer.go Outdated
return other == fs.ErrInvalid
}

type NotAFile struct {

@pieternpieternJun 5, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new error isn't used anywhere.

@shreyas-goenkashreyas-goenkaJun 5, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, removed it for now. We can add it again later once we fix databricks/databricks-sdk-go#414

pietern
pietern reviewed Jun 5, 2023
View reviewed changes

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM bar the comments, thanks.

Comment threadinternal/cat_test.go
Comment threadlibs/cmdio/io.go
Base automatically changed from fs-ls to mainJune 5, 2023 15:41
pietern
pietern reviewed Jun 5, 2023
View reviewed changes

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong with GitHub updating the target branch.

Comment threadinternal/ls_test.go
Comment threadcmd/fs/fs.go
Comment threadlibs/cmdio/io.go
@shreyas-goenka
shreyas-goenka merged commit ae10419 into mainJun 5, 2023
@shreyas-goenka
shreyas-goenka deleted the fs-cat branch June 5, 2023 23:16
@pieternpietern mentioned this pull request Jun 12, 2023
Merged
pietern added a commit that referenced this pull request Jun 12, 2023
@pietern
Release v0.100.3 (#461)
35dd56c
## Changes
CLI:
* Add directory tracking to sync
([#425](#425)).
* Add fs cat command for dbfs files
([#430](#430)).
* Add fs ls command for dbfs
([#429](#429)).
* Add fs mkdirs command for dbfs
([#432](#432)).
* Add fs rm command for dbfs
([#433](#433)).
* Add installation instructions
([#458](#458)).
* Add new line to cmdio JSON rendering
([#443](#443)).
* Add profile on `databricks auth login`
([#423](#423)).
* Add readable console logger
([#370](#370)).
* Add workspace export-dir command
([#449](#449)).
* Added secrets input prompt for secrets put-secret command
([#413](#413)).
* Added spinner when loading command prompts
([#420](#420)).
* Better error message if can not load prompts
([#437](#437)).
* Changed service template to correctly handle required positional
arguments ([#405](#405)).
* Do not generate prompts for certain commands
([#438](#438)).
* Do not prompt for List methods
([#411](#411)).
* Do not use FgWhite and FgBlack for terminal output
([#435](#435)).
* Skip path translation of job task for jobs with a Git source
([#404](#404)).
* Tweak profile prompt
([#454](#454)).
* Update with the latest Go SDK
([#457](#457)).
* Use cmdio in version command for `--output` flag
([#419](#419)).
Bundles:
* Check for nil environment before accessing it
([#453](#453)).
Dependencies:
* Bump github.com/hashicorp/terraform-json from 0.16.0 to 0.17.0
([#459](#459)).
* Bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19
([#412](#412)).
Internal:
* Add Mkdir and ReadDir functions to filer.Filer interface
([#414](#414)).
* Add Stat function to filer.Filer interface
([#421](#421)).
* Add check for path is a directory in filer.ReadDir
([#426](#426)).
* Add fs.FS adapter for the filer interface
([#422](#422)).
* Add implementation of filer.Filer for local filesystem
([#460](#460)).
* Allow equivalence checking of filer errors to fs errors
([#416](#416)).
* Fix locker integration test
([#417](#417)).
* Implement DBFS filer
([#139](#139)).
* Include recursive deletion in filer interface
([#442](#442)).
* Make filer.Filer return fs.DirEntry from ReadDir
([#415](#415)).
* Speed up sync integration tests
([#428](#428)).
denik pushed a commit that referenced this pull request May 20, 2026
@shreyas-goenka
Add fs cat command for dbfs files (#430)
3299624
## Changes
TSIA
## Tests
Manually and integration tests
denik pushed a commit that referenced this pull request May 20, 2026
@pietern
Release v0.100.3 (#461)
ea132b0
## Changes
CLI:
* Add directory tracking to sync
([#425](#425)).
* Add fs cat command for dbfs files
([#430](#430)).
* Add fs ls command for dbfs
([#429](#429)).
* Add fs mkdirs command for dbfs
([#432](#432)).
* Add fs rm command for dbfs
([#433](#433)).
* Add installation instructions
([#458](#458)).
* Add new line to cmdio JSON rendering
([#443](#443)).
* Add profile on `databricks auth login`
([#423](#423)).
* Add readable console logger
([#370](#370)).
* Add workspace export-dir command
([#449](#449)).
* Added secrets input prompt for secrets put-secret command
([#413](#413)).
* Added spinner when loading command prompts
([#420](#420)).
* Better error message if can not load prompts
([#437](#437)).
* Changed service template to correctly handle required positional
arguments ([#405](#405)).
* Do not generate prompts for certain commands
([#438](#438)).
* Do not prompt for List methods
([#411](#411)).
* Do not use FgWhite and FgBlack for terminal output
([#435](#435)).
* Skip path translation of job task for jobs with a Git source
([#404](#404)).
* Tweak profile prompt
([#454](#454)).
* Update with the latest Go SDK
([#457](#457)).
* Use cmdio in version command for `--output` flag
([#419](#419)).
Bundles:
* Check for nil environment before accessing it
([#453](#453)).
Dependencies:
* Bump github.com/hashicorp/terraform-json from 0.16.0 to 0.17.0
([#459](#459)).
* Bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19
([#412](#412)).
Internal:
* Add Mkdir and ReadDir functions to filer.Filer interface
([#414](#414)).
* Add Stat function to filer.Filer interface
([#421](#421)).
* Add check for path is a directory in filer.ReadDir
([#426](#426)).
* Add fs.FS adapter for the filer interface
([#422](#422)).
* Add implementation of filer.Filer for local filesystem
([#460](#460)).
* Allow equivalence checking of filer errors to fs errors
([#416](#416)).
* Fix locker integration test
([#417](#417)).
* Implement DBFS filer
([#139](#139)).
* Include recursive deletion in filer interface
([#442](#442)).
* Make filer.Filer return fs.DirEntry from ReadDir
([#415](#415)).
* Speed up sync integration tests
([#428](#428)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieternpieternpietern left review comments
@andrewnesterandrewnesterandrewnester approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shreyas-goenka@pietern@andrewnester