Uh oh!
There was an error while loading. Please reload this page.
Config remote sync command - #4289
Merged
Merged
Conversation
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 15, 2026 13:19 — with 
GitHub Actions
Inactive
Collaborator
Commit: e3ac580
20 interesting tests: 9 KNOWN, 5 SKIP, 4 RECOVERED, 2 flaky
Top 50 slowest tests (at least 2 minutes):
|
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 18, 2026 23:21 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 19, 2026 17:25 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 19, 2026 17:42 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 19, 2026 17:45 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 23, 2026 16:52 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 24, 2026 09:41 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 26, 2026 13:46 — with GitHub Actions
Inactive
ContributorAuthor
@denik could you TAL again? I want to land this one and 2 other smaller dependent PRs before next release |
denik
approved these changes
Jan 27, 2026
denik
left a comment
Contributor
There was a problem hiding this comment.
I left a few comments. Since it's experimental, those can also be addressed in follow up PRs - up to you how to structure this.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| return nil, fmt.Errorf("failed to resolve selectors in path %s: %w", fullPath, err) | ||
| } | ||
| loc := b.Config.GetLocation(resolvedPath) |
Contributor
There was a problem hiding this comment.
I think this won't work for changes that point inside a map because it relies on dyn.Path parser and that cannot handle keys that have dots in them.
One possible fix: implement new GetLocationP(path *PathNode) that can return location by iterating over PathNode without stringifying it or converting it to dyn.Path. Then you don't need resolveSelectors or rather resolveSelectors moves inside GetLocationP
ContributorAuthor
There was a problem hiding this comment.
Good idea, will do in separate PR
Uh oh!
There was an error while loading. Please reload this page.
| type resolvedChanges map[string]*deployplan.ChangeDesc | ||
| // normalizeValue converts values to plain Go types suitable for YAML patching | ||
| // by using SDK marshaling which properly handles ForceSendFields and other annotations. |
Contributor
There was a problem hiding this comment.
I used similar approach - roundtrip via json for converting config into structs for direct engine, but I had to move away from that #3646
I think the reasons for avoiding json roundtrip are still valid and should be applied there as well. One reason is that we don't use ForceSendFields the same way in DABs as they used in SDK causing json marshaller to crash.
In this case it's also not clear why json roundtrip is needed in the first place.
ContributorAuthor
There was a problem hiding this comment.
Thanks, I'll check that separately
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 27, 2026 16:09 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 27, 2026 16:25 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 27, 2026 19:04 — with GitHub Actions
Inactive
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Jan 27, 2026
Collaborator
Commit: 06fa7e5
25 interesting tests: 9 KNOWN, 7 flaky, 5 SKIP, 4 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
1 task
github-merge-queueBot
pushed a commit
that referenced
this pull request
Apr 13, 2026
## Summary - Move `gopkg.in/yaml.v3` from a standalone indirect `require` line into the grouped indirect block via `go mod tidy` - #4353 migrated direct imports to `go.yaml.in/yaml/v3` and moved `gopkg.in/yaml.v3` into the grouped indirect block - #4289 added a direct dependency on `gopkg.in/yaml.v3` (via `palantir/pkg/yamlpatch`), pulling it back out as a standalone `require` line - #4400 marked it as `// indirect` but left it as a standalone line ## Test plan - [x] `go mod tidy` produces no diff This pull request was AI-assisted by Isaac.
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes New experimental command `databricks bundle config-remote-sync`. The command fetches the latest remote changes of resources and compares them to the deployed state. With the `--save` flag, it also writes changes back to YAML files. The command leverages the diffing algorithm of the `bundle plan` command. Also note that new dependency is added to do yaml patching that preserves comments This is a first PR, I will continue fixing all limitations in the next PRs Current limitations: - The command only works in direct mode, for TF engine the plan is to prepare a deploy-time conversion of Terraform state to direct engine state (behind the env-flag DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC) - Server-side defaults are hardcoded for now until it is better supported in the `bundle plan` - Selectors like `tasks[task_key='my_task']` need to be tested for cases when the object or parent doesn't exist - CLI transformations (dev prefixes, path translations, resource mutators etc) and variables are not properly handled, so there are some bugs possible when it affects these fields - Tested only for jobs No changelog entries are needed as the command is intended to be private for now, and we don't want to encourage users to use it due to the unstable API ## Why This command serves as the backend for the new visual authoring feature in DABs in the Workspace. User edits job or pipeline in the Workspace UI, then clicks the "Sync" button, and then the new command applies the diff to the source configuration files. Then the user may accept or reject these changes in the editor ## Tests Currently, only unit tests to speed up devloop, but once I have full functionality, I'll add proper acceptance test coverage Acceptance tests are failing because of the change in formatting (even though the command is hidden) <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Summary - Move `gopkg.in/yaml.v3` from a standalone indirect `require` line into the grouped indirect block via `go mod tidy` - #4353 migrated direct imports to `go.yaml.in/yaml/v3` and moved `gopkg.in/yaml.v3` into the grouped indirect block - #4289 added a direct dependency on `gopkg.in/yaml.v3` (via `palantir/pkg/yamlpatch`), pulling it back out as a standalone `require` line - #4400 marked it as `// indirect` but left it as a standalone line ## Test plan - [x] `go mod tidy` produces no diff This pull request was AI-assisted by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New experimental command
databricks bundle config-remote-sync. The command fetches the latest remote changes of resources and compares them to the deployed state. With the--saveflag, it also writes changes back to YAML files.The command leverages the diffing algorithm of the
bundle plancommand. Also note that new dependency is added to do yaml patching that preserves commentsThis is a first PR, I will continue fixing all limitations in the next PRs
Current limitations:
bundle plantasks[task_key='my_task']need to be tested for cases when the object or parent doesn't existNo changelog entries are needed as the command is intended to be private for now, and we don't want to encourage users to use it due to the unstable API
Why
This command serves as the backend for the new visual authoring feature in DABs in the Workspace.
User edits job or pipeline in the Workspace UI, then clicks the "Sync" button, and then the new command applies the diff to the source configuration files. Then the user may accept or reject these changes in the editor
Tests
Currently, only unit tests to speed up devloop, but once I have full functionality, I'll add proper acceptance test coverage
Acceptance tests are failing because of the change in formatting (even though the command is hidden)