Uh oh!
There was an error while loading. Please reload this page.
Make config-remote-sync patching logic more generic - #4400
Merged
Conversation
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 29, 2026 23:02 — with 
GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 29, 2026 23:05 — with GitHub Actions
Inactive
Collaborator
Commit: b694b69
18 interesting tests: 9 KNOWN, 5 SKIP, 4 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 30, 2026 09:18 — with GitHub Actions
Inactive
ilyakuz-dbtemporarily deployed
to
test-trigger-is
January 30, 2026 10:08 — with GitHub Actions
Inactive
ilyakuz-db
commented
Jan 30, 2026
| // normalizeValue converts values to plain Go types suitable for YAML patching | ||
| // by using SDK marshaling which properly handles ForceSendFields and other annotations. | ||
| func normalizeValue(v any) (any, error) { |
ContributorAuthor
There was a problem hiding this comment.
This is moved as is from patch.go
Will check if it's needed and can it be replaced with dyn in following PRs
ilyakuz-db
commented
Jan 30, 2026
| type resolvedChanges map[string]*deployplan.ChangeDesc | ||
| // ApplyChangesToYAML generates YAML files for the given field changes. | ||
| func ApplyChangesToYAML(ctx context.Context, b *bundle.Bundle, fieldChanges []FieldChange) ([]FileChange, error) { |
ContributorAuthor
There was a problem hiding this comment.
This was simplified to reduce nesting level, also bundle-specific logic was moved to diff.go and resolve.go
ilyakuz-db
commented
Jan 30, 2026
| } | ||
| // ResolveChanges resolves selectors and computes field path candidates for each change. | ||
| func ResolveChanges(ctx context.Context, b *bundle.Bundle, configChanges Changes) ([]FieldChange, error) { |
ContributorAuthor
There was a problem hiding this comment.
All path resolution is handled here now, I will update this to traverse path nodes in following PRs
denik
approved these changes
Jan 30, 2026
denik
left a comment
Contributor
There was a problem hiding this comment.
Could you make PR description more concrete? Which functions/types were moved, which were changed, which replaced by something newer.
ilyakuz-db
marked this pull request as ready for review
January 30, 2026 15:26
ilyakuz-db
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJanuary 30, 2026 15:26
ilyakuz-db
commented
Jan 30, 2026
ContributorAuthor
Elaborated a bit |
1 task
github-merge-queueBot
pushed a commit
that referenced
this pull request
Apr 13, 2026
## Summary - Move `gopkg.in/yaml.v3` from a standalone indirect `require` line into the grouped indirect block via `go mod tidy` - #4353 migrated direct imports to `go.yaml.in/yaml/v3` and moved `gopkg.in/yaml.v3` into the grouped indirect block - #4289 added a direct dependency on `gopkg.in/yaml.v3` (via `palantir/pkg/yamlpatch`), pulling it back out as a standalone `require` line - #4400 marked it as `// indirect` but left it as a standalone line ## Test plan - [x] `go mod tidy` produces no diff This pull request was AI-assisted by Isaac.
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Split the config-remote-sync command into 3 separate phases. Previously, some DAB-specific logic was embedded in the patcher, now it 1. Detect (diff.go) - Compare states, handle server-side and CLI defaults. Convert value to the internal struct. Compute which operation type should be applied to the config 2. Resolve (resolve.go) - Determine file locations and field paths. Replace [task_key=foo] selectors 3. Patch (patch.go) - Now only handles YAML modifications, doesn't hold any config-specific logic Changes: 1. new ConfigChangeDesc struct 2. normalizeValue() moved from patch.go to diff.go 3. selector handling moved to `resolve.go` 4. /targets/ prefixes moved from `patch.go` to `resolve.go` 5. new explicit type for operations which we also show in the output 6. removed bunch of redundant tests - this logic is covered in acceptance suites ## Why Preparation before the next PR, where I plan to properly handle CLI defaults ## Tests 1. Updated snapshots to capture new debug output 2. Removed redundant unit tests - these cases are already covered with acceptance tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Summary - Move `gopkg.in/yaml.v3` from a standalone indirect `require` line into the grouped indirect block via `go mod tidy` - #4353 migrated direct imports to `go.yaml.in/yaml/v3` and moved `gopkg.in/yaml.v3` into the grouped indirect block - #4289 added a direct dependency on `gopkg.in/yaml.v3` (via `palantir/pkg/yamlpatch`), pulling it back out as a standalone `require` line - #4400 marked it as `// indirect` but left it as a standalone line ## Test plan - [x] `go mod tidy` produces no diff This pull request was AI-assisted by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Split the config-remote-sync command into 3 separate phases. Previously, some DAB-specific logic was embedded in the patcher, now it
Detect (diff.go) - Compare states, handle server-side and CLI defaults. Convert value to the internal struct. Compute which operation type should be applied to the config
Resolve (resolve.go) - Determine file locations and field paths. Replace [task_key=foo] selectors
Patch (patch.go) - Now only handles YAML modifications, doesn't hold any config-specific logic
Changes:
resolve.gopatch.gotoresolve.goWhy
Preparation before the next PR, where I plan to properly handle CLI defaults
Tests