Uh oh!
There was an error while loading. Please reload this page.
Make all prompts write to stderr instead of stdout - #4301
Merged
Conversation
Replace scattered interactive/prompt booleans in cmdIO with a single Capabilities struct that encapsulates all terminal capability detection (TTY status, color support, prompt support, Git Bash detection). Changes: - Add Capabilities struct with methods SupportsInteractive(), SupportsPrompt(), SupportsColor() - Move IsTTY to tty.go with FakeTTY test helper - Replace cmdio.IsTTY(w) with cmdio.SupportsColor(ctx, w) for color decisions - Replace stdin TTY check with IsPromptSupported() in aitools install No behavioral changes. Respects NO_COLOR and TERM=dumb throughout. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
All prompt functions now consistently write to stderr, removing the need to check if stdout is a TTY for prompt support. Changes: - Select() now sets Stdout to stderr - Secret() now sets Stdin and Stdout to use cmdio streams (stderr) - Prompt() now uses stderr instead of stdout - AskSelect() now explicitly sets Stdin and Stdout - SupportsPrompt() no longer requires stdoutIsTTY This simplifies the logic and follows Unix conventions: keep stdout clean for data/piping, use stderr for interactive UI elements. Now prompts work even when stdout is redirected (e.g., `databricks cmd | tee output.txt`). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pietern
requested review from
andrewnester, anton-107, denik and shreyas-goenka
as code ownersJanuary 16, 2026 12:38
pieterntemporarily deployed
to
test-trigger-is
January 16, 2026 12:38 — with 
GitHub Actions
Inactive
pieternhad a problem deploying
to
test-trigger-is
January 16, 2026 12:41 — with GitHub Actions
Failure
denik
approved these changes
Jan 16, 2026
Collaborator
Commit: 0a573be
24 interesting tests: 9 RECOVERED, 6 KNOWN, 5 flaky, 3 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
pieterntemporarily deployed
to
test-trigger-is
January 16, 2026 13:29 — with GitHub Actions
Inactive
pietern
requested review from
a team, jefferycheng1, kanterov and lennartkats-db
as code ownersJanuary 16, 2026 15:10
lennartkats-db
approved these changes
Jan 16, 2026
pietern
enabled auto-merge
January 16, 2026 15:24
pieterntemporarily deployed
to
test-trigger-is
January 16, 2026 15:24 — with GitHub Actions
Inactive
pietern
disabled auto-merge
January 19, 2026 07:46
pietern
commented
Jan 19, 2026
ContributorAuthor
Integration test failures are unrelated. |
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Jan 19, 2026
Collaborator
Commit: 3dea15d
24 interesting tests: 10 KNOWN, 8 RECOVERED, 3 FAIL, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
3 tasks
pietern added a commit
that referenced
this pull request
Feb 13, 2026
## Summary - Fixes#4481 — arrow keys stopped working for yes/no and enum selection during `databricks bundle init` on Windows - Root cause: PR #4301 started passing `io.NopCloser(os.Stdin)` as explicit `Stdin` to `promptui`, which bypasses `chzyer/readline`'s Windows-specific `RawReader`. That reader uses `ReadConsoleInputW` to translate arrow key virtual key codes (`VK_UP`/`VK_DOWN`) into readline navigation — without it, arrow keys are silently ignored on Windows. - Fix: introduce `promptStdin()` helper that returns `nil` when `c.in` is `os.Stdin` (letting readline use its platform default) and wraps custom readers for test scenarios. ## Test plan - [x] `go test ./libs/cmdio/...` passes - [x] `go test ./libs/template/...` passes - [x] Verify on Windows that arrow keys work in `databricks bundle init` selection prompts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes All prompt functions now consistently write to stderr, removing the need to check if stdout is a TTY for prompt support. Depends on #4298. ## Why This simplifies the logic and follows Unix conventions: keep stdout clean for data/piping, use stderr for interactive UI elements. Now prompts work even when stdout is redirected (e.g., `databricks cmd | tee output.txt`). --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Summary - Fixes#4481 — arrow keys stopped working for yes/no and enum selection during `databricks bundle init` on Windows - Root cause: PR #4301 started passing `io.NopCloser(os.Stdin)` as explicit `Stdin` to `promptui`, which bypasses `chzyer/readline`'s Windows-specific `RawReader`. That reader uses `ReadConsoleInputW` to translate arrow key virtual key codes (`VK_UP`/`VK_DOWN`) into readline navigation — without it, arrow keys are silently ignored on Windows. - Fix: introduce `promptStdin()` helper that returns `nil` when `c.in` is `os.Stdin` (letting readline use its platform default) and wraps custom readers for test scenarios. ## Test plan - [x] `go test ./libs/cmdio/...` passes - [x] `go test ./libs/template/...` passes - [x] Verify on Windows that arrow keys work in `databricks bundle init` selection prompts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
All prompt functions now consistently write to stderr, removing the need to check if stdout is a TTY for prompt support.
Depends on #4298.
Why
This simplifies the logic and follows Unix conventions: keep stdout clean for data/piping, use stderr for interactive UI elements. Now prompts work even when stdout is redirected (e.g.,
databricks cmd | tee output.txt).