Uh oh!
There was an error while loading. Please reload this page.
Fix arrow key navigation in prompts on Windows - #4501
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pietern
requested review from
andrewnester, anton-107, denik and shreyas-goenka
as code ownersFebruary 12, 2026 13:30
pieterntemporarily deployed
to
test-trigger-is
February 12, 2026 13:30 — with 
GitHub Actions
Inactive
Collaborator
Commit: 889dd86
22 interesting tests: 8 KNOWN, 5 SKIP, 5 RECOVERED, 4 flaky
Top 50 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Feb 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Feb 13, 2026
Collaborator
Commit: 0eb72d1
27 interesting tests: 9 flaky, 8 KNOWN, 5 SKIP, 5 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Feb 19, 2026
## Release v0.289.0 ### CLI * Make auth profiles respect DATABRICKS_CLI_PATH env var (([#4467](#4467))) * Fix arrow key navigation in prompts on Windows (([#4501](#4501))) ### Bundles * Log artifact build output in debug mode ([#4208](#4208)) * Fix bundle init not working in Azure Government ([#4286](#4286)) * Allow single and double quotes in environment dependencies (([#4511](#4511))) * Use purge option when deleting alerts (([#4505](#4505))) * engine/direct: Replace server_side_default with more precise backend_default rule in bundle plan ([#4490](#4490)) * engine/direct: Extend pipelines recreate_on_changes configuration (([#4499](#4499))) * engine/direct: Added support for UC external locations (direct only) ([#4484](#4484)) ### Dependency updates * Upgrade Go SDK to v0.106.0 (([#4486](#4486))) * Upgrade Terraform provider to v1.106.0 (([#4542](#4542))) * Upgrade Go to 1.25.7 (([#4547](#4547)))
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Summary - Fixes#4481 — arrow keys stopped working for yes/no and enum selection during `databricks bundle init` on Windows - Root cause: PR #4301 started passing `io.NopCloser(os.Stdin)` as explicit `Stdin` to `promptui`, which bypasses `chzyer/readline`'s Windows-specific `RawReader`. That reader uses `ReadConsoleInputW` to translate arrow key virtual key codes (`VK_UP`/`VK_DOWN`) into readline navigation — without it, arrow keys are silently ignored on Windows. - Fix: introduce `promptStdin()` helper that returns `nil` when `c.in` is `os.Stdin` (letting readline use its platform default) and wraps custom readers for test scenarios. ## Test plan - [x] `go test ./libs/cmdio/...` passes - [x] `go test ./libs/template/...` passes - [x] Verify on Windows that arrow keys work in `databricks bundle init` selection prompts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.289.0 ### CLI * Make auth profiles respect DATABRICKS_CLI_PATH env var (([#4467](#4467))) * Fix arrow key navigation in prompts on Windows (([#4501](#4501))) ### Bundles * Log artifact build output in debug mode ([#4208](#4208)) * Fix bundle init not working in Azure Government ([#4286](#4286)) * Allow single and double quotes in environment dependencies (([#4511](#4511))) * Use purge option when deleting alerts (([#4505](#4505))) * engine/direct: Replace server_side_default with more precise backend_default rule in bundle plan ([#4490](#4490)) * engine/direct: Extend pipelines recreate_on_changes configuration (([#4499](#4499))) * engine/direct: Added support for UC external locations (direct only) ([#4484](#4484)) ### Dependency updates * Upgrade Go SDK to v0.106.0 (([#4486](#4486))) * Upgrade Terraform provider to v1.106.0 (([#4542](#4542))) * Upgrade Go to 1.25.7 (([#4547](#4547)))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
databricks bundle initon Windowsio.NopCloser(os.Stdin)as explicitStdintopromptui, which bypasseschzyer/readline's Windows-specificRawReader. That reader usesReadConsoleInputWto translate arrow key virtual key codes (VK_UP/VK_DOWN) into readline navigation — without it, arrow keys are silently ignored on Windows.promptStdin()helper that returnsnilwhenc.inisos.Stdin(letting readline use its platform default) and wraps custom readers for test scenarios.Test plan
go test ./libs/cmdio/...passesgo test ./libs/template/...passesdatabricks bundle initselection prompts🤖 Generated with Claude Code