Uh oh!
There was an error while loading. Please reload this page.
direct: Ignore changes between nulls and empty slices/maps - #4313
Merged
Conversation
Empty slices (e.g., `on_failure: []`) and empty maps (e.g., `tags: {}`)
should not cause drift. Added reasons `empty_slice` and `empty_map` to
indicate why these changes are skipped.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJanuary 19, 2026 09:37
pietern
approved these changes
Jan 19, 2026
| } else if isEmptySlice(ch.Old, ch.New, ch.Remote) { | ||
| // Empty slice in config should not cause drift when remote has values | ||
| ch.Action = deployplan.Skip | ||
| ch.Reason = deployplan.ReasonEmptySlice |
Contributor
There was a problem hiding this comment.
IIRC, the reason behind this is that nils and empty slices/maps are represented the same in proto.
Can you leave a comment here, or in the isEmptyZZZ functions, explaining the motivation for treating them the same here?
denik
enabled auto-merge
January 19, 2026 10:24
Collaborator
Commit: 756644d
28 interesting tests: 22 KNOWN, 4 flaky, 1 SKIP, 1 RECOVERED
Top 38 slowest tests (at least 2 minutes):
|
denik
disabled auto-merge
January 20, 2026 10:06
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Jan 20, 2026
Collaborator
Commit: b9c7eb9
32 interesting tests: 22 KNOWN, 6 flaky, 2 FAIL, 1 SKIP, 1 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jan 21, 2026
## Release v0.284.0 ### Bundles * Pass additional Azure DevOps `SYSTEM_*` environment variables to Terraform for OIDC authentication: `SYSTEM_COLLECTIONURI`, `SYSTEM_DEFINITIONID`, `SYSTEM_HOSTTYPE`, `SYSTEM_JOBID`, `SYSTEM_TEAMPROJECT` ([#4318](#4318)) * Add support for valueFrom property (similar to app.yaml) inside Apps config field in bundle configuration ([#4297](#4297)) * engine/direct: Support bind & unbind. ([#4279](#4279)) * engine/direct: Ignore changes between nulls and empty slices/maps (([#4313](#4313))) * engine/direct: Ignore changes between nulls and empty structs (([#4338](#4338))) * On terraform `bundle plan -o json` will no longer include plan_version key, it's intended for direct engine only (([#4314](#4314)))
denik added a commit
that referenced
this pull request
May 20, 2026
## Why Although these changes can appear in configs, they cannot be represented by SDK's structs, so they cannot be persisted or appear in remote reply, thus causing a permanent drift. Fixes#4121 ## Tests Existing and new acceptance tests. --------- Co-authored-by: Claude <noreply@anthropic.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.284.0 ### Bundles * Pass additional Azure DevOps `SYSTEM_*` environment variables to Terraform for OIDC authentication: `SYSTEM_COLLECTIONURI`, `SYSTEM_DEFINITIONID`, `SYSTEM_HOSTTYPE`, `SYSTEM_JOBID`, `SYSTEM_TEAMPROJECT` ([#4318](#4318)) * Add support for valueFrom property (similar to app.yaml) inside Apps config field in bundle configuration ([#4297](#4297)) * engine/direct: Support bind & unbind. ([#4279](#4279)) * engine/direct: Ignore changes between nulls and empty slices/maps (([#4313](#4313))) * engine/direct: Ignore changes between nulls and empty structs (([#4338](#4338))) * On terraform `bundle plan -o json` will no longer include plan_version key, it's intended for direct engine only (([#4314](#4314)))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Although these changes can appear in configs, they cannot be represented by SDK's structs, so they cannot be persisted or appear in remote reply, thus causing a permanent drift.
Fixes#4121
Tests
Existing and new acceptance tests.