Uh oh!
There was an error while loading. Please reload this page.
direct: Add empty_struct reason to skip - #4338
Merged
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJanuary 20, 2026 16:23
denik
enabled auto-merge
January 20, 2026 16:51
andrewnester
approved these changes
Jan 20, 2026
Collaborator
Commit: 2f7f214
76 interesting tests: 46 FAIL, 19 KNOWN, 6 flaky, 4 RECOVERED, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
denik
disabled auto-merge
January 21, 2026 10:02
Uh oh!
There was an error while loading. Please reload this page.
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jan 21, 2026
## Release v0.284.0 ### Bundles * Pass additional Azure DevOps `SYSTEM_*` environment variables to Terraform for OIDC authentication: `SYSTEM_COLLECTIONURI`, `SYSTEM_DEFINITIONID`, `SYSTEM_HOSTTYPE`, `SYSTEM_JOBID`, `SYSTEM_TEAMPROJECT` ([#4318](#4318)) * Add support for valueFrom property (similar to app.yaml) inside Apps config field in bundle configuration ([#4297](#4297)) * engine/direct: Support bind & unbind. ([#4279](#4279)) * engine/direct: Ignore changes between nulls and empty slices/maps (([#4313](#4313))) * engine/direct: Ignore changes between nulls and empty structs (([#4338](#4338))) * On terraform `bundle plan -o json` will no longer include plan_version key, it's intended for direct engine only (([#4314](#4314)))
eng-dev-ecosystem-bot
commented
Jan 21, 2026
Collaborator
Commit: 96d7b22
33 interesting tests: 19 KNOWN, 5 FAIL, 4 RECOVERED, 2 BUG, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
denik added a commit
that referenced
this pull request
May 20, 2026
## Why
Some struct fields come back with an empty dict `{}`, e.g.
email_notifications. Currently, we're relying on server_side_default to
skip those, but we want to remove server_side_default in the future and
replace with better & more targetted reasons.denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.284.0 ### Bundles * Pass additional Azure DevOps `SYSTEM_*` environment variables to Terraform for OIDC authentication: `SYSTEM_COLLECTIONURI`, `SYSTEM_DEFINITIONID`, `SYSTEM_HOSTTYPE`, `SYSTEM_JOBID`, `SYSTEM_TEAMPROJECT` ([#4318](#4318)) * Add support for valueFrom property (similar to app.yaml) inside Apps config field in bundle configuration ([#4297](#4297)) * engine/direct: Support bind & unbind. ([#4279](#4279)) * engine/direct: Ignore changes between nulls and empty slices/maps (([#4313](#4313))) * engine/direct: Ignore changes between nulls and empty structs (([#4338](#4338))) * On terraform `bundle plan -o json` will no longer include plan_version key, it's intended for direct engine only (([#4314](#4314)))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some struct fields come back with an empty dict
{}, e.g. email_notifications. Currently, we're relying on server_side_default to skip those, but we want to remove server_side_default in the future and replace with better & more targetted reasons.