Uh oh!
There was an error while loading. Please reload this page.
Show warning message if valueFrom is used instead of value_from in app config section - #4429
Merged
Merged
Conversation
andrewnester
requested review from
anton-107, denik, pietern and shreyas-goenka
as code ownersFebruary 3, 2026 11:28
andrewnestertemporarily deployed
to
test-trigger-is
February 3, 2026 11:29 — with 
GitHub Actions
Inactive
denik
reviewed
Feb 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
andrewnestertemporarily deployed
to
test-trigger-is
February 3, 2026 17:04 — with GitHub Actions
Inactive
denik
approved these changes
Feb 4, 2026
andrewnestertemporarily deployed
to
test-trigger-is
February 4, 2026 11:39 — with GitHub Actions
Inactive
Collaborator
Commit: 9fc36ac
23 interesting tests: 7 KNOWN, 5 SKIP, 5 RECOVERED, 4 flaky, 2 FAIL
Top 50 slowest tests (at least 2 minutes):
|
Uh oh!
There was an error while loading. Please reload this page.
pietern
reviewed
Feb 4, 2026
| if !pv.IsAnchor() { | ||
| // Special case: provide a more helpful message for "valueFrom" vs "value_from" | ||
| if fieldName == "valueFrom" { | ||
| if _, hasValueFrom := info.Fields["value_from"]; hasValueFrom { |
Contributor
There was a problem hiding this comment.
Since we have access to info.Fields, can't we generalize this more for any typo?
E.g. unknown field: %s, did you mean %q?
eng-dev-ecosystem-bot
commented
Feb 4, 2026
Collaborator
Commit: c88f570
29 interesting tests: 10 flaky, 9 RECOVERED, 5 SKIP, 3 KNOWN, 2 FAIL
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Feb 5, 2026
## Release v0.287.0 ### CLI * Add Lakebase Autoscaling support to `psql` command ([#4399](#4399)) * Add `workspace_id` to the profiles command ([#4404](#4404)) ### Bundles * Add support for Lakebase resources (postgres_projects, postgres_branches, postgres_endpoints) ([#4423](#4423)) * Add missing values to SchemaGrantPrivilege enum ([#4380](#4380)) * Added support for UC catalogs (only in direct mode) ([#4342](#4342)) * engine/direct: Fix updates to fields being ignored for database_catalogs, synced_database_tables (([#4388](#4388))) * engine/direct: Fix migration for database_instances, database_catalog, synced_database_tables ([#4424](#4424)) * Show warning message if valueFrom is used instead of value_from in app config section ([$4429](#4429))
denik pushed a commit
that referenced
this pull request
May 20, 2026
…p config section (#4429) ## Changes Show warning message if camel case field is used instead of snake case ## Why DABs syntax uses snake case for all the configuration fields. Sometimes users might use camelCase instead which leads to a warning. With this change we guide users to use the correct field name. Fixes#4297 (comment) ## Tests Added an acceptance test <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.287.0 ### CLI * Add Lakebase Autoscaling support to `psql` command ([#4399](#4399)) * Add `workspace_id` to the profiles command ([#4404](#4404)) ### Bundles * Add support for Lakebase resources (postgres_projects, postgres_branches, postgres_endpoints) ([#4423](#4423)) * Add missing values to SchemaGrantPrivilege enum ([#4380](#4380)) * Added support for UC catalogs (only in direct mode) ([#4342](#4342)) * engine/direct: Fix updates to fields being ignored for database_catalogs, synced_database_tables (([#4388](#4388))) * engine/direct: Fix migration for database_instances, database_catalog, synced_database_tables ([#4424](#4424)) * Show warning message if valueFrom is used instead of value_from in app config section ([$4429](#4429))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Show warning message if camel case field is used instead of snake case
Why
DABs syntax uses snake case for all the configuration fields. Sometimes users might use camelCase instead which leads to a warning. With this change we guide users to use the correct field name.
Fixes#4297 (comment)
Tests
Added an acceptance test