Uh oh!
There was an error while loading. Please reload this page.
Fix ignore_{remote,local}_changes setting in resource.yml - #4388
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJanuary 29, 2026 10:17
denikforce-pushed
the
denik/pathnode-prefix
branch
from
January 29, 2026 10:23
298d20c to
a679fa9Comparedenikforce-pushed
the
denik/fix-ignore_remote_changes
branch
from
January 29, 2026 10:44
1b567e0 to
13d689bCompareCollaborator
Commit: 50f274c
25 interesting tests: 9 KNOWN, 7 flaky, 5 SKIP, 4 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
It was ignoring all changes, not just remote.
denikforce-pushed
the
denik/fix-ignore_remote_changes
branch
from
January 29, 2026 11:35
13d689b to
834f461Comparepietern
approved these changes
Jan 29, 2026
| # Tags updates are not supported by TF. This mirrors that behaviour. | ||
| - tags | ||
| ignore_local_changes: | ||
| - tags |
Contributor
There was a problem hiding this comment.
Why also local? Can they only be set on create?
ContributorAuthor
There was a problem hiding this comment.
Yes, AFAIK there is separate API for tags update that we don't implement. cc @shreyas-goenka to confirm.
The tests already record expectation that there is no update on 'tags' local change.
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Jan 29, 2026
Collaborator
Commit: 75c185d
20 interesting tests: 9 KNOWN, 5 SKIP, 4 RECOVERED, 2 flaky
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Feb 5, 2026
## Release v0.287.0 ### CLI * Add Lakebase Autoscaling support to `psql` command ([#4399](#4399)) * Add `workspace_id` to the profiles command ([#4404](#4404)) ### Bundles * Add support for Lakebase resources (postgres_projects, postgres_branches, postgres_endpoints) ([#4423](#4423)) * Add missing values to SchemaGrantPrivilege enum ([#4380](#4380)) * Added support for UC catalogs (only in direct mode) ([#4342](#4342)) * engine/direct: Fix updates to fields being ignored for database_catalogs, synced_database_tables (([#4388](#4388))) * engine/direct: Fix migration for database_instances, database_catalog, synced_database_tables ([#4424](#4424)) * Show warning message if valueFrom is used instead of value_from in app config section ([$4429](#4429))
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Fix ignore_remote_changes to ignoring only remote changes (it was ignoring all on a given path). - Respect ignore_local_changes setting. Currently, few resources use it (experiments, database_catalogs, synced_database_tables since #4364). Follow up to #4304 ## Tests Existing. I have follow up PRs that make more use of ignore_remote_changes which make this bug apparent.
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.287.0 ### CLI * Add Lakebase Autoscaling support to `psql` command ([#4399](#4399)) * Add `workspace_id` to the profiles command ([#4404](#4404)) ### Bundles * Add support for Lakebase resources (postgres_projects, postgres_branches, postgres_endpoints) ([#4423](#4423)) * Add missing values to SchemaGrantPrivilege enum ([#4380](#4380)) * Added support for UC catalogs (only in direct mode) ([#4342](#4342)) * engine/direct: Fix updates to fields being ignored for database_catalogs, synced_database_tables (([#4388](#4388))) * engine/direct: Fix migration for database_instances, database_catalog, synced_database_tables ([#4424](#4424)) * Show warning message if valueFrom is used instead of value_from in app config section ([$4429](#4429))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Currently, few resources use it (experiments, database_catalogs, synced_database_tables since #4364).
Follow up to #4304
Tests
Existing. I have follow up PRs that make more use of ignore_remote_changes which make this bug apparent.