Uh oh!
There was an error while loading. Please reload this page.
[Internal] Refactor WorkspaceId to WorkspaceID in CLI-owned types - #4532
Merged
Conversation
tanmay-db
requested review from
a team, andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersFebruary 17, 2026 13:33
tanmay-db
removed request for
a team, andrewnester, anton-107, denik, pietern and shreyas-goenkaFebruary 17, 2026 13:33
tanmay-dbtemporarily deployed
to
test-trigger-is
February 17, 2026 13:34 — with 
GitHub Actions
Inactive
Collaborator
Commit: f4d2d5a
37 interesting tests: 14 RECOVERED, 12 flaky, 10 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Feb 17, 2026
pietern
left a comment
Contributor
There was a problem hiding this comment.
Unblocking merge.
But you'll need to wait for the SDK bump to merge first because this conflicts.
Alternatively, you can change the base branch for this PR.
Uh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Feb 18, 2026
## Changes <!-- Brief summary of your changes that is easy to understand --> 1. Updating Go SDK to v0.106.0 2. Refactoring Go SDK Config Workspace`Id` to Workspace`ID` Note: This PR doesn't include the changes for CLI specific WorkspaceId eg in AuthArguments, those are done in: #4532 ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Best practice to use `ID` ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
denik pushed a commit
that referenced
this pull request
May 20, 2026
) ## Changes <!-- Brief summary of your changes that is easy to understand --> - Rename WorkspaceId to WorkspaceID across CLI-owned struct fields, parameters, and local variables to follow idiomatic Go naming conventions (acronyms should be all caps) - Fix a pre-existing typo in runlocal.NewConfig parameter name (workpaceId → workspaceID, which was missing an r in "workspace") - This is a follow-up to #4486 which renamed the upstream SDK field; this PR covers the CLI's own types: AuthArguments, Profile, Workspace, and runlocal.Config ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Best practice to use Workspace`ID` ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes <!-- Brief summary of your changes that is easy to understand --> 1. Updating Go SDK to v0.106.0 2. Refactoring Go SDK Config Workspace`Id` to Workspace`ID` Note: This PR doesn't include the changes for CLI specific WorkspaceId eg in AuthArguments, those are done in: #4532 ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Best practice to use `ID` ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Best practice to use Workspace
IDTests
Existing tests