Uh oh!
There was an error while loading. Please reload this page.
Upgrade Go SDK to v0.106.0 - #4486
Conversation
Commit: 530430e
15 interesting tests: 7 KNOWN, 7 SKIP, 1 flaky
Top 20 slowest tests (at least 2 minutes):
|
Uh oh!
There was an error while loading. Please reload this page.
pietern
left a comment
There was a problem hiding this comment.
Please include the SDK version in the PR title.
| github.event_name == 'workflow_dispatch' || | ||
| github.repository == 'databricks/databricks-sdk-go' || | ||
| github.repository == 'databricks/databricks-sdk-py' || | ||
| github.repository == 'databricks/databricks-sdk-java' |
There was a problem hiding this comment.
Please revert this. We don't want to auto-release.
There was a problem hiding this comment.
This was generated automatically, will revert
There was a problem hiding this comment.
Re-opening since we are discussing to keep this change as it's no-op cc: @renaudhartert-db
There was a problem hiding this comment.
Ack, OK let's keep it. I see that this repo is excluded via the condition.
cc @simonfaltum
Uh oh!
There was an error while loading. Please reload this page.
| github.event_name == 'workflow_dispatch' || | ||
| github.repository == 'databricks/databricks-sdk-go' || | ||
| github.repository == 'databricks/databricks-sdk-py' || | ||
| github.repository == 'databricks/databricks-sdk-java' |
There was a problem hiding this comment.
Ack, OK let's keep it. I see that this repo is excluded via the condition.
cc @simonfaltum
## Changes <!-- Brief summary of your changes that is easy to understand --> 1. Updating Go SDK to v0.106.0 2. Refactoring Go SDK Config Workspace`Id` to Workspace`ID` Note: This PR doesn't include the changes for CLI specific WorkspaceId eg in AuthArguments, those would be done in separate PR to keep this PR specific to Go SDK bump. The other PR would be created once this is merged. ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Best practice to use `ID` ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
Uh oh!
There was an error while loading. Please reload this page.
) ## Changes <!-- Brief summary of your changes that is easy to understand --> - Rename WorkspaceId to WorkspaceID across CLI-owned struct fields, parameters, and local variables to follow idiomatic Go naming conventions (acronyms should be all caps) - Fix a pre-existing typo in runlocal.NewConfig parameter name (workpaceId → workspaceID, which was missing an r in "workspace") - This is a follow-up to #4486 which renamed the upstream SDK field; this PR covers the CLI's own types: AuthArguments, Profile, Workspace, and runlocal.Config ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Best practice to use Workspace`ID` ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
Uh oh!
There was an error while loading. Please reload this page.
## Release v0.289.0 ### CLI * Make auth profiles respect DATABRICKS_CLI_PATH env var (([#4467](#4467))) * Fix arrow key navigation in prompts on Windows (([#4501](#4501))) ### Bundles * Log artifact build output in debug mode ([#4208](#4208)) * Fix bundle init not working in Azure Government ([#4286](#4286)) * Allow single and double quotes in environment dependencies (([#4511](#4511))) * Use purge option when deleting alerts (([#4505](#4505))) * engine/direct: Replace server_side_default with more precise backend_default rule in bundle plan ([#4490](#4490)) * engine/direct: Extend pipelines recreate_on_changes configuration (([#4499](#4499))) * engine/direct: Added support for UC external locations (direct only) ([#4484](#4484)) ### Dependency updates * Upgrade Go SDK to v0.106.0 (([#4486](#4486))) * Upgrade Terraform provider to v1.106.0 (([#4542](#4542))) * Upgrade Go to 1.25.7 (([#4547](#4547)))
) ## Changes <!-- Brief summary of your changes that is easy to understand --> - Rename WorkspaceId to WorkspaceID across CLI-owned struct fields, parameters, and local variables to follow idiomatic Go naming conventions (acronyms should be all caps) - Fix a pre-existing typo in runlocal.NewConfig parameter name (workpaceId → workspaceID, which was missing an r in "workspace") - This is a follow-up to #4486 which renamed the upstream SDK field; this PR covers the CLI's own types: AuthArguments, Profile, Workspace, and runlocal.Config ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Best practice to use Workspace`ID` ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
## Changes <!-- Brief summary of your changes that is easy to understand --> 1. Updating Go SDK to v0.106.0 2. Refactoring Go SDK Config Workspace`Id` to Workspace`ID` Note: This PR doesn't include the changes for CLI specific WorkspaceId eg in AuthArguments, those are done in: #4532 ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Best practice to use `ID` ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
## Release v0.289.0 ### CLI * Make auth profiles respect DATABRICKS_CLI_PATH env var (([#4467](#4467))) * Fix arrow key navigation in prompts on Windows (([#4501](#4501))) ### Bundles * Log artifact build output in debug mode ([#4208](#4208)) * Fix bundle init not working in Azure Government ([#4286](#4286)) * Allow single and double quotes in environment dependencies (([#4511](#4511))) * Use purge option when deleting alerts (([#4505](#4505))) * engine/direct: Replace server_side_default with more precise backend_default rule in bundle plan ([#4490](#4490)) * engine/direct: Extend pipelines recreate_on_changes configuration (([#4499](#4499))) * engine/direct: Added support for UC external locations (direct only) ([#4484](#4484)) ### Dependency updates * Upgrade Go SDK to v0.106.0 (([#4486](#4486))) * Upgrade Terraform provider to v1.106.0 (([#4542](#4542))) * Upgrade Go to 1.25.7 (([#4547](#4547)))
Changes
Idto WorkspaceIDNote: This PR doesn't include the changes for CLI specific WorkspaceId eg in AuthArguments, those are done in: #4532
Why
Best practice to use
IDTests
Existing tests