Uh oh!
There was an error while loading. Please reload this page.
Upgrade Go SDK to v0.110.0 - #4552
Merged
Merged
Conversation
Bump databricks-sdk-go and the OpenAPI SHA to the latest release and regenerate CLI/API outputs. Apply targeted post-generate fixes for lint/test drift, including schema overrides cleanup, direct resource updates, and refschema/python generated output sync. Co-authored-by: Cursor <cursoragent@cursor.com>
simonfaltum
requested review from
a team, andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersFebruary 19, 2026 12:54
simonfaltumtemporarily deployed
to
test-trigger-is
February 19, 2026 12:54 — with 
GitHub Actions
Inactive
simonfaltum
marked this pull request as draft
February 19, 2026 12:54
Collaborator
Commit: 234d1c3
19 interesting tests: 7 KNOWN, 7 SKIP, 4 flaky, 1 RECOVERED
Top 30 slowest tests (at least 2 minutes):
|
Refresh acceptance golden outputs to match generated command help text after upgrading to Go SDK v0.110.0, including the new apps --space flag and updated deprecation copy. Co-authored-by: Cursor <cursoragent@cursor.com>
simonfaltumtemporarily deployed
to
test-trigger-is
February 19, 2026 13:32 — with GitHub Actions
Inactive
Normalize generated endpoint command help text formatting so repository whitespace checks pass in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
simonfaltum
marked this pull request as ready for review
February 19, 2026 14:23
simonfaltumtemporarily deployed
to
test-trigger-is
February 19, 2026 14:23 — with GitHub Actions
Inactive
simonfaltumtemporarily deployed
to
test-trigger-is
February 19, 2026 21:24 — with GitHub Actions
Inactive
andrewnester
approved these changes
Feb 20, 2026
eng-dev-ecosystem-bot
commented
Feb 20, 2026
Collaborator
Commit: 2ddc930
29 interesting tests: 16 KNOWN, 8 RECOVERED, 3 FAIL, 1 SKIP, 1 flaky
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Feb 26, 2026
## Release v0.290.0 ### CLI * Add `completion install`, `uninstall`, and `status` subcommands ([#4581](#4581)) * Wire profile name through CLI ToOAuthArgument for profile-based cache keys ([#4562](#4562)) * Add host disambiguation and positional profile support to auth token ([#4574](#4574)) * Update error messages to suggest 'databricks auth login' ([#4587](#4587)) * Resolve --host to matching profile for token cache lookup ([#4591](#4591)) * Improve auth token UX: profile selection and better empty-state handling ([#4584(#4584) ### Bundles * Added support for git_source and git_repository for Apps ([#4538](#4538)) ### Dependency updates * Upgrade TF provider to 1.109.0 ([#4561](#4561)) * Upgrade Go SDK to v0.110.0 ([#4552](#4552)) ### API Changes * Bump databricks-sdk-go from v0.111.0 to v0.112.0.
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes 1. Update `github.com/databricks/databricks-sdk-go` from `v0.106.0` to `v0.110.0` and bump `.codegen/_openapi_sha` to the matching OpenAPI commit. 2. Run canonical generation (`make generate`) and sync generated outputs across commands, schemas, direct resources, and Python bundle bindings. 3. Apply targeted post-generate fixes for lint/test drift (external location/postgres struct updates, quality monitor staticcheck annotations, duplicate schema override cleanup, refschema golden update). ## Why Keep CLI generated surfaces aligned with the latest Go SDK/OpenAPI changes and ensure generation remains green on lint/tests. ## Tests - [x] `./tools/golangci-lint run` - [x] `go test ./internal/build ./bundle/internal/schema ./bundle/direct/dresources ./bundle/config/resources -count=1` - [x] `go test ./acceptance -run '^TestAccept/bundle/refschema$' -update -timeout=30m` (run twice) - [x] `go test ./acceptance -run '^TestAccept/bundle/refschema$' -timeout=30m` - [x] `pushd python && make codegen && popd` Made with [Cursor](https://cursor.com) --------- Co-authored-by: Cursor <cursoragent@cursor.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.290.0 ### CLI * Add `completion install`, `uninstall`, and `status` subcommands ([#4581](#4581)) * Wire profile name through CLI ToOAuthArgument for profile-based cache keys ([#4562](#4562)) * Add host disambiguation and positional profile support to auth token ([#4574](#4574)) * Update error messages to suggest 'databricks auth login' ([#4587](#4587)) * Resolve --host to matching profile for token cache lookup ([#4591](#4591)) * Improve auth token UX: profile selection and better empty-state handling ([#4584(#4584) ### Bundles * Added support for git_source and git_repository for Apps ([#4538](#4538)) ### Dependency updates * Upgrade TF provider to 1.109.0 ([#4561](#4561)) * Upgrade Go SDK to v0.110.0 ([#4552](#4552)) ### API Changes * Bump databricks-sdk-go from v0.111.0 to v0.112.0.
bradleyjamrozik-origindigital pushed a commit
to Origin-Digital-LLC/databricks-cli
that referenced
this pull request
Jul 6, 2026
## Summary `catalog.SseEncryptionDetailsAlgorithm` published a duplicated `enum` in the generated bundle JSON schema: ```json "enum": ["AWS_SSE_S3", "AWS_SSE_KMS", "AWS_SSE_KMS", "AWS_SSE_S3"] ``` JSON Schema requires enum values to be unique, so strict validators (e.g. OPA) reject the entire schema at compile time. The duplicate has shipped since v0.290.0 (Feb 26 2026); the issue reports it "since v0.299.1" only because that is the first release where `jsonschema.json` was published as a downloadable release asset, so it is the earliest version an external consumer could inspect. Fixesdatabricks#5713. ## Root cause The enum was **hand-authored** for `catalog.SseEncryptionDetailsAlgorithm` in databricks#4484 (UC external locations, Feb 18 2026), in the hand-authored override annotation file, with order `[AWS_SSE_KMS, AWS_SSE_S3]`. At that point the SDK-derived annotations did not define this type, so the generated schema had the correct **2** entries. Two days later, databricks#4552 (Upgrade Go SDK to v0.110.0, Feb 20 2026) regenerated the SDK-derived annotation file, which now defined the same enum with order `[AWS_SSE_S3, AWS_SSE_KMS]`. From then on **both** annotation sources supplied the enum. The annotation merge concatenates sequences, so the two pairs combined into four entries — `[S3, KMS]` (SDK, merge base) followed by `[KMS, S3]` (override), producing `[S3, KMS, KMS, S3]`. The later consolidation of the annotation files into a single `annotations.yml` + `.codegen/cli.json` (databricks#5484 / databricks#5574) preserved this pre-existing duplicate rather than causing it; only the file names changed. `annotations.yml` is **not** generated from `cli.json` — `./task generate-schema` only syncs descriptions and placeholders and drops stale entries; it never rewrites hand-authored enums. So the redundant entry persisted silently across the refactor. ## Fix - Remove the redundant hand-authored `enum` from `annotations.yml`, leaving `cli.json` (SDK-derived) as the single source of truth. The `description` override there is intentional (it differs from cli.json's text) and is kept. - Regenerate `bundle/schema/jsonschema.json`; the enum is now `["AWS_SSE_S3", "AWS_SSE_KMS"]`. - Add `TestJsonSchemaEnumsAreUnique`, a whole-schema guard that walks every `enum` in the embedded schema and fails on any duplicate, so this class of bug cannot return regardless of source. ## Tests - `go test ./bundle/internal/schema ./bundle/schema -count=1` - Verified the new guard fails on the pre-fix schema, reporting the exact path `$defs/.../catalog.SseEncryptionDetailsAlgorithm/oneOf[0]`. - Confirmed the regenerated schema is reproducible via the schema generator. This pull request and its description were written by Isaac, an AI coding agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
github.com/databricks/databricks-sdk-gofromv0.106.0tov0.110.0and bump.codegen/_openapi_shato the matching OpenAPI commit.make generate) and sync generated outputs across commands, schemas, direct resources, and Python bundle bindings.Why
Keep CLI generated surfaces aligned with the latest Go SDK/OpenAPI changes and ensure generation remains green on lint/tests.
Tests
./tools/golangci-lint rungo test ./internal/build ./bundle/internal/schema ./bundle/direct/dresources ./bundle/config/resources -count=1go test ./acceptance -run '^TestAccept/bundle/refschema$' -update -timeout=30m(run twice)go test ./acceptance -run '^TestAccept/bundle/refschema$' -timeout=30mpushd python && make codegen && popdMade with Cursor