Uh oh!
There was an error while loading. Please reload this page.
Added support for UC external locations (direct mode only) - #4484
Merged
Conversation
andrewnester
requested review from
anton-107, denik, pietern and shreyas-goenka
as code ownersFebruary 10, 2026 11:27
andrewnestertemporarily deployed
to
test-trigger-is
February 10, 2026 11:27 — with 
GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
February 10, 2026 12:23 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
February 10, 2026 12:32 — with GitHub Actions
Inactive
Collaborator
Commit: 758c064
14 interesting tests: 6 FAIL, 6 SKIP, 1 KNOWN, 1 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
andrewnestertemporarily deployed
to
test-trigger-is
February 10, 2026 13:12 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
February 10, 2026 13:48 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
February 10, 2026 20:16 — with GitHub Actions
Inactive
denik
reviewed
Feb 11, 2026
denik
left a comment
Contributor
There was a problem hiding this comment.
Can you add config for invariant tests in acceptance/bundle/invariant?
Uh oh!
There was an error while loading. Please reload this page.
denik
reviewed
Feb 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
| - field: storage_root | ||
| reason: immutable | ||
| external_locations: |
Contributor
There was a problem hiding this comment.
question - were you able to run 'make generate-direct' to update resources.generated.yml
ContributorAuthor
There was a problem hiding this comment.
nope, it failed actually with
Traceback (most recent call last):
File "/Users/andrew.nester/cli/bundle/direct/tools/generate_resources.py", line 12, in <module>
import yaml
ModuleNotFoundError: No module named 'yaml'
which seems to be unrelated
Uh oh!
There was an error while loading. Please reload this page.
andrewnestertemporarily deployed
to
test-trigger-is
February 11, 2026 13:12 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
February 11, 2026 13:14 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
February 11, 2026 13:15 — with GitHub Actions
Inactive
| "custom_tags": | ||
| "description": |- | ||
| PLACEHOLDER | ||
| github.com/databricks/databricks-sdk-go/service/catalog.AwsSqsQueue: |
Contributor
There was a problem hiding this comment.
These descriptions should automatically be generated during the next CLI bump. Worth keeping an eye on because those descriptions will auto-generate our public documentation.
shreyas-goenka
approved these changes
Feb 16, 2026
shreyas-goenka
left a comment
Contributor
There was a problem hiding this comment.
Thanks, lgtm except one concern. Can you please TAL whether we can get test coverage for this on some cloud as well. Otherwise this can be fragile.
| } | ||
| func (e *ExternalLocation) GetURL() string { | ||
| // Return empty as external locations don't have a workspace URL |
Contributor
There was a problem hiding this comment.
optional: Can we still return the revelant s3 URL? Or any UI equivalent we have for the resource. This provides a nice experience when running bundle summary.
| Local = true | ||
| # External locations require actual storage credentials with cloud IAM setup | ||
| # which are environment-specific, so we only test locally with the mock server | ||
| Cloud = false |
Contributor
There was a problem hiding this comment.
Should we atleast run these tests on one cloud? Like just AWS maybe?
| # which are environment-specific, so we only test locally with the mock server | ||
| Cloud = false | ||
| RecordRequests = false | ||
| RequiresUnityCatalog = true |
Contributor
There was a problem hiding this comment.
optional: You can also set RunsOnDbr = true no to run these tests on DBR. It's opt-in for now.
andrewnestertemporarily deployed
to
test-trigger-is
February 18, 2026 10:41 — with GitHub Actions
Inactive
denik
reviewed
Feb 18, 2026
| bundle: | ||
| name: test-bundle-$UNIQUE_NAME | ||
| resources: |
Contributor
There was a problem hiding this comment.
There needs to be an entry in invariant/test.toml for this to be picked up.
andrewnestertemporarily deployed
to
test-trigger-is
February 18, 2026 11:01 — with GitHub Actions
Inactive
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Feb 18, 2026
Collaborator
Commit: 7b4bac8
34 interesting tests: 16 KNOWN, 8 RECOVERED, 5 FAIL, 4 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Feb 19, 2026
## Release v0.289.0 ### CLI * Make auth profiles respect DATABRICKS_CLI_PATH env var (([#4467](#4467))) * Fix arrow key navigation in prompts on Windows (([#4501](#4501))) ### Bundles * Log artifact build output in debug mode ([#4208](#4208)) * Fix bundle init not working in Azure Government ([#4286](#4286)) * Allow single and double quotes in environment dependencies (([#4511](#4511))) * Use purge option when deleting alerts (([#4505](#4505))) * engine/direct: Replace server_side_default with more precise backend_default rule in bundle plan ([#4490](#4490)) * engine/direct: Extend pipelines recreate_on_changes configuration (([#4499](#4499))) * engine/direct: Added support for UC external locations (direct only) ([#4484](#4484)) ### Dependency updates * Upgrade Go SDK to v0.106.0 (([#4486](#4486))) * Upgrade Terraform provider to v1.106.0 (([#4542](#4542))) * Upgrade Go to 1.25.7 (([#4547](#4547)))
green2k
commented
Apr 7, 2026
Hi, is there a plan for adding support for UC Storage Credentials as well? |
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Added support for UC external locations (direct mode only) ## Why This is a natural extension of support for UC catalogs where UC catalogs can have references to UC external locations. ## Tests Added an acceptance test <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.289.0 ### CLI * Make auth profiles respect DATABRICKS_CLI_PATH env var (([#4467](#4467))) * Fix arrow key navigation in prompts on Windows (([#4501](#4501))) ### Bundles * Log artifact build output in debug mode ([#4208](#4208)) * Fix bundle init not working in Azure Government ([#4286](#4286)) * Allow single and double quotes in environment dependencies (([#4511](#4511))) * Use purge option when deleting alerts (([#4505](#4505))) * engine/direct: Replace server_side_default with more precise backend_default rule in bundle plan ([#4490](#4490)) * engine/direct: Extend pipelines recreate_on_changes configuration (([#4499](#4499))) * engine/direct: Added support for UC external locations (direct only) ([#4484](#4484)) ### Dependency updates * Upgrade Go SDK to v0.106.0 (([#4486](#4486))) * Upgrade Terraform provider to v1.106.0 (([#4542](#4542))) * Upgrade Go to 1.25.7 (([#4547](#4547)))
bradleyjamrozik-origindigital pushed a commit
to Origin-Digital-LLC/databricks-cli
that referenced
this pull request
Jul 6, 2026
## Summary `catalog.SseEncryptionDetailsAlgorithm` published a duplicated `enum` in the generated bundle JSON schema: ```json "enum": ["AWS_SSE_S3", "AWS_SSE_KMS", "AWS_SSE_KMS", "AWS_SSE_S3"] ``` JSON Schema requires enum values to be unique, so strict validators (e.g. OPA) reject the entire schema at compile time. The duplicate has shipped since v0.290.0 (Feb 26 2026); the issue reports it "since v0.299.1" only because that is the first release where `jsonschema.json` was published as a downloadable release asset, so it is the earliest version an external consumer could inspect. Fixesdatabricks#5713. ## Root cause The enum was **hand-authored** for `catalog.SseEncryptionDetailsAlgorithm` in databricks#4484 (UC external locations, Feb 18 2026), in the hand-authored override annotation file, with order `[AWS_SSE_KMS, AWS_SSE_S3]`. At that point the SDK-derived annotations did not define this type, so the generated schema had the correct **2** entries. Two days later, databricks#4552 (Upgrade Go SDK to v0.110.0, Feb 20 2026) regenerated the SDK-derived annotation file, which now defined the same enum with order `[AWS_SSE_S3, AWS_SSE_KMS]`. From then on **both** annotation sources supplied the enum. The annotation merge concatenates sequences, so the two pairs combined into four entries — `[S3, KMS]` (SDK, merge base) followed by `[KMS, S3]` (override), producing `[S3, KMS, KMS, S3]`. The later consolidation of the annotation files into a single `annotations.yml` + `.codegen/cli.json` (databricks#5484 / databricks#5574) preserved this pre-existing duplicate rather than causing it; only the file names changed. `annotations.yml` is **not** generated from `cli.json` — `./task generate-schema` only syncs descriptions and placeholders and drops stale entries; it never rewrites hand-authored enums. So the redundant entry persisted silently across the refactor. ## Fix - Remove the redundant hand-authored `enum` from `annotations.yml`, leaving `cli.json` (SDK-derived) as the single source of truth. The `description` override there is intentional (it differs from cli.json's text) and is kept. - Regenerate `bundle/schema/jsonschema.json`; the enum is now `["AWS_SSE_S3", "AWS_SSE_KMS"]`. - Add `TestJsonSchemaEnumsAreUnique`, a whole-schema guard that walks every `enum` in the embedded schema and fails on any duplicate, so this class of bug cannot return regardless of source. ## Tests - `go test ./bundle/internal/schema ./bundle/schema -count=1` - Verified the new guard fails on the pre-fix schema, reporting the exact path `$defs/.../catalog.SseEncryptionDetailsAlgorithm/oneOf[0]`. - Confirmed the regenerated schema is reproducible via the schema generator. This pull request and its description were written by Isaac, an AI coding agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added support for UC external locations (direct mode only)
Why
This is a natural extension of support for UC catalogs where UC catalogs can have references to UC external locations.
Tests
Added an acceptance test