Uh oh!
There was an error while loading. Please reload this page.
Remove Slow tests - #5032
Merged
Merged
Conversation
The Slow flag was used to skip local acceptance tests in -short mode. Remove the flag, the selftest for it, the Makefile targets, and strip it from the one test that used it. Co-authored-by: Isaac
Now that the Slow config feature is gone, -short has no effect on local acceptance tests. Unit tests in this repo don't use testing.Short() either. Co-authored-by: Isaac
denik
enabled auto-merge
April 20, 2026 14:38
pietern
approved these changes
Apr 20, 2026
Uh oh!
There was an error while loading. Please reload this page.
denik added a commit
that referenced
this pull request
Apr 21, 2026
Mirrors main's e24ae4e (Remove Slow tests #5032): drop test:slow, test:slow-unit, test:slow-acc, and the `-short` flag from test:unit and test:acc. Slow tests support in the acceptance runner was removed because the split between short and fast tests adds complexity and makes it possible to miss failures. Co-authored-by: Isaac
denik added a commit
that referenced
this pull request
Apr 28, 2026
Mirrors main's e24ae4e (Remove Slow tests #5032): drop test:slow, test:slow-unit, test:slow-acc, and the `-short` flag from test:unit and test:acc. Slow tests support in the acceptance runner was removed because the split between short and fast tests adds complexity and makes it possible to miss failures. Co-authored-by: Isaac
denik added a commit
that referenced
this pull request
Apr 29, 2026
Mirrors main's e24ae4e (Remove Slow tests #5032): drop test:slow, test:slow-unit, test:slow-acc, and the `-short` flag from test:unit and test:acc. Slow tests support in the acceptance runner was removed because the split between short and fast tests adds complexity and makes it possible to miss failures. Co-authored-by: Isaac
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Remove Slow tests support from acceptance test runner, Makefile. - The only test that was using it is upload/timeout - this will be updated to be faster [in separate PR.](#5040) ## Why Split between short and fast tests adds complexity to Makefile and makes it possible to miss failures. Better strategy is not to have slow tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Split between short and fast tests adds complexity to Makefile and makes it possible to miss failures. Better strategy is not to have slow tests.