Uh oh!
There was an error while loading. Please reload this page.
bundle: add DATABRICKS_BUNDLE_HTTP_TIMEOUT_SECONDS; prop context to WorkspaceClient - #5040
Merged
Conversation
Merged
pietern
reviewed
Apr 20, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Allows overriding the HTTP timeout for bundle operations. The acceptance test for upload timeout now uses a 5s timeout instead of 90s, reducing test runtime from ~2 minutes to ~6 seconds. Co-authored-by: Isaac
Move DATABRICKS_BUNDLE_HTTP_TIMEOUT_SECONDS to bundle/env package alongside other bundle env vars, and use libs/env.Lookup(ctx, ...) instead of os.Getenv so tests can override it via context. Plumb context.Context through Config, Client, WorkspaceClientE, WorkspaceClient, and ClearWorkspaceClient. Co-authored-by: Isaac
denikforce-pushed
the
denik/fix-python-test
branch
from
April 20, 2026 15:51
6aa87d0 to
e9704deCompareCo-authored-by: Isaac
Co-authored-by: Isaac
pietern
approved these changes
Apr 20, 2026
denik
enabled auto-merge
April 21, 2026 06:50
does not affect test time --- PASS: TestAccept/bundle/upload/timeout (0.00s) --- PASS: TestAccept/bundle/upload/timeout/DATABRICKS_BUNDLE_ENGINE=terraform (5.57s) --- PASS: TestAccept/bundle/upload/timeout/DATABRICKS_BUNDLE_ENGINE=direct (5.57s)
Uh oh!
There was an error while loading. Please reload this page.
varundeepsaini pushed a commit
to varundeepsaini/cli
that referenced
this pull request
Apr 21, 2026
## Changes - Remove Slow tests support from acceptance test runner, Makefile. - The only test that was using it is upload/timeout - this will be updated to be faster [in separate PR.](databricks#5040) ## Why Split between short and fast tests adds complexity to Makefile and makes it possible to miss failures. Better strategy is not to have slow tests.
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Remove Slow tests support from acceptance test runner, Makefile. - The only test that was using it is upload/timeout - this will be updated to be faster [in separate PR.](#5040) ## Why Split between short and fast tests adds complexity to Makefile and makes it possible to miss failures. Better strategy is not to have slow tests.
denik added a commit
that referenced
this pull request
May 20, 2026
…orkspaceClient (#5040) Allows overriding the HTTP timeout for bundle operations. The acceptance test for upload timeout now uses a 5s timeout instead of 90s, reducing test runtime from ~2 minutes to ~6 seconds. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows overriding the HTTP timeout for bundle operations. The acceptance test for upload timeout now uses a 5s timeout instead of 90s, reducing test runtime from ~2 minutes to ~6 seconds.
Co-authored-by: Isaac