Uh oh!
There was an error while loading. Please reload this page.
Remove non-functional hidden alias flags from bundle generate - #5591
Merged
Conversation
The hidden --existing-dashboard-id, --existing-dashboard-path, --existing-alert-id, and --existing-genie-space-id flags aliased the canonical --existing-id/--existing-path flags by binding the same variable, but were never included in the cobra requirement wiring (MarkFlagsOneRequired / MarkFlagRequired). Cobra validates those groups on the named flags' Changed state, so alias-only invocations always failed flag validation. The aliases never worked in any release; with this change an alias invocation gets cobra's honest 'unknown flag' error instead of a misleading requirement-group error. Co-authored-by: Isaac
Co-authored-by: Isaac
janniklasrosetemporarily deployed
to
test-trigger-is
June 12, 2026 20:41 — with 
GitHub Actions
Inactive
janniklasrosetemporarily deployed
to
test-trigger-is
June 12, 2026 20:41 — with GitHub Actions
Inactive
eng-dev-ecosystem-bot
commented
Jun 12, 2026
Collaborator
Integration test reportCommit: ee2d333
28 interesting tests: 15 SKIP, 7 KNOWN, 6 flaky
Top 26 slowest tests (at least 2 minutes):
|
janniklasrose
requested review from
andrewnester, denik, pietern and shreyas-goenkaJune 15, 2026 07:58
andrewnester
approved these changes
Jun 15, 2026
eng-dev-ecosystem-bot
commented
Jun 15, 2026
Collaborator
Integration test reportCommit: 89ba40b
534 interesting tests: 457 MISS, 46 FAIL, 21 RECOVERED, 4 flaky, 3 PANIC, 2 SKIP, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jun 17, 2026
## Release v1.4.0 ### CLI * Improved error messages for `ssh connect`: when an SSH connection attempt fails, the client now fetches and prints the server's recent error logs ([#5555](#5555)). * Increase the SSH server startup timeout from 10 to 45 minutes when a GPU accelerator is requested via `databricks ssh connect --accelerator` ([#5569](#5569)). * Fix authentication falling back to the default profile in `.databrickscfg` when a host is already configured via the environment (e.g. `DATABRICKS_HOST` with `DATABRICKS_TOKEN`) ([#5616](#5616)). * ssh: fix opening remote environment in Cursor, which previously hung on default-extension install and never opened the editor ([#5619](#5619)). * Improve the error shown when `databricks labs install` cannot find a project's `labs.yml`: the message now explains that either the requested version does not exist or the project is not installable with the CLI, and links to the repository ([#5559](#5559)). ### Bundles * Remove API enum values and types that are still in development from the `databricks-bundles` Python package; these were never accepted by the backend ([#5484](#5484)). * direct: Fix resolving a resource reference that is used more than once within the same field ([#5558](#5558)). * Bundle variable references now accept Unicode letters in path segments (e.g. `${var.变量}`). ([#5532](#5532)) * Ignore remote changes for vector search direct_access_index_spec.schema_json to prevent drift when the backend normalizes the schema ([#5481](#5481)). * Remove hidden, never-functional `--existing-dashboard-id`, `--existing-dashboard-path`, `--existing-alert-id`, and `--existing-genie-space-id` alias flags from `bundle generate`; use the documented `--existing-id` / `--existing-path` flags instead ([#5591](#5591)). * engine/direct: Fix WAL corruption after two consecutive failed deploys ([#5606](#5606)). * engine/direct: Don't open the deployment state WAL when a deploy's plan fails ([#5607](#5607)). * Ignore unity catalog managed schema property defaults to avoid unnecessary drift ([#5195](#5195)). * Add `postgres_roles` and `postgres_databases` resources to create Postgres roles and databases on a Lakebase branch ([#5467](#5467), [#5627](#5627)). * direct: Stop spurious recreate/rename on redeploy when the backend normalizes a resource's name-based ID (e.g. Unity Catalog lowercasing a schema or volume name) ([#5599](#5599)). * Fix the generated pipeline README to suggest `databricks bundle run <pipeline> --refresh <table>` for running a single transformation; the previously documented `--select` flag is not supported by `bundle run` ([#5252](#5252)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove the hidden
--existing-dashboard-id,--existing-dashboard-path,--existing-alert-id, and--existing-genie-space-idalias flags frombundle generate dashboard|alert|genie-space. These aliased the canonical--existing-id/--existing-pathflags by registering a second flag bound to the same variable ("included for symmetry with the other generate commands"), but they were never wired into the cobra requirement groups (MarkFlagsOneRequired/MarkFlagRequired). Cobra validates those groups on the named flags'Changedstate, so an alias-only invocation always failed flag validation before reaching the command:The aliases were broken from the commit that introduced each of them (#1847 for dashboard, #4108 for alert, #5282 for genie-space), are hidden from help output, and are referenced nowhere in docs, examples, or tests — no working invocation ever depended on them. With this change, passing one yields cobra's
unknown flagerror plus usage listing the canonical flags, instead of the misleading requirement-group error.The canonical long-form flags of the other generate commands (
--existing-job-id,--existing-pipeline-id,--existing-app-name) are unaffected.Tests
unknown flag; canonical--existing-id/--existing-pathinvocations still pass flag validation.go test ./cmd/bundle/generate/...andgo test ./acceptance -run TestAccept/bundle/generatepass with no golden output changes (hidden flags never appeared in help output).This pull request and its description were written by Isaac, an AI coding agent.