Uh oh!
There was an error while loading. Please reload this page.
experimental/ssh: fix Cursor remote IDE hang on default-extension install - #5619
Merged
Conversation
…tall `databricks ssh connect --ide cursor` seeded the same `remote.SSH.defaultExtensions` list for both IDEs (ms-python.python, ms-toolsai.jupyter, databricks.databricks). On the remote, Cursor's marketplace silently remaps ms-python.python -> anysphere.python (and Pylance -> anysphere.cursorpyright), forming a circular dependency that hangs the auto-install indefinitely. The remote editor never finishes loading. VS Code does no such remap and is unaffected, matching the reported asymmetry. Make the default-extension list per-IDE: VS Code keeps all three; Cursor seeds only databricks.databricks, so it is not forced through the broken auto-install (Cursor ships its own Python/Jupyter stack anyway). Also pass `--classic` on the Cursor launch: Cursor 3.x defaults new windows to the "Agents Window", which swallows the `--remote` request and never opens the remote editor. `--classic` forces a classic editor window so the remote workspace actually opens. Jira: DECO-27339 Co-authored-by: Isaac
Jira: DECO-27339 Co-authored-by: Isaac
Collaborator
Integration test reportCommit: bd2dff8
22 interesting tests: 15 SKIP, 7 KNOWN
Top 25 slowest tests (at least 2 minutes):
|
rugpanov
commented
Jun 16, 2026
Contributor
Two questions, First, one thing worth deciding before merge: the fix only changes what the CLI seeds, not what is already present. getMissingExtensions checks whether the required set (now just databricks.databricks for Cursor) is present and never removes entries, so a user who ran an earlier CLI build — exactly the population that hit DECO-27339 — still has ms-python.python (and Pylance) in their Cursor remote.SSH.defaultExtensions. The new code will neither detect nor strip them. Result: the remote auto-install still hangs for these users until they manually edit settings.json. Since Cursor uses a separate settings file from VS Code (different AppName), this is specifically Cursor users who previously ran ssh connect --ide cursor. Worth deciding: either actively remove the remapped extensions from Cursor's defaultExtensions when present, or at minimum call out the manual remediation in the changelog/PR. As written, the headline ("fix opening remote environment in Cursor") overpromises for already-affected users. Second, is --classic safely ignored by older Cursor versions, or could it be misparsed as a path/positional arg and break the launch? VS Code/Electron CLIs usually ignore unknown flags, so this is probably fine, but since the minimum supported Cursor here is 1.0.32 (MinSSHExtensionVersion), it'd be good to confirm --classic doesn't error on a sub-3.x Cursor that still passes the extension check. |
…settings Addresses review feedback: the seed-only fix did not help users who ran an earlier CLI build and already have ms-python.python / ms-toolsai.jupyter in their Cursor remote.SSH.defaultExtensions — their remote install kept hanging until they hand-edited settings.json. Add IncompatibleExtensions to the IDE descriptor (Cursor: ms-python.python, ms-toolsai.jupyter). validateSettings now also reports stale entries, and updateSettings rebuilds defaultExtensions to drop them (replacing the array rather than index-based removes to avoid shifting indices). VS Code is unaffected (empty incompatible list). New tests cover detection, stripping, and combined strip+add. Jira: DECO-27339 Co-authored-by: Isaac
anton-107
commented
Jun 16, 2026
ContributorAuthor
Thanks @rugpanov — both good catches. Addressed in 138e684. 1. Already-affected users (stale 2. Is So a sub-3.x Cursor that still passes the |
Uh oh!
There was an error while loading. Please reload this page.
rugpanov
approved these changes
Jun 16, 2026
anton-107
enabled auto-merge
June 16, 2026 15:21
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Jun 16, 2026
Collaborator
Integration test reportCommit: 7ea729e
580 interesting tests: 529 MISS, 43 FAIL, 3 KNOWN, 3 PANIC, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jun 17, 2026
## Release v1.4.0 ### CLI * Improved error messages for `ssh connect`: when an SSH connection attempt fails, the client now fetches and prints the server's recent error logs ([#5555](#5555)). * Increase the SSH server startup timeout from 10 to 45 minutes when a GPU accelerator is requested via `databricks ssh connect --accelerator` ([#5569](#5569)). * Fix authentication falling back to the default profile in `.databrickscfg` when a host is already configured via the environment (e.g. `DATABRICKS_HOST` with `DATABRICKS_TOKEN`) ([#5616](#5616)). * ssh: fix opening remote environment in Cursor, which previously hung on default-extension install and never opened the editor ([#5619](#5619)). * Improve the error shown when `databricks labs install` cannot find a project's `labs.yml`: the message now explains that either the requested version does not exist or the project is not installable with the CLI, and links to the repository ([#5559](#5559)). ### Bundles * Remove API enum values and types that are still in development from the `databricks-bundles` Python package; these were never accepted by the backend ([#5484](#5484)). * direct: Fix resolving a resource reference that is used more than once within the same field ([#5558](#5558)). * Bundle variable references now accept Unicode letters in path segments (e.g. `${var.变量}`). ([#5532](#5532)) * Ignore remote changes for vector search direct_access_index_spec.schema_json to prevent drift when the backend normalizes the schema ([#5481](#5481)). * Remove hidden, never-functional `--existing-dashboard-id`, `--existing-dashboard-path`, `--existing-alert-id`, and `--existing-genie-space-id` alias flags from `bundle generate`; use the documented `--existing-id` / `--existing-path` flags instead ([#5591](#5591)). * engine/direct: Fix WAL corruption after two consecutive failed deploys ([#5606](#5606)). * engine/direct: Don't open the deployment state WAL when a deploy's plan fails ([#5607](#5607)). * Ignore unity catalog managed schema property defaults to avoid unnecessary drift ([#5195](#5195)). * Add `postgres_roles` and `postgres_databases` resources to create Postgres roles and databases on a Lakebase branch ([#5467](#5467), [#5627](#5627)). * direct: Stop spurious recreate/rename on redeploy when the backend normalizes a resource's name-based ID (e.g. Unity Catalog lowercasing a schema or volume name) ([#5599](#5599)). * Fix the generated pipeline README to suggest `databricks bundle run <pipeline> --refresh <table>` for running a single transformation; the previously documented `--select` flag is not supported by `bundle run` ([#5252](#5252)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
databricks ssh connect --ide cursorhangs while installing the default extensions on the remote, so the Cursor editor view never loads. VS Code is unaffected. (Jira: DECO-27339)Root cause
The CLI seeds the same
remote.SSH.defaultExtensionslist for both IDEs —ms-python.python,ms-toolsai.jupyter,databricks.databricks. On the remote, Cursor's marketplace silently remapsms-python.python→anysphere.python(and Pylance →anysphere.cursorpyright), which forms a circular dependency and hangs the auto-install indefinitely (confirmed on the remote:~/.cursor-server/extensions/stays empty, install process stuck). VS Code does no such remap, matching the reported asymmetry.Changes
run.go,settings.go): addDefaultExtensionsto the IDE descriptor and thread the IDE throughvalidateSettings/getMissingExtensions/handleMissingFile/GetManualInstructions. VS Code keeps all three; Cursor seeds onlydatabricks.databricksso it is not forced through the broken auto-install (Cursor ships its own Python/Jupyter stack).run.go,settings.go): addIncompatibleExtensionsto the IDE descriptor (Cursor:ms-python.python,ms-toolsai.jupyter).validateSettingsnow reports such entries already present inremote.SSH.defaultExtensions, andupdateSettingsrebuilds the array to drop them — so users who ran an earlier CLI build are auto-healed on their next connect instead of staying stuck. VS Code is unaffected (empty incompatible list).--classicon Cursor launch (run.go): Cursor 3.x defaults new windows to the "Agents Window", which swallows the--remoterequest and never opens the remote editor. Adding--classic(Cursor-only) forces a classic editor window so the remote workspace opens. VS Code's launch is unchanged.settings_test.go(Cursor vs VS Code lists, stale-extension detection/stripping).Testing
go test ./experimental/ssh/internal/vscode/passes.ms-python.pythoninstall and the editor never loaded; after, the remote server is launched with only--install-extension databricks.databricks, the editor view opens, and the hang is gone.Validation (review follow-ups)
1. Stale-extension stripping — verified with the real repro. Pre-seeded a Cursor
settings.jsonwith the old list["ms-python.python", "ms-toolsai.jupyter", "databricks.databricks"](simulating a user who ran an earlier CLI build), then ran the actualssh connect --ide cursor -p dogfood --auto-approve. The CLI rewrotedefaultExtensionsto["databricks.databricks"]— the two remapped extensions were stripped — and added the new connection to the port/platform maps, confirming the settings-update path ran. The strip happens early (before the serverless cluster starts), so already-affected users are healed on their next connect.2.
--classicis safe on older Cursor — verified on an actual pre-3.x build. Downloaded Cursor 2.4.37 (Feb 2026, before the Glass/Agents architecture and the--classicflag) and ran its CLI directly:So on a real older Cursor,
--classicis a harmless no-op (warning + ignored, exit 0); it does not error and is never misparsed as a positional path.--classicis also placed before the--remote/path args, so it can't be confused with the workspace path.