Uh oh!
There was an error while loading. Please reload this page.
direct: fix persistent drift on model_serving_endpoints - #5708
Merged
Conversation
The backend always returns a defaulted config.traffic_config (100% to the served entity) even when the user does not specify one. #5693 dropped the suppression for it (and for budget_policy_id) assuming the new missing-in-remote auto-skip covered them, but both are present in RemoteType so the auto-skip never fires, and the direct engine reported a permanent update after every clean deploy. Suppress config.traffic_config as a backend_default (skip only when the user leaves it empty; real drift is still detected if it is set) and keep budget_policy_id under ignore_remote_changes (GET never echoes it). Make Changes.HasChange skip-aware so a suppressed-only change under a section no longer triggers a spurious section update (e.g. PUT /config on an unrelated email/tags update). Teach the testserver to default traffic_config like the backend so the running-endpoint acceptance test reproduces the drift locally. Co-authored-by: Isaac
Co-authored-by: Isaac
denik
commented
Jun 24, 2026
Contributor
how did you find this? |
denik
reviewed
Jun 24, 2026
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
Integration test reportCommit: 2f4d909
30 interesting tests: 13 SKIP, 9 flaky, 7 KNOWN, 1 RECOVERED
Top 4 slowest tests (at least 2 minutes):
|
HasChange counted suppressed (Action == Skip) changes, so a section whose only change was suppressed (backend_default, ignore_remote_changes, remote_already_set, etc.) still reported a change and triggered a spurious sub-section update API call in DoUpdate. Skip suppressed changes, matching HasChangeExcept. All six call sites (model_serving_endpoint, vector_search_endpoint) gate a per-section update on HasChange, so ignoring suppressed changes is strictly more correct. Split out of #5708 with a dedicated regression test. Co-authored-by: Isaac
denik
approved these changes
Jun 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
pietern
enabled auto-merge
June 29, 2026 09:52
Uh oh!
There was an error while loading. Please reload this page.
bradleyjamrozik-origindigital pushed a commit
to Origin-Digital-LLC/databricks-cli
that referenced
this pull request
Jun 29, 2026
Split out of databricks#5708 per review feedback, with a dedicated regression test. `Changes.HasChange` counted suppressed changes (`Action == Skip`), so a section whose only change was suppressed — `backend_default`, `ignore_remote_changes`, `remote_already_set`, `empty`, `missing_in_remote`, etc. — still reported a change. In `model_serving_endpoint` and `vector_search_endpoint` `DoUpdate`, this triggered a spurious per-section update API call (e.g. a `PUT /config` for a `traffic_config` default the user never set). `HasChange` now skips suppressed changes, matching the already skip-aware `HasChangeExcept`. All six `HasChange` call sites gate a per-section update in `DoUpdate`: ``` bundle/direct/dresources/model_serving_endpoint.go (tags, ai_gateway, config, email_notifications) bundle/direct/dresources/vector_search_endpoint.go (budget_policy_id, target_qps) ``` In every case the call exists to push a real change to that section, so ignoring suppressed changes is strictly more correct. The other call sites denik listed (`bind.go`, `app.go`, `cluster.go`, `sql_warehouse.go`) use `HasChangeExcept` or the `Action`-based `HasChanges` field, both of which already filter `Skip`. Added `TestHasChange` covering the skip-aware behavior and path-boundary matching. This pull request and its description were written by Isaac.
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jul 2, 2026
## Release v1.6.0 ### CLI * `ssh connect` now accepts a `--base-environment` flag to run a serverless session on a custom base environment. It takes an `env.yaml` path, a `workspace-base-environments/...` resource ID, or a base environment display name, and is rejected together with `--environment-version` or `--cluster` ([#5706](#5706)). * `databricks aitools install` is now plugin-first: it installs the Databricks plugin through each agent's own CLI (Claude Code, Codex, GitHub Copilot) instead of copying raw skill files. Agents without a plugin (OpenCode, Antigravity) still get skill files, and Cursor prints the `/add-plugin databricks` step. Use `--skills-only` to force raw skill files for every agent, or `--path <dir>` to write skills to a directory ([#5738](#5738)). * `databricks labs list` now only shows projects that can be installed ([#5560](#5560)). ### Bundles * direct: Fixed persistent drift on `model_serving_endpoints` caused by the `traffic_config` field ([#5708](#5708)). * direct: Fix spurious update when `apply_policy_default_values: true` is set on job task, for-each-task, or job cluster new_cluster ([#5731](#5731)). Also fix spurious updates for for-each-task clusters due to missing backend defaults for `data_security_mode`, `node_type_id`, `driver_node_type_id`, `driver_instance_pool_id`, `enable_elastic_disk`, and `enable_local_disk_encryption`. * direct: Cluster resize now falls back to regular update if resize fails due to `INVALID_STATE` ([#5716](#5716)). * `bundle generate dashboard` now honors the `--key` flag when naming the generated resource, and rejects combining `--existing-path`, `--existing-id`, and `--resource` instead of silently ignoring all but one ([#5492](#5492)). * Fixed `bundle deployment migrate` failing on `model_serving_endpoints`/`database_instances` with permissions (regression since v1.5.0) ([#5775](#5775)). * After a terraform deploy, the CLI now dry-runs a migration to the direct engine (writing nothing locally or remotely) and reports the outcome via telemetry, warning if the migration could not be completed ([#5797](#5797)). ### Dependency updates * Bump `github.com/databricks/databricks-sdk-go` from v0.147.0 to v0.152.0 ([#5773](#5773)). * Bump Terraform provider from v1.118.0 to v1.120.0 ([#5792](#5792)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Restore suppression of the backend-defaulted
config.traffic_config(as abackend_default) andbudget_policy_id(ignore_remote_changes) onmodel_serving_endpoints, and teach the testserver to defaulttraffic_configlike the backend so the drift is covered locally. Builds on #5764, which makesChanges.HasChangeskip-aware (merged into this branch).Why
The backend always returns a defaulted
config.traffic_config(100% to the served entity) even when the user specifies none. #5693 dropped theignore_remote_changesentries fortraffic_configandbudget_policy_id, assuming the new "skip fields missing from RemoteType" auto-skip covered them — but both fields are present inRemoteType, so the auto-skip never fires and the direct engine reported a permanentupdateafter every clean deploy.traffic_configis a true backend default the user may also set, sobackend_default(skip only when the local value is empty; real drift still detected when set) is the right tool rather thanignore_remote_changes.budget_policy_idis never echoed by GET, so it stays underignore_remote_changes.Making the testserver faithful surfaced a latent over-update:
HasChangecounted skipped changes, so the suppressedtraffic_configtriggered a spuriousPUT /configon unrelated updates. That fix lives in #5764 (skip-awareHasChange), which is merged into this branch — please merge #5764 first.Tests
running-endpointnow reproduces the drift locally (fails without the fix). Passes on both engines on real cloud (aws-prod-ucws). Full./task test/fmt/lint/checkspass.This PR and its description were written by Isaac.