Uh oh!
There was an error while loading. Please reload this page.
direct: fix apply_policy_default_values drift and for_each_task cluster gaps - #5731
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 2effe19
23 interesting tests: 13 SKIP, 8 KNOWN, 1 FAIL, 1 flaky
Top 3 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Jun 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
The Jobs API accepts apply_policy_default_values in create/update
requests but does not return it in GET responses. The plan engine saw
old=true, new=true, remote=nil and incorrectly scheduled an update.
Fix: add ignore_remote_changes entries with reason not_returned_by_api
for apply_policy_default_values in tasks[*].new_cluster,
tasks[*].for_each_task.task.new_cluster, and job_clusters[*].new_cluster.
Also fill a pre-existing gap: for_each_task inner clusters were missing
backend_defaults entries for enable_elastic_disk, enable_local_disk_encryption,
node_type_id, driver_node_type_id, driver_instance_pool_id, and data_security_mode
(all present for tasks[*].new_cluster and job_clusters[*].new_cluster but not
for the for_each_task path), and ignore_remote_changes for {aws,azure,gcp}_attributes.
Add invariant no_drift test configs for all four affected paths:
- tasks[*].new_cluster.apply_policy_default_values
- tasks[*].for_each_task.task.new_cluster.apply_policy_default_values
- job_clusters[*].new_cluster.apply_policy_default_values
- pipelines.clusters[*].apply_policy_default_values
Update testserver to clear apply_policy_default_values from GET responses,
matching real API behaviour.
Co-authored-by: IsaacCo-authored-by: Isaac
denikforce-pushed
the
denik/job-clusters-apply_policy_default_values
branch
from
June 29, 2026 14:10
cf95dd8 to
2effe19CompareUh oh!
There was an error while loading. Please reload this page.
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jul 2, 2026
## Release v1.6.0 ### CLI * `ssh connect` now accepts a `--base-environment` flag to run a serverless session on a custom base environment. It takes an `env.yaml` path, a `workspace-base-environments/...` resource ID, or a base environment display name, and is rejected together with `--environment-version` or `--cluster` ([#5706](#5706)). * `databricks aitools install` is now plugin-first: it installs the Databricks plugin through each agent's own CLI (Claude Code, Codex, GitHub Copilot) instead of copying raw skill files. Agents without a plugin (OpenCode, Antigravity) still get skill files, and Cursor prints the `/add-plugin databricks` step. Use `--skills-only` to force raw skill files for every agent, or `--path <dir>` to write skills to a directory ([#5738](#5738)). * `databricks labs list` now only shows projects that can be installed ([#5560](#5560)). ### Bundles * direct: Fixed persistent drift on `model_serving_endpoints` caused by the `traffic_config` field ([#5708](#5708)). * direct: Fix spurious update when `apply_policy_default_values: true` is set on job task, for-each-task, or job cluster new_cluster ([#5731](#5731)). Also fix spurious updates for for-each-task clusters due to missing backend defaults for `data_security_mode`, `node_type_id`, `driver_node_type_id`, `driver_instance_pool_id`, `enable_elastic_disk`, and `enable_local_disk_encryption`. * direct: Cluster resize now falls back to regular update if resize fails due to `INVALID_STATE` ([#5716](#5716)). * `bundle generate dashboard` now honors the `--key` flag when naming the generated resource, and rejects combining `--existing-path`, `--existing-id`, and `--resource` instead of silently ignoring all but one ([#5492](#5492)). * Fixed `bundle deployment migrate` failing on `model_serving_endpoints`/`database_instances` with permissions (regression since v1.5.0) ([#5775](#5775)). * After a terraform deploy, the CLI now dry-runs a migration to the direct engine (writing nothing locally or remotely) and reports the outcome via telemetry, warning if the migration could not be completed ([#5797](#5797)). ### Dependency updates * Bump `github.com/databricks/databricks-sdk-go` from v0.147.0 to v0.152.0 ([#5773](#5773)). * Bump Terraform provider from v1.118.0 to v1.120.0 ([#5792](#5792)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #5693 (which fixed standalone clusters): fix
apply_policy_default_valuesdrift for job cluster paths (#5179 (comment)).The Jobs API accepts
apply_policy_default_valuesbut does not return it in GET responses. Addignore_remote_changeswithreason: not_returned_by_apifortasks[*].new_cluster,tasks[*].for_each_task.task.new_cluster, andjob_clusters[*].new_cluster.Also fill a pre-existing gap:
for_each_taskinner clusters were missingbackend_defaults(enable_elastic_disk,enable_local_disk_encryption,node_type_id,driver_node_type_id,driver_instance_pool_id,data_security_mode) andignore_remote_changes({aws,azure,gcp}_attributes) that already existed for the other cluster paths.Note, pipeline clusters do not have this issue for some reason.
Tests
New invariant
no_driftconfigs for all four relevant paths. Testserver updated to clearapply_policy_default_valuesfrom GET responses, matching real API behavior.