Skip to content

Integrate JiT compilation into CLI runtime - #2184

Closed
rafal-hawrylak wants to merge 3 commits into
mainfrom
pr4b-jit-runtime
Closed

Integrate JiT compilation into CLI runtime#2184
rafal-hawrylak wants to merge 3 commits into
mainfrom
pr4b-jit-runtime

Conversation

@rafal-hawrylak

@rafal-hawrylakrafal-hawrylak commented May 28, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Part of #2110 - [Integrate JiT compilation into CLI]

@rafal-hawrylak
rafal-hawrylak requested a review from a team as a code ownerMay 28, 2026 05:32
@rafal-hawrylak
rafal-hawrylak requested review from krushangSk17 and removed request for a teamMay 28, 2026 05:32
@rafal-hawrylakrafal-hawrylak mentioned this pull request May 28, 2026
Closed
@rafal-hawrylak
rafal-hawrylak removed the request for review from krushangSk17May 28, 2026 09:35
@rafal-hawrylak
rafal-hawrylakforce-pushed the pr4b-jit-runtime branch 3 times, most recently from 72e576f to f9c7136CompareMay 28, 2026 13:44
ikholopov-omni
ikholopov-omni requested changes Jun 3, 2026
View reviewed changes
Comment threadcli/api/commands/run.ts Outdated
Comment threadcli/api/commands/run.ts Outdated
Comment threadcli/api/commands/run.ts
Comment threadcli/api/commands/run.ts Outdated
Comment threadcli/api/commands/run.ts
Comment threadcli/api/commands/run.ts Outdated
Comment threadcli/api/commands/run.ts
Comment threadcli/vm/jit_worker.ts
} else {
callback(null, res.response);

// Guard against double-initialization in some environments (e.g. Bazel)

@ikholopov-omniikholopov-omniJun 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please avoid these hacks and keep initialization idempotent, please?

@rafal-hawrylakrafal-hawrylakJun 19, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address it here: #2211. Not addressed yet.

Comment threadcli/index.ts
@rafal-hawrylak
Proto field additions for JiT flow
e2d053d
@rafal-hawrylak
Integrate JiT compilation into CLI runtime
d50fdc1
@rafal-hawrylak
Refactor Runner parameter overloads and resolve review comments
fe57a91
- Extract handleParamsOverloads to a standalone function outside Runner.
- Add static factory methods Runner.create() and Runner.resume().
- Add overloaded constructor signatures to Runner to preserve backwards compatibility.
- Ensure the options parsing uses spread defaults instead of conditional assignments.
- Restructure cancel to accept typed CancelReason instead of raw strings.
- Refactor the complex ternary SKIPPED tasks mapping into an explicit if/else block.
- Extract task generation logic from compileJitAction to createTasksFromJitResponse.
- Resolve worker script path in jit_loader.js using __dirname relative resolution.
- Convert database request Uint8Array responses to arrays in compiler.ts before IPC transmission.
@rafal-hawrylak
rafal-hawrylak deleted the pr4b-jit-runtime branch June 19, 2026 19:03
This was referenced Jun 19, 2026
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikholopov-omniikholopov-omniikholopov-omni requested changes
@apilaskowskiapilaskowskiAwaiting requested review from apilaskowski

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rafal-hawrylak@ikholopov-omni