Uh oh!
There was an error while loading. Please reload this page.
Integrate JiT compilation into CLI runtime - #2211
Merged
Merged
Conversation
rafal-hawrylak
commented
Jun 19, 2026
CollaboratorAuthor
Need to address: #2184 (comment) |
rafal-hawrylakforce-pushed
the
pr4c-jit-runtime
branch
from
June 22, 2026 09:26
ab6f700 to
bf38a43CompareCollaboratorAuthor
Solved in: |
rafal-hawrylakforce-pushed
the
pr4c-jit-runtime
branch
3 times, most recently
from
July 2, 2026 09:30
e6932c7 to
fbe3490Comparerafal-hawrylakforce-pushed
the
pr4c-jit-runtime
branch
from
July 6, 2026 12:43
fbe3490 to
05bf715Comparerafal-hawrylakforce-pushed
the
pr4c-jit-runtime
branch
3 times, most recently
from
July 15, 2026 11:55
bf7fa50 to
654a9b1Comparerafal-hawrylakforce-pushed
the
pr4c-jit-runtime
branch
from
July 15, 2026 12:06
654a9b1 to
0437180Compareikholopov-omni
requested changes
Jul 15, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rafal-hawrylakforce-pushed
the
pr4c-jit-runtime
branch
2 times, most recently
from
July 16, 2026 05:34
289c1c2 to
60be915Comparerafal-hawrylak
requested review from
apilaskowski and ikholopov-omni
and removed request for
udimJuly 16, 2026 05:39
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- base_worker: drop redundant undefined guard around clearTimeout
(clearTimeout(undefined) is a documented no-op). Restore
runWorker's timeoutMillis to a required number and drop the
conditional setTimeout — matches main's contract; the earlier
loosening to number|undefined let JiT workers run without any
timeout when --jit-timeout was omitted.
- jit/compiler.ts: default timeoutMillis to
DEFAULT_COMPILATION_TIMEOUT_MILLIS at the .compile() entry point
(mirrors CompileChildProcess.compile), so JiT workers always
have a timeout even without --jit-timeout.
- build.ts: replace unsafe (action as any).jitCode cast with a
narrowing "jitCode" in action check.
- run.ts: flatten the outer try/catch that only wrapped the JiT-compile
try; the JiT-compile block already has its own try/catch. Extract the
action.tableType -> dataform.TableType mapping into tableTypeEnum.
Use \${e?.message || String(e)} when formatting a JiT compilation
error so an error thrown without a .message field still surfaces
something readable rather than "undefined".
- constants.ts: revert DEFAULT_COMPILATION_TIMEOUT_MILLIS to 60000
(main's value); the per-JiT timeout is configurable via
--jit-timeout.
- compiler.ts: keep the Array.from(response) conversion (child.send
uses JSON IPC by default, which serializes Uint8Array as
{"0":n,...} and Buffer.from() rejects that) but add a comment
documenting the constraint.
- BUILD: order load statements alphabetically to satisfy the
buildifier out-of-order-load lint.
- testing/test.ts: revert DEFAULT_TIMEOUT_MILLIS from 300000 back to
30000. The bump was unintended and would silently extend every
test's per-case timeout to 5 minutes.Each JiT compile registered a cancel handler on the Runner's EventEmitter but never removed it once the compile finished. A run with N JiT actions therefore accumulated N stale listeners and eventually tripped the default MaxListenersExceededWarning threshold. Register the handler through a local variable and remove it in a finally block so successful and failed compiles both clean up. Also drops a stray trailing-whitespace line from the dryRun compiledSql branch (comment #2).
rafal-hawrylakforce-pushed
the
pr4c-jit-runtime
branch
from
July 22, 2026 20:08
2453010 to
2f7328cCompareapilaskowski
approved these changes
Jul 23, 2026
apilaskowski
left a comment
Collaborator
There was a problem hiding this comment.
Lets also wait for review by @ikholopov-omni
ikholopov-omni
approved these changes
Aug 5, 2026
Uh oh!
There was an error while loading. Please reload this page.
rafal-hawrylak added a commit
that referenced
this pull request
Aug 25, 2026
…2256) Fixes#2247. PR #2211 (JiT integration) silently changed --timeout from compile-only to a whole-run wall-clock deadline, causing existing runs to exit 1 with no output after the previously-effective compile duration. - Restore --timeout to compile-only (matches 3.0.63 semantics and describe text). - Add --execution-timeout (off by default) for the whole-run deadline. - On TIMED_OUT/CANCELLED, print a top-level reason line so exit 1 is no longer silent; propagate the cancel reason to per-action SKIPPED lines. - When --timeout is passed without --execution-timeout, print an advisory notice pointing at the new flag (JSON output unaffected).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2184 with extracted refactorings.