fix: feedback panel — one variant at a time, correct interaction flow - #2
Merged
devyanijain merged 5 commits intoAug 30, 2026
Conversation
devyanijain
commented
Aug 30, 2026
Owner
- All three boxes start hidden on load
- Panel is display:block so boxes never render side by side
- Edit opens on 'Log some words'; View opens on submitted dot click; Confirm replaces Edit on Submit
- Panel fills viewport height between padding so edit form scrolls internally
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd
…ents Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd
…ck panel - Three-section layout: topContent 40vh / middleContent 20vh / bottomContent 40vh - Design tokens: Space Mono (headings) + Space Grotesk (body), dark palette (bg-primary #000, bg-secondary #1F1F1F, bg-tertiary #3D3D3D) - Dull dot fills: fg-yellow-dull, fg-blue-dull, fg-green-dull, fg-red-dull, fg-purple-dull - Submitted dots: radial gradient + glow, clickable; default dots: dull, pointer-events none - Color groups: yellow/teal (top) | green/red/purple (bottom) - Feedback panel: fixed right, slides in — Edit / View / Confirmation variants - Edit: actionBar (Feedback title + X), contentBar (form), footerBar (Submit) - View: actionBar (X), contentBar (read-only fields), footerBar (◀ ▶ arrows) - Confirmation: actionBar (Thank you! + X), contentBar (planted message), footerBar (Edit / Done) - Phosphor icons inline SVG: X, ArrowBendUpRight, ArrowCircleLeft, ArrowCircleRight - 'More' scroll hint on Edit contentBar; bottom-sheet layout on mobile Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Added hidden to editVariant on page load so all three boxes start hidden
- Switched panel from display:flex to display:block so boxes don't render side by side
- Added .feedback-box[hidden] { display:none !important } as belt-and-suspenders
- Panel fills full height between padding-lg top and bottom
- Feedback box fills 100% panel height so edit form scrolls internally
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949…' into devyanijain-golden-seeds-redesign # Conflicts: # index.html # style.css
devyanijain added a commit
that referenced
this pull request
Aug 31, 2026
* feat: Golden Github Seeds redesign (#1) * Block search engine indexing (noindex meta + robots.txt) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd * Redesign: framed card layout with sticky identity column and pill accents Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd * feat: Golden Github Seeds redesign — full-viewport dot field + feedback panel - Three-section layout: topContent 40vh / middleContent 20vh / bottomContent 40vh - Design tokens: Space Mono (headings) + Space Grotesk (body), dark palette (bg-primary #000, bg-secondary #1F1F1F, bg-tertiary #3D3D3D) - Dull dot fills: fg-yellow-dull, fg-blue-dull, fg-green-dull, fg-red-dull, fg-purple-dull - Submitted dots: radial gradient + glow, clickable; default dots: dull, pointer-events none - Color groups: yellow/teal (top) | green/red/purple (bottom) - Feedback panel: fixed right, slides in — Edit / View / Confirmation variants - Edit: actionBar (Feedback title + X), contentBar (form), footerBar (Submit) - View: actionBar (X), contentBar (read-only fields), footerBar (◀ ▶ arrows) - Confirmation: actionBar (Thank you! + X), contentBar (planted message), footerBar (Edit / Done) - Phosphor icons inline SVG: X, ArrowBendUpRight, ArrowCircleLeft, ArrowCircleRight - 'More' scroll hint on Edit contentBar; bottom-sheet layout on mobile Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Devyani Jain <devyanijain0@gmail.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd * fix: feedback panel — one variant at a time, correct interaction flow (#2) * Block search engine indexing (noindex meta + robots.txt) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd * Redesign: framed card layout with sticky identity column and pill accents Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd * feat: Golden Github Seeds redesign — full-viewport dot field + feedback panel - Three-section layout: topContent 40vh / middleContent 20vh / bottomContent 40vh - Design tokens: Space Mono (headings) + Space Grotesk (body), dark palette (bg-primary #000, bg-secondary #1F1F1F, bg-tertiary #3D3D3D) - Dull dot fills: fg-yellow-dull, fg-blue-dull, fg-green-dull, fg-red-dull, fg-purple-dull - Submitted dots: radial gradient + glow, clickable; default dots: dull, pointer-events none - Color groups: yellow/teal (top) | green/red/purple (bottom) - Feedback panel: fixed right, slides in — Edit / View / Confirmation variants - Edit: actionBar (Feedback title + X), contentBar (form), footerBar (Submit) - View: actionBar (X), contentBar (read-only fields), footerBar (◀ ▶ arrows) - Confirmation: actionBar (Thank you! + X), contentBar (planted message), footerBar (Edit / Done) - Phosphor icons inline SVG: X, ArrowBendUpRight, ArrowCircleLeft, ArrowCircleRight - 'More' scroll hint on Edit contentBar; bottom-sheet layout on mobile Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix: only one feedback variant visible at a time - Added hidden to editVariant on page load so all three boxes start hidden - Switched panel from display:flex to display:block so boxes don't render side by side - Added .feedback-box[hidden] { display:none !important } as belt-and-suspenders - Panel fills full height between padding-lg top and bottom - Feedback box fills 100% panel height so edit form scrolls internally Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 --------- Co-authored-by: Devyani Jain <devyanijain0@gmail.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * View feedback variant polish (#3) * Block search engine indexing (noindex meta + robots.txt) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd * Redesign: framed card layout with sticky identity column and pill accents Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd * feat: Golden Github Seeds redesign — full-viewport dot field + feedback panel - Three-section layout: topContent 40vh / middleContent 20vh / bottomContent 40vh - Design tokens: Space Mono (headings) + Space Grotesk (body), dark palette (bg-primary #000, bg-secondary #1F1F1F, bg-tertiary #3D3D3D) - Dull dot fills: fg-yellow-dull, fg-blue-dull, fg-green-dull, fg-red-dull, fg-purple-dull - Submitted dots: radial gradient + glow, clickable; default dots: dull, pointer-events none - Color groups: yellow/teal (top) | green/red/purple (bottom) - Feedback panel: fixed right, slides in — Edit / View / Confirmation variants - Edit: actionBar (Feedback title + X), contentBar (form), footerBar (Submit) - View: actionBar (X), contentBar (read-only fields), footerBar (◀ ▶ arrows) - Confirmation: actionBar (Thank you! + X), contentBar (planted message), footerBar (Edit / Done) - Phosphor icons inline SVG: X, ArrowBendUpRight, ArrowCircleLeft, ArrowCircleRight - 'More' scroll hint on Edit contentBar; bottom-sheet layout on mobile Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix: only one feedback variant visible at a time - Added hidden to editVariant on page load so all three boxes start hidden - Switched panel from display:flex to display:block so boxes don't render side by side - Added .feedback-box[hidden] { display:none !important } as belt-and-suspenders - Panel fills full height between padding-lg top and bottom - Feedback box fills 100% panel height so edit form scrolls internally Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Add custom relationship dropdown (CSS + JS, position:fixed to escape overflow) - Custom select CSS: trigger, list (position:fixed), options, hover/selected states - JS: open/close, option selection, keyboard nav, fixed positioning via getBoundingClientRect - Closes when contentBar scrolls or click outside - Default value: Manager Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Rename relationship labels Manager → Manager/PM Peer → Colleague Cross-functional Partner → Team/Engineer Mentor → SF office buddy Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Fix custom dropdown trigger visibility — explicit button reset CSS - custom-select__trigger now self-contained (no input-field__input class) - Explicit appearance, background, border, font, height, padding resets - Prevents browser UA stylesheet from overriding custom styles Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Update improvement label to third person Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Restore native select for relationship field - Removes custom dropdown HTML, JS entirely - Native <select> with existing styling - contentBar gets 120px padding-bottom so OS popup opens downward Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Fix focus border clipped by overflow:hidden — use border not outline Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Polish: photos, validation, copy, error tokens, Go Back button - Add 9 photo images for More and Confirmation panel circles - Add fg-red-bright token (#FF4444) for error states - Make all form fields required with live error clearing - Format phone input as (XXX)-XXX-XXXX - Update Go Back button to primary with back arrow - Apply final More panel copy (experience + Kusama) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Polish view feedback variant: typography, quote box, role label - Remove all-caps/letter-spacing from .view-label (caption style) - Remove fill from .feedback-quote-box (border only) - Update Role label to 'Role at Github' Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 --------- Co-authored-by: Devyani Jain <devyanijain0@gmail.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * View feedback variant polish + clear placeholder data (#4) * Block search engine indexing (noindex meta + robots.txt) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd * Redesign: framed card layout with sticky identity column and pill accents Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd * feat: Golden Github Seeds redesign — full-viewport dot field + feedback panel - Three-section layout: topContent 40vh / middleContent 20vh / bottomContent 40vh - Design tokens: Space Mono (headings) + Space Grotesk (body), dark palette (bg-primary #000, bg-secondary #1F1F1F, bg-tertiary #3D3D3D) - Dull dot fills: fg-yellow-dull, fg-blue-dull, fg-green-dull, fg-red-dull, fg-purple-dull - Submitted dots: radial gradient + glow, clickable; default dots: dull, pointer-events none - Color groups: yellow/teal (top) | green/red/purple (bottom) - Feedback panel: fixed right, slides in — Edit / View / Confirmation variants - Edit: actionBar (Feedback title + X), contentBar (form), footerBar (Submit) - View: actionBar (X), contentBar (read-only fields), footerBar (◀ ▶ arrows) - Confirmation: actionBar (Thank you! + X), contentBar (planted message), footerBar (Edit / Done) - Phosphor icons inline SVG: X, ArrowBendUpRight, ArrowCircleLeft, ArrowCircleRight - 'More' scroll hint on Edit contentBar; bottom-sheet layout on mobile Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix: only one feedback variant visible at a time - Added hidden to editVariant on page load so all three boxes start hidden - Switched panel from display:flex to display:block so boxes don't render side by side - Added .feedback-box[hidden] { display:none !important } as belt-and-suspenders - Panel fills full height between padding-lg top and bottom - Feedback box fills 100% panel height so edit form scrolls internally Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Add custom relationship dropdown (CSS + JS, position:fixed to escape overflow) - Custom select CSS: trigger, list (position:fixed), options, hover/selected states - JS: open/close, option selection, keyboard nav, fixed positioning via getBoundingClientRect - Closes when contentBar scrolls or click outside - Default value: Manager Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Rename relationship labels Manager → Manager/PM Peer → Colleague Cross-functional Partner → Team/Engineer Mentor → SF office buddy Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Fix custom dropdown trigger visibility — explicit button reset CSS - custom-select__trigger now self-contained (no input-field__input class) - Explicit appearance, background, border, font, height, padding resets - Prevents browser UA stylesheet from overriding custom styles Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Update improvement label to third person Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Restore native select for relationship field - Removes custom dropdown HTML, JS entirely - Native <select> with existing styling - contentBar gets 120px padding-bottom so OS popup opens downward Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Fix focus border clipped by overflow:hidden — use border not outline Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Polish: photos, validation, copy, error tokens, Go Back button - Add 9 photo images for More and Confirmation panel circles - Add fg-red-bright token (#FF4444) for error states - Make all form fields required with live error clearing - Format phone input as (XXX)-XXX-XXXX - Update Go Back button to primary with back arrow - Apply final More panel copy (experience + Kusama) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Polish view feedback variant: typography, quote box, role label - Remove all-caps/letter-spacing from .view-label (caption style) - Remove fill from .feedback-quote-box (border only) - Update Role label to 'Role at Github' Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Remove all placeholder submitted dot feedback data Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 * Fix double-brace syntax error in dots array Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 --------- Co-authored-by: Devyani Jain <devyanijain0@gmail.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949 --------- Co-authored-by: Devyani Jain <devyanijain0@gmail.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fa4d7950-6a6a-44a9-81e7-0c6a5bf388dd Copilot-Session: 67835f2f-e65f-4a86-90ea-ae38169a7949
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.