Skip to content

fix: feedback panel — one variant at a time, correct interaction flow#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devyanijain merged 5 commits into from
Aug 30, 2026
Merged

fix: feedback panel — one variant at a time, correct interaction flow #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
38d8fb4
Block search engine indexing (noindex meta + robots.txt)
devyanixjain Aug 1, 2026
0a63c88
Redesign: framed card layout with sticky identity column and pill acc…
devyanixjain Aug 1, 2026
3c9e2a1
feat: Golden Github Seeds redesign — full-viewport dot field + feedba…
devyanixjain Aug 30, 2026
2c4b859
fix: only one feedback variant visible at a time
devyanixjain Aug 30, 2026
a1151e7
Merge remote-tracking branch 'origin/devyanijain-build-portfolio-site…
devyanixjain Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,7 +57,7 @@ <h1 class="h1">Golden Github Seeds</h1>
<aside class="feedback-panel" id="feedbackPanel" aria-label="Feedback" aria-hidden="true">

<!-- ── EDIT VARIANT ── -->
<div class="feedback-box" id="editVariant" role="dialog" aria-modal="true" aria-labelledby="editTitle">
<div class="feedback-box" id="editVariant" role="dialog" aria-modal="true" aria-labelledby="editTitle" hidden>
<div class="actionBar actionBar--bordered">
<h3 class="h3" id="editTitle">Feedback</h3>
<button class="icon-btn" id="closeEditBtn" aria-label="Close">
Expand Down
42 changes: 22 additions & 20 deletions style.css
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -237,39 +237,41 @@ button { font-family: inherit; cursor: pointer; }
FEEDBACK PANEL
==================================================================== */
.feedback-panel {
position: fixed;
top: var(--padding-lg);
right: var(--padding-lg);
width: var(--panel-w);
max-height: calc(100vh - var(--padding-lg) * 2);
display: flex;
align-items: flex-start;
z-index: 200;
/* hidden off-screen by default */
transform: translateX(calc(100% + var(--padding-lg)));
position: fixed;
top: var(--padding-lg);
bottom: var(--padding-lg);
right: var(--padding-lg);
width: var(--panel-w);
/* stack children; only one is ever visible at a time */
display: block;
z-index: 200;
transform: translateX(calc(100% + var(--padding-lg)));
transition: transform 0.35s var(--ease);
pointer-events: none;
}

.feedback-panel.is-open {
transform: translateX(0);
transform: translateX(0);
pointer-events: all;
}

/* ====================================================================
FEEDBACK BOX (shared shell)
==================================================================== */
.feedback-box {
width: 100%;
max-height: calc(100vh - var(--padding-lg) * 2);
background: var(--bg-secondary);
border: 4px solid var(--bg-tertiary);
border-radius: var(--radii-md);
display: flex;
width: 100%;
height: 100%;
background: var(--bg-secondary);
border: 4px solid var(--bg-tertiary);
border-radius: var(--radii-md);
display: flex;
flex-direction: column;
overflow: hidden;
overflow: hidden;
}

/* hide the [hidden] boxes — belt-and-suspenders */
.feedback-box[hidden] { display: none !important; }

/* ── Action Bar ── */
.actionBar {
flex: none;
Expand DownExpand Up@@ -409,10 +411,10 @@ button { font-family: inherit; cursor: pointer; }
bottom: 0;
left: 0;
width: 100%;
max-height: 88vh;
height: 88vh;
padding: var(--padding-md);
transform: translateY(100%);
align-items: flex-end;
display: block;
}

.feedback-panel.is-open { transform: translateY(0); }
Expand Down