Uh oh!
There was an error while loading. Please reload this page.
refactor: migrate Boost.Python syntax to nanobind - #89
Conversation
chore: updated pre-commit hook dependencies
…nd libdiffpy_version
SYMSCAE
commented
Jul 14, 2026
@sbillinge Please see if this is what we want. |
@SYMSCAE This PR is still failing. I suspect it is because we haven't updated the dependencies for this package ( |
sbillinge
commented
Jul 25, 2026
Migration work in those repos is on |
sbillinge
commented
Aug 5, 2026
@SYMSCAE@stevenhua0320 we need to merge this to move the 3D PDF calculator forward. Please can we work on getting the dependency issue resolved so we can move forward? This is a bit urgent. |
stevenhua0320
commented
Aug 5, 2026
@SYMSCAE Let's first work on |
SYMSCAE
commented
Aug 5, 2026
Hi Steven, I believe we don’t need to touch pyobjcryst. The only change in upstream library is libdiffpy, which is requiring a new conda release. After that we should be good to pass rest of the tests. |
joeseaer
commented
Aug 25, 2026
Hi @SYMSCAE@stevenhua0320@sbillinge, I have opened diffpy/libdiffpy#50, which ports Once #50 is merged and #89 provides a stable nanobind base, I’ll add the corresponding Please feel free to let me know if I can help with any related issues or reviews in the meantime. I’d be happy to assist. |
This PR is the initial port that migrates the original Boost.Python bindings to nanobind as mentioned in diffpy/pyobjcryst#88, noticed future improvements will be mentioned in TODOs but will be addressed in future PRs.