Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Nov 27, 2023. It is now read-only.
build metrics compatibility for next 22.06 - #2151
Merged
nicksieger merged 1 commit intoJul 27, 2022
Merged
Conversation
crazy-maxforce-pushed
the
build-metrics-futureproof
branch
from
May 23, 2022 07:08
58700a7 to
5b8f702Comparemat007
approved these changes
May 23, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
crazy-maxforce-pushed
the
build-metrics-futureproof
branch
from
May 23, 2022 13:20
5b8f702 to
42f0e08Comparecrazy-max
marked this pull request as draft
May 23, 2022 17:11
crazy-max
commented
May 23, 2022
ContributorAuthor
converting to draft for now. after discussing with @tonistiigi, calling |
crazy-maxforce-pushed
the
build-metrics-futureproof
branch
from
May 26, 2022 07:24
42f0e08 to
1667e0bComparecrazy-max
marked this pull request as ready for review
June 13, 2022 08:51
rumpl
reviewed
Jun 27, 2022
Uh oh!
There was an error while loading. Please reload this page.
Merged
crazy-max
marked this pull request as draft
July 24, 2022 07:02
crazy-maxforce-pushed
the
build-metrics-futureproof
branch
from
July 25, 2022 13:27
1667e0b to
37d3c02CompareContributorAuthor
Switch from shelling out to retrieve docker cli version by using the |
crazy-max
marked this pull request as ready for review
July 25, 2022 13:31
crazy-maxforce-pushed
the
build-metrics-futureproof
branch
4 times, most recently
from
July 25, 2022 19:45
8182ed4 to
69495d8CompareSigned-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-maxforce-pushed
the
build-metrics-futureproof
branch
from
July 27, 2022 15:31
69495d8 to
668b262Comparenicksieger
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up docker/cli#3314 and #2104
Ensures build metrics are future proof for the next Docker major release.
To detect if buildx will be used while typing
docker build ..., we need to check the current docker cli version. I don't think there is another simple way, besides creating an infamous custom dimension in Looker. 😅cc @tonistiigi@chris-crone@gtardif@mat007
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com