Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Go 1.18 - #2174

Merged
glours merged 2 commits into
docker-archive:mainfrom
crazy-max:go-1.18
Jul 25, 2022
Merged

Go 1.18#2174
glours merged 2 commits into
docker-archive:mainfrom
crazy-max:go-1.18

Conversation

@crazy-max

@crazy-maxcrazy-max commented Jul 23, 2022

Copy link
Copy Markdown
Contributor

I plan to switch from shelling out to retrieve docker cli version by using the debug/buildinfo module in #2151 that will give resp time <1ms but this package is available since Go 1.18: crazy-max@ec18d50

Also upgrading to Go 1.18 will slightly improve response time of the compose-cli itself:

CliVersionViaComposeCli/compose-cli-1.0.26-docker-20.10.17 70.8ms ± 0%
CliVersionViaComposeCli/compose-cli-go-1.18-docker-20.10.17 62.5ms ± 0%

cc @tonistiigi@glours@rumpl

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@github-actionsgithub-actionsBot added aci ci Continuous integration cli cli ecs kube Kubernetes backend metrics labels Jul 23, 2022
@crazy-max
crazy-maxforce-pushed the go-1.18 branch 2 times, most recently from a342738 to 32429f1CompareJuly 23, 2022 22:25
@github-actionsgithub-actionsBot added the api api label Jul 23, 2022
@crazy-max

This comment was marked as outdated.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

@gloursglours left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanSchererStefanScherer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@glours
glours merged commit 8839c52 into docker-archive:mainJul 25, 2022
@crazy-max
crazy-max deleted the go-1.18 branch July 25, 2022 08:41
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

aciapiapiciContinuous integrationclicliecskubeKubernetes backendmetrics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@crazy-max@StefanScherer@glours