Skip to content

Update "munge-i386" to add "--build-context" in "docker buildx build" lines - #80

Merged
yosifkit merged 2 commits into
docker-library:masterfrom
infosiftr:i386-build-context
Oct 24, 2023
Merged

Update "munge-i386" to add "--build-context" in "docker buildx build" lines#80
yosifkit merged 2 commits into
docker-library:masterfrom
infosiftr:i386-build-context

Conversation

@tianon

Copy link
Copy Markdown
Member

Without this, we end up building against the wrong image due to a bug in buildx/buildkit (docker/buildx#1886). 😞

… lines
Without this, we end up building against the wrong image due to a bug in buildx/buildkit. 😞
@tianon

Copy link
Copy Markdown
MemberAuthor

(Because of this, we haven't noticed that RabbitMQ is failing to build on i386 and failing with a similar problem on arm32v7 😭)

@codecov-commenter

codecov-commenter commented Aug 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #80 (d3dede4) into master (2ff9004) will not change coverage.
Report is 7 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@ Coverage Diff @@## master #80 +/- ##
=======================================
Coverage 73.10% 73.10% =======================================
Files 7 7 Lines 714 714 =======================================
Hits 522 522 Misses 162 162 Partials 30 30 

@tianon

Copy link
Copy Markdown
MemberAuthor

Oh, I guess we could/should maybe add --platform linux/386 also?

@yosifkit

Copy link
Copy Markdown
Member

Oh, I guess we could/should maybe add --platform linux/386 also?

Agreed.

@tianon

Copy link
Copy Markdown
MemberAuthor

(oh, #81 is very related, although not exactly the same since munge-i386 is separate)

@yosifkit

Copy link
Copy Markdown
Member

Added a commit to address the --platform flag by building upon the provided flag from #81. (So now 81 is necessary for all the functionality here).

@tianon

Copy link
Copy Markdown
MemberAuthor

More heinous every time we touch it 😀

LGTM

@yosifkit
yosifkit merged commit a70de23 into docker-library:masterOct 24, 2023
@yosifkit
yosifkit deleted the i386-build-context branch October 24, 2023 23:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tianon@codecov-commenter@yosifkit